All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jun Nakajima" <jun.nakajima@intel.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 6/6] x86/vmx: Drop VMX signal for full real-mode
Date: Mon, 28 May 2018 15:27:58 +0100	[thread overview]
Message-ID: <1527517678-1779-7-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1527517678-1779-1-git-send-email-andrew.cooper3@citrix.com>

The hvmloader code which used this signal was deleted 10 years ago (c/s
50b12df83 "x86 vmx: Remove vmxassist").  Furthermore, the value gets discarded
anyway because the HVM domain builder unconditionally sets %rax to 0 in the
same action it uses to set %rip to the appropriate entrypoint.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/hvm/vmx/vmx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 8049264..4318b15 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -462,10 +462,6 @@ static int vmx_vcpu_initialise(struct vcpu *v)
 
     vmx_install_vlapic_mapping(v);
 
-    /* %eax == 1 signals full real-mode support to the guest loader. */
-    if ( v->vcpu_id == 0 )
-        v->arch.user_regs.rax = 1;
-
     return 0;
 }
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-05-28 14:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 14:27 [PATCH 0/6] x86/vmx: Misc fixes and improvements Andrew Cooper
2018-05-28 14:27 ` [PATCH 1/6] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit Andrew Cooper
2018-05-29 10:33   ` Jan Beulich
2018-05-29 18:08     ` Andrew Cooper
2018-05-30  7:32       ` Jan Beulich
2018-05-30 10:28         ` Andrew Cooper
2018-05-30 10:49           ` Jan Beulich
2018-05-30 17:34   ` [PATCH v2 " Andrew Cooper
2018-06-01  9:28     ` Jan Beulich
2018-06-05  7:54     ` Tian, Kevin
2018-05-28 14:27 ` [PATCH 2/6] x86: Improvements to ler debugging Andrew Cooper
2018-05-29 11:39   ` Jan Beulich
2018-05-29 18:09     ` Andrew Cooper
2018-06-05  7:55   ` Tian, Kevin
2018-05-28 14:27 ` [PATCH 3/6] x86/pat: Simplify host PAT handling Andrew Cooper
2018-05-29 11:40   ` Jan Beulich
2018-06-06  9:39   ` Roger Pau Monné
2018-05-28 14:27 ` [PATCH 4/6] x86/vmx: Simplify PAT handling during vcpu construction Andrew Cooper
2018-05-29 11:41   ` Jan Beulich
2018-06-05  7:57   ` Tian, Kevin
2018-06-06  9:42   ` Roger Pau Monné
2018-05-28 14:27 ` [PATCH 5/6] x86/vmx: Defer vmx_vmcs_exit() as long as possible in construct_vmcs() Andrew Cooper
2018-05-29 11:43   ` Jan Beulich
2018-06-05  8:00   ` Tian, Kevin
2018-06-06  9:45   ` Roger Pau Monné
2018-06-06 10:11     ` Andrew Cooper
2018-05-28 14:27 ` Andrew Cooper [this message]
2018-06-05  8:01   ` [PATCH 6/6] x86/vmx: Drop VMX signal for full real-mode Tian, Kevin
2018-06-06 10:03   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527517678-1779-7-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.