Re: [PATCH v2 1/6] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit

From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/6] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit
Date: Fri, 01 Jun 2018 03:28:09 -0600	[thread overview]
Message-ID: <5B1111A902000078001C764A@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1527701684-4083-1-git-send-email-andrew.cooper3@citrix.com>

>>> On 30.05.18 at 19:34, <andrew.cooper3@citrix.com> wrote:
> @@ -117,6 +115,9 @@ integer_param("debug_stack_lines", debug_stack_lines);
>  static bool opt_ler;
>  boolean_param("ler", opt_ler);
>  
> +/* LastExceptionFromIP on this hardware.  Zero if LER is not in use. */
> +uint32_t __read_mostly ler_msr;

Hmm, this is still uint32_t rather than unsigned int, while you did change
calc_ler_msr()'s return type.

> +void percpu_traps_init(void)
> +{
> +    subarch_percpu_traps_init();
> +
> +    if ( !opt_ler )
> +        return;
> +
> +    if ( !ler_msr && (ler_msr = calc_ler_msr()) )
> +        setup_force_cpu_cap(X86_FEATURE_XEN_LBR);

I assume it was on purpose that you've adjusted the commit message
rather than the code here regarding the possibility of pointless multiple
invocation?

With preferably the type inconsistency addressed
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel