Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

From: Luca Weiss <luca@z3ntu.xyz>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	"open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" 
	<linux-input@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node
Date: Tue, 04 Jun 2019 17:07:57 +0200	[thread overview]
Message-ID: <1832388.aQYCy0c1Lq@g550jk> (raw)
In-Reply-To: <20190604145907.j3fp52gxupd3bkih@flea>

[-- Attachment #1: Type: text/plain, Size: 2684 bytes --]

Hi Maxime,
sorry I forgot to mark it as a v2 and add the changelog to v1.

I've actually not split the patch into two on purpose as it's a pretty small 
change and the patch adding support for the A83T didn't split out the device 
tree changes - and recently in another patch of mine, the extra devicetree 
patch was squashed into the driver patch by the maintainer while merging. I'll 
fix this up asap.

Luca

On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote:
> Hi Luca,
> 
> On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote:
> > Add a node describing the KEYADC on the A64.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> 
> You should have a changelog detailing which changes you made to your
> patch with the previous version, and why you made those changes (for
> example because we looked at the a83t datasheet and found the two
> controllers to be very similar).
> 
> > ---
> > 
> >  .../devicetree/bindings/input/sun4i-lradc-keys.txt        | 1 +
> >  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi             | 8 ++++++++
> >  2 files changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> > b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index
> > 496125c6bfb7..507b737612ea 100644
> > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> > 
> > @@ -5,6 +5,7 @@ Required properties:
> >   - compatible: should be one of the following string:
> >  		"allwinner,sun4i-a10-lradc-keys"
> >  		"allwinner,sun8i-a83t-r-lradc"
> > 
> > +		"allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-
lradc"
> > 
> >   - reg: mmio address range of the chip
> >   - interrupts: interrupt to which the chip is connected
> >   - vref-supply: powersupply for the lradc reference voltage
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> > 7734f70e1057..3a42352b5c9f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -704,6 +704,14 @@
> > 
> >  			status = "disabled";
> >  		
> >  		};
> > 
> > +		lradc: lradc@1c21800 {
> > +			compatible = "allwinner,sun50i-a64-lradc",
> > +				     "allwinner,sun8i-a83t-r-
lradc";
> > +			reg = <0x01c21800 0x400>;
> > +			interrupts = <GIC_SPI 30 
IRQ_TYPE_LEVEL_HIGH>;
> > +			status = "disabled";
> > +		};
> > +
> 
> The bindings and the dt changes should be two different patches as
> well.
> 
> Thanks!
> Maxime
> 
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]