All of lore.kernel.org
 help / color / mirror / Atom feed
From: Orlando Chamberlain <redecorating@protonmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"gargaditya08@live.com" <gargaditya08@live.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"hare@suse.de" <hare@suse.de>,
	"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Sun, 26 Sep 2021 03:53:28 +0000	[thread overview]
Message-ID: <1a6f5030-27d9-d1ae-aff4-0ed2a10dce6b@protonmail.com> (raw)
In-Reply-To: <20210926020839.GA96176@C02WT3WMHTD6>

On 26/9/21 12:08, Keith Busch wrote:
> On Sat, Sep 25, 2021 at 11:40:19PM +0000, Orlando Chamberlain wrote:
>> I've managed to get it to boot by commenting out the counter increment, which might work
>> as a quirk:
> 
> Great, that's essentially what I proposed in a different thread (sorry, I see
> now you were not copied there):
> 
>   http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
> 
> The final patch may look a bit different, but it should be okay to test with
> the one in the link.
> 
I've tried that patch, it doesn't crash, but /dev/nvme0, /dev/nvme0n1 etc don't show up so
it doesn't progress past the initramfs. There weren't any errors other than preexisting
acpi table ones.

(I sent this a few minutes ago but I forgot to reply all so here it is again)


WARNING: multiple messages have this Message-ID (diff)
From: Orlando Chamberlain <redecorating@protonmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"gargaditya08@live.com" <gargaditya08@live.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"hare@suse.de" <hare@suse.de>,
	"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Sun, 26 Sep 2021 03:53:28 +0000	[thread overview]
Message-ID: <1a6f5030-27d9-d1ae-aff4-0ed2a10dce6b@protonmail.com> (raw)
In-Reply-To: <20210926020839.GA96176@C02WT3WMHTD6>

On 26/9/21 12:08, Keith Busch wrote:
> On Sat, Sep 25, 2021 at 11:40:19PM +0000, Orlando Chamberlain wrote:
>> I've managed to get it to boot by commenting out the counter increment, which might work
>> as a quirk:
> 
> Great, that's essentially what I proposed in a different thread (sorry, I see
> now you were not copied there):
> 
>   http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
> 
> The final patch may look a bit different, but it should be okay to test with
> the one in the link.
> 
I've tried that patch, it doesn't crash, but /dev/nvme0, /dev/nvme0n1 etc don't show up so
it doesn't progress past the initramfs. There weren't any errors other than preexisting
acpi table ones.

(I sent this a few minutes ago but I forgot to reply all so here it is again)


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-09-26  3:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25 13:10 [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD Orlando Chamberlain
2021-09-25 13:10 ` Orlando Chamberlain
2021-09-25 17:16 ` Keith Busch
2021-09-25 17:16   ` Keith Busch
2021-09-25 23:40   ` Orlando Chamberlain
2021-09-25 23:40     ` Orlando Chamberlain
2021-09-26  2:08     ` Keith Busch
2021-09-26  2:08       ` Keith Busch
2021-09-26  3:53       ` Orlando Chamberlain [this message]
2021-09-26  3:53         ` Orlando Chamberlain
2021-09-26  4:35         ` Orlando Chamberlain
2021-09-26  4:35           ` Orlando Chamberlain
     [not found]           ` <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-26  8:44             ` Sagi Grimberg
2021-09-26  8:44               ` Sagi Grimberg
2021-09-27  4:22               ` Orlando Chamberlain
2021-09-27  4:22                 ` Orlando Chamberlain
2021-09-27  4:51                 ` Aditya Garg
2021-09-27  4:51                   ` Aditya Garg
2021-09-27  6:05                   ` Sven Peter
2021-09-27  6:05                     ` Sven Peter
2021-09-27 15:02                     ` Keith Busch
2021-09-27 15:02                       ` Keith Busch
2021-09-26  5:59 ` Thorsten Leemhuis
2021-10-04  9:17   ` Thorsten Leemhuis
2021-10-04  9:27     ` Greg KH
2021-10-04 10:11       ` Thorsten Leemhuis
2021-10-04 11:36         ` Greg KH
2021-10-05  5:50           ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a6f5030-27d9-d1ae-aff4-0ed2a10dce6b@protonmail.com \
    --to=redecorating@protonmail.com \
    --cc=dwagner@suse.de \
    --cc=gargaditya08@live.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=regressions@lists.linux.dev \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.