From: Sagi Grimberg <sagi@grimberg.me>
To: Aditya Garg <gargaditya08@live.com>,
Orlando Chamberlain <redecorating@protonmail.com>,
"kbusch@kernel.org" <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"hare@suse.de" <hare@suse.de>,
"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Sun, 26 Sep 2021 11:44:03 +0300 [thread overview]
Message-ID: <d65ecc69-35c9-4400-8fb0-95aa04360b03@grimberg.me> (raw)
In-Reply-To: <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
> I checked out the proposal sent by Orlando Chamberlain to replace NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html. The , still causes panics to the T2 as described before. In the case of |, the kernel boots correctly without panicking the T2, but in case we are having Linux on an External Drive, which is my case, then the internal SSD doesn't seem to be recognised at all. I've tested the patch on 5.14.7.
That sounds like a separate issue, because with this patch applied,
all tags should be within the queue entry range (with generation
set to 0 always).
Is it possible that the io_queue_depth is being set to something
that exceeds NVME_PCI_MAX_QUEUE_SIZE (4095) ? the default is 1024
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me>
To: Aditya Garg <gargaditya08@live.com>,
Orlando Chamberlain <redecorating@protonmail.com>,
"kbusch@kernel.org" <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"hare@suse.de" <hare@suse.de>,
"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Sun, 26 Sep 2021 11:44:03 +0300 [thread overview]
Message-ID: <d65ecc69-35c9-4400-8fb0-95aa04360b03@grimberg.me> (raw)
In-Reply-To: <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
> I checked out the proposal sent by Orlando Chamberlain to replace NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html. The , still causes panics to the T2 as described before. In the case of |, the kernel boots correctly without panicking the T2, but in case we are having Linux on an External Drive, which is my case, then the internal SSD doesn't seem to be recognised at all. I've tested the patch on 5.14.7.
That sounds like a separate issue, because with this patch applied,
all tags should be within the queue entry range (with generation
set to 0 always).
Is it possible that the io_queue_depth is being set to something
that exceeds NVME_PCI_MAX_QUEUE_SIZE (4095) ? the default is 1024
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-26 8:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 13:10 [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD Orlando Chamberlain
2021-09-25 13:10 ` Orlando Chamberlain
2021-09-25 17:16 ` Keith Busch
2021-09-25 17:16 ` Keith Busch
2021-09-25 23:40 ` Orlando Chamberlain
2021-09-25 23:40 ` Orlando Chamberlain
2021-09-26 2:08 ` Keith Busch
2021-09-26 2:08 ` Keith Busch
2021-09-26 3:53 ` Orlando Chamberlain
2021-09-26 3:53 ` Orlando Chamberlain
2021-09-26 4:35 ` Orlando Chamberlain
2021-09-26 4:35 ` Orlando Chamberlain
[not found] ` <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-26 8:44 ` Sagi Grimberg [this message]
2021-09-26 8:44 ` Sagi Grimberg
2021-09-27 4:22 ` Orlando Chamberlain
2021-09-27 4:22 ` Orlando Chamberlain
2021-09-27 4:51 ` Aditya Garg
2021-09-27 4:51 ` Aditya Garg
2021-09-27 6:05 ` Sven Peter
2021-09-27 6:05 ` Sven Peter
2021-09-27 15:02 ` Keith Busch
2021-09-27 15:02 ` Keith Busch
2021-09-26 5:59 ` Thorsten Leemhuis
2021-10-04 9:17 ` Thorsten Leemhuis
2021-10-04 9:27 ` Greg KH
2021-10-04 10:11 ` Thorsten Leemhuis
2021-10-04 11:36 ` Greg KH
2021-10-05 5:50 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d65ecc69-35c9-4400-8fb0-95aa04360b03@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=gargaditya08@live.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=redecorating@protonmail.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.