[lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon

[lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon

[Andre Prendel]

Hello Jean,

Another week another patch series :)

There are two new patches. To make you happy I split up the change of
the function pointer signature into a separate patch (5/8). Patch 7/8
fixes the unhandled return value of idChip (see your comment in Patch
v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I
hope I don't have missed one of the minor issues. The changes are
explained in the patches too.

BTW thanks for your effort to review my patches.

Regards,
Andre

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

[Jean Delvare]

Hi Andre,

On Tue, 3 Nov 2009 21:01:44 +0100, Andre Prendel wrote:
> Another week another patch series :)
> 
> There are two new patches. To make you happy I split up the change of
> the function pointer signature into a separate patch (5/8). Patch 7/8
> fixes the unhandled return value of idChip (see your comment in Patch
> v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I
> hope I don't have missed one of the minor issues. The changes are
> explained in the patches too.
> 
> BTW thanks for your effort to review my patches.

You're welcome. I've made some more minor comments, but in general I
think your patch series is ready to be merged now. Go ahead!

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

[Jean Delvare]

Hi Andre,

On Wed, 4 Nov 2009 20:17:42 +0100, Andre Prendel wrote:
> On Wed, Nov 04, 2009 at 10:11:12AM +0100, Jean Delvare wrote:
> > You're welcome. I've made some more minor comments, but in general I
> > think your patch series is ready to be merged now. Go ahead!
> 
> I've just merged the patches with the minor changes due to your
> comments.

Great, thanks. Nothing worth mentioning in CHANGES?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors

[Jean Delvare]

On Thu, 5 Nov 2009 20:29:03 +0100, Andre Prendel wrote:
> On Thu, Nov 05, 2009 at 10:22:03AM +0100, Jean Delvare wrote:
> > Hi Andre,
> 
> Hi Jean,
> 
> > On Wed, 4 Nov 2009 20:17:42 +0100, Andre Prendel wrote:
> > > On Wed, Nov 04, 2009 at 10:11:12AM +0100, Jean Delvare wrote:
> > > > You're welcome. I've made some more minor comments, but in general I
> > > > think your patch series is ready to be merged now. Go ahead!
> > > 
> > > I've just merged the patches with the minor changes due to your
> > > comments.
> > 
> > Great, thanks. Nothing worth mentioning in CHANGES?
> 
> Damn, I forget this every time. Otherwise I think we don't need this
> refactoring in the CHANGES file. IHMO it is'nt interesting for the
> user, is it?

You don't need to say too much, indeed. But the log is also for us to a
certain extent. Mentioning that cleanups and refactoring happened is a
good hint if anything breaks. Useful when writing the freshmeat
announcements, too.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors