* [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon
@ 2009-11-03 20:01 Andre Prendel
2009-11-04 9:11 ` [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors Jean Delvare
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andre Prendel @ 2009-11-03 20:01 UTC (permalink / raw)
To: lm-sensors
Hello Jean,
Another week another patch series :)
There are two new patches. To make you happy I split up the change of
the function pointer signature into a separate patch (5/8). Patch 7/8
fixes the unhandled return value of idChip (see your comment in Patch
v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I
hope I don't have missed one of the minor issues. The changes are
explained in the patches too.
BTW thanks for your effort to review my patches.
Regards,
Andre
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors
2009-11-03 20:01 [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon Andre Prendel
@ 2009-11-04 9:11 ` Jean Delvare
2009-11-05 9:22 ` Jean Delvare
2009-11-05 20:19 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2009-11-04 9:11 UTC (permalink / raw)
To: lm-sensors
Hi Andre,
On Tue, 3 Nov 2009 21:01:44 +0100, Andre Prendel wrote:
> Another week another patch series :)
>
> There are two new patches. To make you happy I split up the change of
> the function pointer signature into a separate patch (5/8). Patch 7/8
> fixes the unhandled return value of idChip (see your comment in Patch
> v2 5/8). I've ignored the strcat() issue for now (also from v2 5/8). I
> hope I don't have missed one of the minor issues. The changes are
> explained in the patches too.
>
> BTW thanks for your effort to review my patches.
You're welcome. I've made some more minor comments, but in general I
think your patch series is ready to be merged now. Go ahead!
Thanks,
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors
2009-11-03 20:01 [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon Andre Prendel
2009-11-04 9:11 ` [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors Jean Delvare
@ 2009-11-05 9:22 ` Jean Delvare
2009-11-05 20:19 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2009-11-05 9:22 UTC (permalink / raw)
To: lm-sensors
Hi Andre,
On Wed, 4 Nov 2009 20:17:42 +0100, Andre Prendel wrote:
> On Wed, Nov 04, 2009 at 10:11:12AM +0100, Jean Delvare wrote:
> > You're welcome. I've made some more minor comments, but in general I
> > think your patch series is ready to be merged now. Go ahead!
>
> I've just merged the patches with the minor changes due to your
> comments.
Great, thanks. Nothing worth mentioning in CHANGES?
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors
2009-11-03 20:01 [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon Andre Prendel
2009-11-04 9:11 ` [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors Jean Delvare
2009-11-05 9:22 ` Jean Delvare
@ 2009-11-05 20:19 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2009-11-05 20:19 UTC (permalink / raw)
To: lm-sensors
On Thu, 5 Nov 2009 20:29:03 +0100, Andre Prendel wrote:
> On Thu, Nov 05, 2009 at 10:22:03AM +0100, Jean Delvare wrote:
> > Hi Andre,
>
> Hi Jean,
>
> > On Wed, 4 Nov 2009 20:17:42 +0100, Andre Prendel wrote:
> > > On Wed, Nov 04, 2009 at 10:11:12AM +0100, Jean Delvare wrote:
> > > > You're welcome. I've made some more minor comments, but in general I
> > > > think your patch series is ready to be merged now. Go ahead!
> > >
> > > I've just merged the patches with the minor changes due to your
> > > comments.
> >
> > Great, thanks. Nothing worth mentioning in CHANGES?
>
> Damn, I forget this every time. Otherwise I think we don't need this
> refactoring in the CHANGES file. IHMO it is'nt interesting for the
> user, is it?
You don't need to say too much, indeed. But the log is also for us to a
certain extent. Mentioning that cleanups and refactoring happened is a
good hint if anything breaks. Useful when writing the freshmeat
announcements, too.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-05 20:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-03 20:01 [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors deamon Andre Prendel
2009-11-04 9:11 ` [lm-sensors] [PATCH v3 0/8] sensord: Cleanup of the sensors Jean Delvare
2009-11-05 9:22 ` Jean Delvare
2009-11-05 20:19 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.