From: David Miller <davem@davemloft.net>
To: dcbw@redhat.com
Cc: micha@neli.hopto.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] ipconfig wait for carrier
Date: Thu, 19 May 2011 15:19:45 -0400 (EDT) [thread overview]
Message-ID: <20110519.151945.60111725625001721.davem@davemloft.net> (raw)
In-Reply-To: <1305819120.3271.3.camel@dcbw.foobar.com>
From: Dan Williams <dcbw@redhat.com>
Date: Thu, 19 May 2011 10:31:58 -0500
> On Wed, 2011-05-18 at 18:14 -0400, David Miller wrote:
>> From: Micha Nelissen <micha@neli.hopto.org>
>> Date: Wed, 18 May 2011 08:59:32 +0200
>>
>> > Op 2011-05-18 8:37, David Miller schreef:
>> >> From: Micha Nelissen<micha@neli.hopto.org>
>> >> Date: Wed, 18 May 2011 08:32:35 +0200
>> >>
>> >>> I'm confused. Against which tree/commit do you want it then?
>> >>
>> >> Linus's current tree would be fine as would:
>> >>
>> >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git
>> >
>> > Ok I see, thanks. The patch should apply just fine to your tree, there
>> > is only a spelling change since 2.6.38 which does not conflict.
>>
>> Please fix ic_is_init_dev() to return a proper boolean "false" instead
>> of "0" when IFF_LOOPBACK is set.
>
> Shouldn't the code still wait at *least* one second? Not all drivers
> support carrier detect, and those that don't set the carrier always-on.
> Thus older devices that used to have 1s to get carrier in line (even if
> they don't report it) now have only 10ms.
>
> I think it should wait at least one second like the code currently does,
> and then if the carrier still isn't up, wait longer.
Agreed.
next prev parent reply other threads:[~2011-05-19 19:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 20:36 [PATCH] ipconfig wait for carrier Micha Nelissen
2011-05-16 18:02 ` David Miller
2011-05-17 21:48 ` [PATCH v2] " Micha Nelissen
2011-05-18 5:22 ` [PATCH v3] " Micha Nelissen
2011-05-18 6:07 ` David Miller
2011-05-18 6:32 ` Micha Nelissen
2011-05-18 6:37 ` David Miller
2011-05-18 6:59 ` Micha Nelissen
2011-05-18 22:14 ` David Miller
2011-05-19 15:31 ` Dan Williams
2011-05-19 18:52 ` Micha Nelissen
2011-05-19 19:32 ` Dan Williams
2011-05-19 19:19 ` David Miller [this message]
2011-05-19 19:24 ` Micha Nelissen
2011-05-19 19:35 ` David Miller
2011-05-19 19:39 ` Micha Nelissen
2011-05-19 19:47 ` David Miller
2011-05-19 19:36 ` Dan Williams
2011-05-19 20:14 ` [PATCH v4] " Micha Nelissen
2011-05-19 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519.151945.60111725625001721.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=micha@neli.hopto.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.