All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: micha@neli.hopto.org
Cc: dcbw@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] ipconfig wait for carrier
Date: Thu, 19 May 2011 15:35:07 -0400 (EDT)	[thread overview]
Message-ID: <20110519.153507.578609630787612821.davem@davemloft.net> (raw)
In-Reply-To: <4DD56E7A.3010901@neli.hopto.org>

From: Micha Nelissen <micha@neli.hopto.org>
Date: Thu, 19 May 2011 21:24:42 +0200

> Dan Williams wrote:
>> Shouldn't the code still wait at *least* one second?  Not all drivers
>> support carrier detect, and those that don't set the carrier always-on.
>> Thus older devices that used to have 1s to get carrier in line (even if
>> they don't report it) now have only 10ms.
> 
> Btw, it does not matter much, there are 2 cases:
> 1) DHCP: dhcp will retry every few seconds, so if link is not up, then a
> later try will succeed
> 2) Static IP: an ARP request is performed every second, so the second
> request will be answered instead of the first.
> 
> Even if link is "fake up" by driver and not actually up after 10 msecs,
> things will continue to work (eventually), after a second, just like now.

But this eats one of the CONF_SEND_RETRIES attempts, which is only 6.

  reply	other threads:[~2011-05-19 19:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-14 20:36 [PATCH] ipconfig wait for carrier Micha Nelissen
2011-05-16 18:02 ` David Miller
2011-05-17 21:48 ` [PATCH v2] " Micha Nelissen
2011-05-18  5:22 ` [PATCH v3] " Micha Nelissen
2011-05-18  6:07   ` David Miller
2011-05-18  6:32     ` Micha Nelissen
2011-05-18  6:37       ` David Miller
2011-05-18  6:59         ` Micha Nelissen
2011-05-18 22:14           ` David Miller
2011-05-19 15:31             ` Dan Williams
2011-05-19 18:52               ` Micha Nelissen
2011-05-19 19:32                 ` Dan Williams
2011-05-19 19:19               ` David Miller
2011-05-19 19:24               ` Micha Nelissen
2011-05-19 19:35                 ` David Miller [this message]
2011-05-19 19:39                   ` Micha Nelissen
2011-05-19 19:47                     ` David Miller
2011-05-19 19:36                 ` Dan Williams
2011-05-19 20:14 ` [PATCH v4] " Micha Nelissen
2011-05-19 20:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519.153507.578609630787612821.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dcbw@redhat.com \
    --cc=micha@neli.hopto.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.