From: Micha Nelissen <micha@neli.hopto.org>
To: Dan Williams <dcbw@redhat.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v3] ipconfig wait for carrier
Date: Thu, 19 May 2011 20:52:49 +0200 [thread overview]
Message-ID: <4DD56701.8040007@neli.hopto.org> (raw)
In-Reply-To: <1305819120.3271.3.camel@dcbw.foobar.com>
Dan Williams wrote:
> On Wed, 2011-05-18 at 18:14 -0400, David Miller wrote:
>> Please fix ic_is_init_dev() to return a proper boolean "false" instead
>> of "0" when IFF_LOOPBACK is set.
Ok. Had an int before, but boolean is better.
> Shouldn't the code still wait at *least* one second? Not all drivers
> support carrier detect, and those that don't set the carrier always-on.
> Thus older devices that used to have 1s to get carrier in line (even if
> they don't report it) now have only 10ms.
>
> I think it should wait at least one second like the code currently does,
> and then if the carrier still isn't up, wait longer.
What is the 1 second based on?
If a driver does not support carrier detect, then this code will wait
for the timeout period. Or do those older drivers set carrier detect
immediately when device is probed?
Micha
next prev parent reply other threads:[~2011-05-19 18:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 20:36 [PATCH] ipconfig wait for carrier Micha Nelissen
2011-05-16 18:02 ` David Miller
2011-05-17 21:48 ` [PATCH v2] " Micha Nelissen
2011-05-18 5:22 ` [PATCH v3] " Micha Nelissen
2011-05-18 6:07 ` David Miller
2011-05-18 6:32 ` Micha Nelissen
2011-05-18 6:37 ` David Miller
2011-05-18 6:59 ` Micha Nelissen
2011-05-18 22:14 ` David Miller
2011-05-19 15:31 ` Dan Williams
2011-05-19 18:52 ` Micha Nelissen [this message]
2011-05-19 19:32 ` Dan Williams
2011-05-19 19:19 ` David Miller
2011-05-19 19:24 ` Micha Nelissen
2011-05-19 19:35 ` David Miller
2011-05-19 19:39 ` Micha Nelissen
2011-05-19 19:47 ` David Miller
2011-05-19 19:36 ` Dan Williams
2011-05-19 20:14 ` [PATCH v4] " Micha Nelissen
2011-05-19 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD56701.8040007@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.