From: "Daniel P. Berrange" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
mst@redhat.com, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults
Date: Thu, 14 May 2015 13:48:56 +0100 [thread overview]
Message-ID: <20150514124856.GG3441@redhat.com> (raw)
In-Reply-To: <87egmjz5sl.fsf@blackfin.pond.sub.org>
On Thu, May 14, 2015 at 02:45:30PM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 14/05/2015 14:02, Markus Armbruster wrote:
> >> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards
> >> commonly don't have an FDC (depends on the Super I/O chip used).
> >>
> >> We may want to keep it off for pc-i440fx-2.4 and newer. I doubt
> >> there's a real i440FX without an FDC, but our virtual i440FX is quite
> >> unlike a real one in other ways already.
> >
> > That would break libvirt for people upgrading from 2.3 to 2.4. So it's
> > more like pc-i440fx-3.0 and pc-q35-3.0.
>
> What exactly breaks when?
[quote]
* Create the FDC only if the option is "on".
* Optional: make -drive if=floppy,... auto-enable it
I wouldn't bother doing the same for -global isa-fdc.driveA=... and
such.
[/quote]
Libvirt uses -global when enabling floppy devices. So since current libvirt
does not know about the new (to be created) machine type property to turn
on FDC, it will get an error using -global isa-fdc.driveA=
I'm not too bothered about this, as long as libvirt has enough advance
notice to add support for the new machine type property to enable FDC
before we change its default value to be "off". Perhaps one QEMU major
release cycle before toggling the default, to give time for new libvirt
to penetrate to distros
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
mst@redhat.com, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
rth@twiddle.net
Subject: Re: [PATCH] Do not emulate a floppy drive when -nodefaults
Date: Thu, 14 May 2015 13:48:56 +0100 [thread overview]
Message-ID: <20150514124856.GG3441@redhat.com> (raw)
In-Reply-To: <87egmjz5sl.fsf@blackfin.pond.sub.org>
On Thu, May 14, 2015 at 02:45:30PM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 14/05/2015 14:02, Markus Armbruster wrote:
> >> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards
> >> commonly don't have an FDC (depends on the Super I/O chip used).
> >>
> >> We may want to keep it off for pc-i440fx-2.4 and newer. I doubt
> >> there's a real i440FX without an FDC, but our virtual i440FX is quite
> >> unlike a real one in other ways already.
> >
> > That would break libvirt for people upgrading from 2.3 to 2.4. So it's
> > more like pc-i440fx-3.0 and pc-q35-3.0.
>
> What exactly breaks when?
[quote]
* Create the FDC only if the option is "on".
* Optional: make -drive if=floppy,... auto-enable it
I wouldn't bother doing the same for -global isa-fdc.driveA=... and
such.
[/quote]
Libvirt uses -global when enabling floppy devices. So since current libvirt
does not know about the new (to be created) machine type property to turn
on FDC, it will get an error using -global isa-fdc.driveA=
I'm not too bothered about this, as long as libvirt has enough advance
notice to add support for the new machine type property to enable FDC
before we change its default value to be "off". Perhaps one QEMU major
release cycle before toggling the default, to give time for new libvirt
to penetrate to distros
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-05-14 12:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 17:29 [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults Stefano Stabellini
2015-05-13 17:29 ` Stefano Stabellini
2015-05-13 17:42 ` [Qemu-devel] " Daniel P. Berrange
2015-05-13 17:42 ` Daniel P. Berrange
2015-05-13 18:15 ` [Qemu-devel] " Stefano Stabellini
2015-05-13 18:15 ` Stefano Stabellini
2015-05-13 21:46 ` [Qemu-devel] " John Snow
2015-05-13 21:46 ` John Snow
2015-05-14 11:12 ` [Qemu-devel] " Stefano Stabellini
2015-05-14 11:12 ` Stefano Stabellini
2015-05-14 11:18 ` [Qemu-devel] " Daniel P. Berrange
2015-05-14 11:18 ` Daniel P. Berrange
2015-05-14 11:46 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 11:46 ` Michael S. Tsirkin
2015-05-14 12:02 ` [Qemu-devel] " Markus Armbruster
2015-05-14 12:02 ` Markus Armbruster
2015-05-14 12:11 ` [Qemu-devel] " Paolo Bonzini
2015-05-14 12:11 ` Paolo Bonzini
2015-05-14 12:45 ` [Qemu-devel] " Markus Armbruster
2015-05-14 12:45 ` Markus Armbruster
2015-05-14 12:48 ` Daniel P. Berrange [this message]
2015-05-14 12:48 ` Daniel P. Berrange
2015-05-14 12:53 ` [Qemu-devel] " Paolo Bonzini
2015-05-14 12:53 ` Paolo Bonzini
2015-05-14 13:25 ` [Qemu-devel] [Xen-devel] " Sander Eikelenboom
2015-05-14 13:25 ` Sander Eikelenboom
2015-05-14 13:41 ` [Qemu-devel] " Daniel P. Berrange
2015-05-14 13:41 ` Daniel P. Berrange
2015-05-14 13:55 ` [Qemu-devel] " Paolo Bonzini
2015-05-14 13:55 ` Paolo Bonzini
2015-05-14 14:39 ` [Qemu-devel] " Stefano Stabellini
2015-05-14 14:39 ` Stefano Stabellini
2015-05-14 14:44 ` [Qemu-devel] " Paolo Bonzini
2015-05-14 14:44 ` Paolo Bonzini
2015-05-14 14:52 ` [Qemu-devel] " Stefano Stabellini
2015-05-14 14:52 ` Stefano Stabellini
2015-05-14 13:57 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 13:57 ` Michael S. Tsirkin
2015-05-14 14:07 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 14:07 ` Michael S. Tsirkin
2015-05-14 17:54 ` [Qemu-devel] " John Snow
2015-05-14 17:54 ` John Snow
2015-05-15 7:50 ` [Qemu-devel] " Markus Armbruster
2015-05-15 7:50 ` Markus Armbruster
2015-05-15 8:19 ` [Qemu-devel] " Paolo Bonzini
2015-05-15 8:19 ` Paolo Bonzini
2015-05-15 10:20 ` [Qemu-devel] " Stefano Stabellini
2015-05-15 10:20 ` Stefano Stabellini
2015-05-18 9:19 ` [Qemu-devel] " Kevin Wolf
2015-05-18 9:19 ` Kevin Wolf
2015-05-14 11:47 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 11:47 ` Michael S. Tsirkin
2015-05-14 11:54 ` [Qemu-devel] " Paolo Bonzini
2015-05-14 11:54 ` Paolo Bonzini
2015-05-14 11:56 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 11:56 ` Michael S. Tsirkin
2015-05-14 12:47 ` [Qemu-devel] " Markus Armbruster
2015-05-14 12:47 ` Markus Armbruster
2015-05-14 4:38 ` [Qemu-devel] " Stefan Weil
2015-05-14 4:38 ` Stefan Weil
2015-05-14 5:45 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 5:45 ` Michael S. Tsirkin
2015-05-13 21:44 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-13 21:44 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514124856.GG3441@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.