From: Arnd Bergmann <arnd@arndb.de> To: Tomasz Nowicki <tn@semihalf.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, okaya@codeaurora.org, bhelgaas@google.com, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, jiang.liu@linux.intel.com, stefano.stabellini@eu.citrix.com, robert.richter@caviumnetworks.com, mw@semihalf.com, liviu.dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, suravee.suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com Subject: Re: [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Date: Mon, 21 Dec 2015 15:15:54 +0100 [thread overview] Message-ID: <201512211515.55447.arnd@arndb.de> (raw) In-Reply-To: <5677F3C8.8040200@semihalf.com> On Monday 21 December 2015, Tomasz Nowicki wrote: > On 21.12.2015 13:10, Lorenzo Pieralisi wrote: > > On Fri, Dec 18, 2015 at 06:56:39PM +0000, okaya@codeaurora.org wrote: > >> I have multiple root ports with the same IO port configuration in the > >> current ACPI table. > >> > >> Root port 0 = IO range 0x1000-0x10FFF > >> Root port 1 = IO range 0x1000-0x10FFF > >> Root port 2 = IO range 0x1000-0x10FFF > > > > It is fine. You end up mapping for each of those a 4k window of the > > virtual address space allocated to IO and that's what you will have in > > the kernel PCI resources (not in the HW BARs though). If that was a problem > > it would be even for the current DT host controllers eg: > > > > arch/arm64/boot/dts/apm/apm-storm.dtsi > > > > it should not be (again I will let Arnd comment on this since he may be > > aware of issues encountered on other arches/platforms). > > > > Root port 0 = IO range 0x1000-0x10FFF > Root port 1 = IO range 0x1000-0x10FFF > Root port 2 = IO range 0x1000-0x10FFF > > If above ranges are mapped into different CPU windows, then yes, it is fine. Ideally, they should all be the same CPU address so we only have to map the window once, each device gets an address below 64K, and you can have legacy port numbers (below 4K) on any bus, which is required to make certain GPUs work. I haven't actually seen anyone do that on ARM though, every implementation so far has a separate mapping per host bridge, and we can cope with that too, and we can live with either overlapping bus addresses or unique bus addresses, any of them can be expressed by the PCI core in Linux, we just have to make sure that we correctly translate the firmware tables into our internal structures. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Date: Mon, 21 Dec 2015 15:15:54 +0100 [thread overview] Message-ID: <201512211515.55447.arnd@arndb.de> (raw) In-Reply-To: <5677F3C8.8040200@semihalf.com> On Monday 21 December 2015, Tomasz Nowicki wrote: > On 21.12.2015 13:10, Lorenzo Pieralisi wrote: > > On Fri, Dec 18, 2015 at 06:56:39PM +0000, okaya at codeaurora.org wrote: > >> I have multiple root ports with the same IO port configuration in the > >> current ACPI table. > >> > >> Root port 0 = IO range 0x1000-0x10FFF > >> Root port 1 = IO range 0x1000-0x10FFF > >> Root port 2 = IO range 0x1000-0x10FFF > > > > It is fine. You end up mapping for each of those a 4k window of the > > virtual address space allocated to IO and that's what you will have in > > the kernel PCI resources (not in the HW BARs though). If that was a problem > > it would be even for the current DT host controllers eg: > > > > arch/arm64/boot/dts/apm/apm-storm.dtsi > > > > it should not be (again I will let Arnd comment on this since he may be > > aware of issues encountered on other arches/platforms). > > > > Root port 0 = IO range 0x1000-0x10FFF > Root port 1 = IO range 0x1000-0x10FFF > Root port 2 = IO range 0x1000-0x10FFF > > If above ranges are mapped into different CPU windows, then yes, it is fine. Ideally, they should all be the same CPU address so we only have to map the window once, each device gets an address below 64K, and you can have legacy port numbers (below 4K) on any bus, which is required to make certain GPUs work. I haven't actually seen anyone do that on ARM though, every implementation so far has a separate mapping per host bridge, and we can cope with that too, and we can live with either overlapping bus addresses or unique bus addresses, any of them can be expressed by the PCI core in Linux, we just have to make sure that we correctly translate the firmware tables into our internal structures. Arnd
next prev parent reply other threads:[~2015-12-21 14:17 UTC|newest] Thread overview: 171+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-16 15:16 [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 01/23] x86, pci: Reorder logic of pci_mmconfig_insert() function Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 02/23] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 03/23] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 04/23] x86, pci: mmconfig_{32,64}.c code refactoring - remove code duplication Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 04/23] x86, pci: mmconfig_{32, 64}.c " Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 05/23] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-17 10:25 ` Tomasz Nowicki 2015-12-17 10:25 ` Tomasz Nowicki 2015-12-17 10:40 ` Tomasz Nowicki 2015-12-17 10:40 ` Tomasz Nowicki 2015-12-21 18:12 ` Stefano Stabellini 2015-12-21 18:12 ` Stefano Stabellini 2015-12-21 18:12 ` Stefano Stabellini 2015-12-22 8:34 ` Tomasz Nowicki 2015-12-22 8:34 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 07/23] pci, acpi, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 08/23] arm64, acpi: Use empty PCI config space accessors from mcfg.c file Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 09/23] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 10/23] x86, pci: Cleanup platform specific MCFG data using previously added ECAM hot_added flag Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2016-01-12 13:50 ` Lorenzo Pieralisi 2016-01-12 13:50 ` Lorenzo Pieralisi 2016-01-12 16:13 ` Tomasz Nowicki 2016-01-12 16:13 ` Tomasz Nowicki 2016-01-12 17:56 ` David Daney 2016-01-12 17:56 ` David Daney 2016-01-12 17:56 ` David Daney 2016-01-13 9:43 ` Tomasz Nowicki 2016-01-13 9:43 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 12/23] pci, acpi: Move ACPI host bridge device companion assignment to core code Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 13/23] x86, ia64, pci: Remove ACPI companion device from platform specific data Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 14/23] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 15/23] x86, ia64, pci: Convert arches to use PCI_DOMAINS_GENERIC Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 17/23] acpi, mcfg: Implement two calls that might be used to inject/remove MCFG region Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 18/23] x86, acpi, pci: Use equivalent function introduced in previous patch Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 19/23] acpi, mcfg: Add default PCI config accessors implementation and initial support for related quirks Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 20/23] ACPI, PCI: Refine the way to handle translation_offset for ACPI resources Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-18 12:40 ` Arnd Bergmann 2015-12-18 12:40 ` Arnd Bergmann 2015-12-21 10:21 ` Tomasz Nowicki 2015-12-21 10:21 ` Tomasz Nowicki 2015-12-16 15:16 ` [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-21 11:47 ` Gabriele Paoloni 2015-12-21 11:47 ` Gabriele Paoloni 2015-12-21 11:47 ` Gabriele Paoloni 2015-12-21 14:10 ` Arnd Bergmann 2015-12-21 14:10 ` Arnd Bergmann 2015-12-21 14:10 ` Arnd Bergmann 2015-12-21 14:10 ` Arnd Bergmann 2015-12-21 17:29 ` David Daney 2015-12-21 17:29 ` David Daney 2015-12-21 17:29 ` David Daney 2015-12-21 17:29 ` David Daney 2015-12-21 22:42 ` Arnd Bergmann 2015-12-21 22:42 ` Arnd Bergmann 2015-12-21 22:42 ` Arnd Bergmann 2015-12-21 22:42 ` Arnd Bergmann 2015-12-21 23:24 ` Jon Masters 2015-12-21 23:24 ` Jon Masters 2015-12-21 23:24 ` Jon Masters 2015-12-21 23:24 ` Jon Masters 2015-12-21 23:10 ` Jon Masters 2015-12-21 23:10 ` Jon Masters 2015-12-21 23:10 ` Jon Masters 2015-12-21 23:10 ` Jon Masters 2015-12-22 8:45 ` Tomasz Nowicki 2015-12-22 8:45 ` Tomasz Nowicki 2015-12-22 8:45 ` Tomasz Nowicki 2015-12-22 8:45 ` Tomasz Nowicki 2015-12-22 9:29 ` Gabriele Paoloni 2015-12-22 9:29 ` Gabriele Paoloni 2015-12-22 9:29 ` Gabriele Paoloni 2015-12-22 9:29 ` Gabriele Paoloni 2015-12-22 16:36 ` Jon Masters 2015-12-22 16:36 ` Jon Masters 2015-12-22 16:36 ` Jon Masters 2015-12-22 16:36 ` Jon Masters 2015-12-22 16:45 ` Jon Masters 2015-12-22 16:45 ` Jon Masters 2015-12-22 16:45 ` Jon Masters 2015-12-22 16:45 ` Jon Masters 2015-12-22 17:49 ` Gabriele Paoloni 2015-12-22 17:49 ` Gabriele Paoloni 2015-12-22 17:49 ` Gabriele Paoloni 2015-12-22 17:49 ` Gabriele Paoloni 2015-12-22 10:20 ` Tomasz Nowicki 2015-12-22 10:20 ` Tomasz Nowicki 2015-12-22 10:20 ` Tomasz Nowicki 2015-12-22 14:48 ` Gabriele Paoloni 2015-12-22 14:48 ` Gabriele Paoloni 2015-12-22 14:48 ` Gabriele Paoloni 2015-12-23 9:38 ` Hanjun Guo 2015-12-23 9:38 ` Hanjun Guo 2015-12-23 9:38 ` Hanjun Guo 2016-01-08 14:16 ` Mark Salter 2016-01-08 14:16 ` Mark Salter 2016-01-08 14:36 ` Tomasz Nowicki 2016-01-08 14:36 ` Tomasz Nowicki 2016-01-08 14:51 ` Mark Salter 2016-01-08 14:51 ` Mark Salter 2016-01-08 14:42 ` Jeremy Linton 2016-01-08 14:42 ` Jeremy Linton 2016-01-08 14:42 ` Jeremy Linton 2016-01-08 15:01 ` Mark Rutland 2016-01-08 15:01 ` Mark Rutland 2016-01-08 15:01 ` Mark Rutland 2016-01-08 15:12 ` Mark Rutland 2016-01-08 15:12 ` Mark Rutland 2016-01-08 16:07 ` Mark Salter 2016-01-08 16:07 ` Mark Salter 2015-12-16 15:16 ` [PATCH V2 23/23] arm64, pci, acpi: Start using ACPI based PCI host bridge driver for ARM64 Tomasz Nowicki 2015-12-16 15:16 ` Tomasz Nowicki 2015-12-17 21:24 ` [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Sinan Kaya 2015-12-17 21:24 ` Sinan Kaya 2015-12-18 12:26 ` Tomasz Nowicki 2015-12-18 12:26 ` Tomasz Nowicki 2015-12-18 18:56 ` okaya 2015-12-18 18:56 ` okaya at codeaurora.org 2015-12-21 10:37 ` Tomasz Nowicki 2015-12-21 10:37 ` Tomasz Nowicki 2015-12-21 12:10 ` Lorenzo Pieralisi 2015-12-21 12:10 ` Lorenzo Pieralisi 2015-12-21 12:42 ` Tomasz Nowicki 2015-12-21 12:42 ` Tomasz Nowicki 2015-12-21 14:15 ` Arnd Bergmann [this message] 2015-12-21 14:15 ` Arnd Bergmann 2015-12-21 15:26 ` Okaya 2015-12-21 15:26 ` Okaya at codeaurora.org 2015-12-21 22:39 ` Arnd Bergmann 2015-12-21 22:39 ` Arnd Bergmann 2016-01-11 15:39 ` Lorenzo Pieralisi 2016-01-11 15:39 ` Lorenzo Pieralisi 2016-01-11 15:56 ` Sinan Kaya 2016-01-11 15:56 ` Sinan Kaya 2016-01-12 14:30 ` Arnd Bergmann 2016-01-12 14:30 ` Arnd Bergmann 2016-01-12 18:38 ` Lorenzo Pieralisi 2016-01-12 18:38 ` Lorenzo Pieralisi 2016-01-12 21:37 ` Arnd Bergmann 2016-01-12 21:37 ` Arnd Bergmann 2016-01-11 16:09 ` Lorenzo Pieralisi 2016-01-11 16:09 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201512211515.55447.arnd@arndb.de \ --to=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=catalin.marinas@arm.com \ --cc=ddaney@caviumnetworks.com \ --cc=hanjun.guo@linaro.org \ --cc=jchandra@broadcom.com \ --cc=jcm@redhat.com \ --cc=jiang.liu@linux.intel.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=msalter@redhat.com \ --cc=mw@semihalf.com \ --cc=okaya@codeaurora.org \ --cc=rjw@rjwysocki.net \ --cc=robert.richter@caviumnetworks.com \ --cc=stefano.stabellini@eu.citrix.com \ --cc=suravee.suthikulpanit@amd.com \ --cc=tglx@linutronix.de \ --cc=tn@semihalf.com \ --cc=wangyijing@huawei.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.