All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: Robert Richter <rric-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Geetha Sowjanya
	<geethasowjanya.akula-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
	geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	Geetha sowjanya
	<gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	sudeep.holla-5wv7dgnIgG8@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Linu Cherian
	<linu.cherian-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
	sgoutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Charles.Garcia-Tobin-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74
Date: Mon, 8 May 2017 12:04:43 +0200	[thread overview]
Message-ID: <20170508100443.GG16981@rric.localdomain> (raw)
In-Reply-To: <b4881237-aca6-63ca-467e-30e36b1f02df-5wv7dgnIgG8@public.gmane.org>

On 08.05.17 10:59:46, Robin Murphy wrote:
> On 08/05/17 10:17, Linu Cherian wrote:
> > This actually results in more lines of changes. If you think the below
> > approach is still better, will post a V4 of this series with this change.
> 
> Why not just do this?:
> 
> static inline unsigned long page1_offset_adjust(
> 	unsigned long off, struct arm_smmu_device *smmu)
> {
> 	if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu))
> 		return (off - SZ_64K);
> 
> 	return off;
> }
> 
> AFAICS that should be the least disruptive way to go about it.

Yeah, let's go with this.

Thanks Robin,

-Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <robert.richter@cavium.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Linu Cherian <linu.cherian@cavium.com>,
	Robert Richter <rric@kernel.org>,
	Geetha sowjanya <gakula@caviumnetworks.com>,
	will.deacon@arm.com, lorenzo.pieralisi@arm.com,
	hanjun.guo@linaro.org, sudeep.holla@arm.com,
	iommu@lists.linux-foundation.org, jcm@redhat.com,
	linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
	sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org,
	linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com,
	Charles.Garcia-Tobin@arm.com,
	Geetha Sowjanya <geethasowjanya.akula@cavium.com>
Subject: Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74
Date: Mon, 8 May 2017 12:04:43 +0200	[thread overview]
Message-ID: <20170508100443.GG16981@rric.localdomain> (raw)
In-Reply-To: <b4881237-aca6-63ca-467e-30e36b1f02df@arm.com>

On 08.05.17 10:59:46, Robin Murphy wrote:
> On 08/05/17 10:17, Linu Cherian wrote:
> > This actually results in more lines of changes. If you think the below
> > approach is still better, will post a V4 of this series with this change.
> 
> Why not just do this?:
> 
> static inline unsigned long page1_offset_adjust(
> 	unsigned long off, struct arm_smmu_device *smmu)
> {
> 	if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu))
> 		return (off - SZ_64K);
> 
> 	return off;
> }
> 
> AFAICS that should be the least disruptive way to go about it.

Yeah, let's go with this.

Thanks Robin,

-Robert

WARNING: multiple messages have this Message-ID (diff)
From: robert.richter@cavium.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74
Date: Mon, 8 May 2017 12:04:43 +0200	[thread overview]
Message-ID: <20170508100443.GG16981@rric.localdomain> (raw)
In-Reply-To: <b4881237-aca6-63ca-467e-30e36b1f02df@arm.com>

On 08.05.17 10:59:46, Robin Murphy wrote:
> On 08/05/17 10:17, Linu Cherian wrote:
> > This actually results in more lines of changes. If you think the below
> > approach is still better, will post a V4 of this series with this change.
> 
> Why not just do this?:
> 
> static inline unsigned long page1_offset_adjust(
> 	unsigned long off, struct arm_smmu_device *smmu)
> {
> 	if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu))
> 		return (off - SZ_64K);
> 
> 	return off;
> }
> 
> AFAICS that should be the least disruptive way to go about it.

Yeah, let's go with this.

Thanks Robin,

-Robert

  parent reply	other threads:[~2017-05-08 10:04 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 12:08 [PATCH v3 0/7] Cavium ThunderX2 SMMUv3 errata workarounds Geetha sowjanya
2017-05-05 12:08 ` Geetha sowjanya
2017-05-05 12:08 ` [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74 Geetha sowjanya
2017-05-05 12:08   ` Geetha sowjanya
2017-05-05 22:26   ` Robert Richter
2017-05-05 22:26     ` Robert Richter
2017-05-05 23:03   ` Robert Richter
2017-05-05 23:03     ` Robert Richter
2017-05-08  9:17     ` Linu Cherian
2017-05-08  9:17       ` Linu Cherian
2017-05-08  9:29       ` Robert Richter
2017-05-08  9:29         ` Robert Richter
2017-05-08  9:59       ` Robin Murphy
2017-05-08  9:59         ` Robin Murphy
     [not found]         ` <b4881237-aca6-63ca-467e-30e36b1f02df-5wv7dgnIgG8@public.gmane.org>
2017-05-08 10:04           ` Robert Richter [this message]
2017-05-08 10:04             ` Robert Richter
2017-05-08 10:04             ` Robert Richter
     [not found] ` <1493986091-30521-1-git-send-email-gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2017-05-05 12:08   ` [PATCH v3 2/7] iommu/arm-smmu-v3: Do resource size checks based on SMMU Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 22:18     ` Robert Richter
2017-05-05 22:18       ` Robert Richter
     [not found]       ` <20170505221844.GW16981-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2017-05-08  9:44         ` Linu Cherian
2017-05-08  9:44           ` Linu Cherian
2017-05-08  9:44           ` Linu Cherian
2017-05-08 10:09           ` Robert Richter
2017-05-08 10:09             ` Robert Richter
2017-05-08 10:50             ` Linu Cherian
2017-05-08 10:50               ` Linu Cherian
2017-05-08 12:21               ` Robert Richter
2017-05-08 12:21                 ` Robert Richter
2017-05-08 11:03             ` Geetha Akula
2017-05-08 11:03               ` Geetha Akula
2017-05-05 12:08   ` [PATCH v3 3/7] ACPICA: IORT: Add Cavium ThunderX2 SMMUv3 model definition Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
     [not found]     ` <1493986091-30521-4-git-send-email-gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2017-05-05 13:53       ` Hanjun Guo
2017-05-05 13:53         ` Hanjun Guo
2017-05-05 13:53         ` Hanjun Guo
2017-05-05 14:56         ` David Daney
2017-05-05 14:56           ` David Daney
2017-05-05 14:58           ` Will Deacon
2017-05-05 14:58             ` Will Deacon
     [not found]             ` <20170505145800.GG14111-5wv7dgnIgG8@public.gmane.org>
2017-05-05 15:33               ` Jon Masters
2017-05-05 15:33                 ` Jon Masters
2017-05-05 15:33                 ` Jon Masters
2017-05-05 12:08   ` [PATCH v3 4/7] iommu/arm-smmu-v3: For ACPI based device probing, set PAGE0_REGS_ONLY option for ThunderX2 SMMUv3 implementation Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08   ` [PATCH v3 5/7] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 22:19     ` Robert Richter
2017-05-05 22:19       ` Robert Richter
2017-05-05 12:08   ` [PATCH v3 6/7] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
     [not found]     ` <1493986091-30521-7-git-send-email-gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2017-05-08 11:21       ` Robin Murphy
2017-05-08 11:21         ` Robin Murphy
2017-05-08 11:21         ` Robin Murphy
     [not found]         ` <a2618ab6-6609-7885-3b62-c1c1f170c318-5wv7dgnIgG8@public.gmane.org>
2017-05-08 12:02           ` Geetha Akula
2017-05-08 12:02             ` Geetha Akula
2017-05-08 12:02             ` Geetha Akula
2017-05-05 12:08   ` [PATCH v3 7/7] arm64: Documentation: Add Cavium ThunderX2 SMMUv3 erratas Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 12:08     ` Geetha sowjanya
2017-05-05 22:22 ` [PATCH v3 0/7] Cavium ThunderX2 SMMUv3 errata workarounds Robert Richter
2017-05-05 22:22   ` Robert Richter
2017-05-08 15:15   ` Linu Cherian
2017-05-08 15:15     ` Linu Cherian
2017-05-09 16:07     ` Robert Richter
2017-05-09 16:07       ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170508100443.GG16981@rric.localdomain \
    --to=robert.richter-ygcgfspz5w/qt0dzr+alfa@public.gmane.org \
    --cc=Charles.Garcia-Tobin-5wv7dgnIgG8@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
    --cc=geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=geethasowjanya.akula-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linu.cherian-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=rric-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sgoutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.