* [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
@ 2017-07-19 12:51 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-07-19 12:51 UTC (permalink / raw)
To: Michal Januszewski, Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
It's better to be explicit and use the DRIVER_ATTR_RW() macro when
defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
warning.
This is part of a series to drop DRIVER_ATTR() from the tree entirely.
Cc: Michal Januszewski <spock@gentoo.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/video/fbdev/uvesafb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1860,19 +1860,18 @@ static int uvesafb_setup(char *options)
}
#endif /* !MODULE */
-static ssize_t show_v86d(struct device_driver *dev, char *buf)
+static ssize_t v86d_show(struct device_driver *dev, char *buf)
{
return snprintf(buf, PAGE_SIZE, "%s\n", v86d_path);
}
-static ssize_t store_v86d(struct device_driver *dev, const char *buf,
+static ssize_t v86d_store(struct device_driver *dev, const char *buf,
size_t count)
{
strncpy(v86d_path, buf, PATH_MAX);
return count;
}
-
-static DRIVER_ATTR(v86d, S_IRUGO | S_IWUSR, show_v86d, store_v86d);
+static DRIVER_ATTR_RW(v86d);
static int uvesafb_init(void)
{
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
@ 2017-07-19 12:51 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-07-19 12:51 UTC (permalink / raw)
To: Michal Januszewski, Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
It's better to be explicit and use the DRIVER_ATTR_RW() macro when
defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
warning.
This is part of a series to drop DRIVER_ATTR() from the tree entirely.
Cc: Michal Januszewski <spock@gentoo.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/video/fbdev/uvesafb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1860,19 +1860,18 @@ static int uvesafb_setup(char *options)
}
#endif /* !MODULE */
-static ssize_t show_v86d(struct device_driver *dev, char *buf)
+static ssize_t v86d_show(struct device_driver *dev, char *buf)
{
return snprintf(buf, PAGE_SIZE, "%s\n", v86d_path);
}
-static ssize_t store_v86d(struct device_driver *dev, const char *buf,
+static ssize_t v86d_store(struct device_driver *dev, const char *buf,
size_t count)
{
strncpy(v86d_path, buf, PATH_MAX);
return count;
}
-
-static DRIVER_ATTR(v86d, S_IRUGO | S_IWUSR, show_v86d, store_v86d);
+static DRIVER_ATTR_RW(v86d);
static int uvesafb_init(void)
{
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
2017-07-19 12:51 ` Greg KH
@ 2017-08-01 13:36 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:36 UTC (permalink / raw)
To: Greg KH; +Cc: Michal Januszewski, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> It's better to be explicit and use the DRIVER_ATTR_RW() macro when
> defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
> warning.
>
> This is part of a series to drop DRIVER_ATTR() from the tree entirely.
>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
I assume that this will go through your tree with other DRIVER_ATTR()
removal patches (please ping me if you want me to merge this patch
through fbdev tree).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
@ 2017-08-01 13:36 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:36 UTC (permalink / raw)
To: Greg KH; +Cc: Michal Januszewski, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> It's better to be explicit and use the DRIVER_ATTR_RW() macro when
> defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
> warning.
>
> This is part of a series to drop DRIVER_ATTR() from the tree entirely.
>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
I assume that this will go through your tree with other DRIVER_ATTR()
removal patches (please ping me if you want me to merge this patch
through fbdev tree).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
2017-08-01 13:36 ` Bartlomiej Zolnierkiewicz
@ 2017-08-28 14:41 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-08-28 14:41 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Michal Januszewski, linux-fbdev, linux-kernel
On Tue, Aug 01, 2017 at 03:36:01PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > It's better to be explicit and use the DRIVER_ATTR_RW() macro when
> > defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
> > warning.
> >
> > This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> >
> > Cc: Michal Januszewski <spock@gentoo.org>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> I assume that this will go through your tree with other DRIVER_ATTR()
> removal patches (please ping me if you want me to merge this patch
> through fbdev tree).
I'll take it through mine, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage
@ 2017-08-28 14:41 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-08-28 14:41 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Michal Januszewski, linux-fbdev, linux-kernel
On Tue, Aug 01, 2017 at 03:36:01PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > It's better to be explicit and use the DRIVER_ATTR_RW() macro when
> > defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl
> > warning.
> >
> > This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> >
> > Cc: Michal Januszewski <spock@gentoo.org>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> I assume that this will go through your tree with other DRIVER_ATTR()
> removal patches (please ping me if you want me to merge this patch
> through fbdev tree).
I'll take it through mine, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-28 14:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170719125131epcas5p4fed9dd550f3b19744e793831a9a2b1db@epcas5p4.samsung.com>
2017-07-19 12:51 ` [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage Greg KH
2017-07-19 12:51 ` Greg KH
2017-08-01 13:36 ` Bartlomiej Zolnierkiewicz
2017-08-01 13:36 ` Bartlomiej Zolnierkiewicz
2017-08-28 14:41 ` Greg KH
2017-08-28 14:41 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.