From: Borislav Petkov <bp@suse.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type
Date: Wed, 14 Feb 2018 20:35:47 +0100 [thread overview]
Message-ID: <20180214193547.GB19502@pd.tnic> (raw)
In-Reply-To: <DM5PR12MB1916E752AF9164228359BC9EF8F50@DM5PR12MB1916.namprd12.prod.outlook.com>
On Wed, Feb 14, 2018 at 04:38:34PM +0000, Ghannam, Yazen wrote:
> I know that we're declaring smca_banks[] to have MAX_NR_BANKS items. But
> shouldn't we directly check that an index is within the bounds of the array?
> We'll have a bug if we check against MAX_NR_BANKS and the definition of
> smca_banks[] changes.
Then we don't need MAX_NR_BANKS. We either keep them in sync or kill it.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
WARNING: multiple messages have this Message-ID (diff)
From: Boris Petkov <bp@suse.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: [1/3] x86/MCE/AMD: Redo function to get SMCA bank type
Date: Wed, 14 Feb 2018 20:35:47 +0100 [thread overview]
Message-ID: <20180214193547.GB19502@pd.tnic> (raw)
On Wed, Feb 14, 2018 at 04:38:34PM +0000, Ghannam, Yazen wrote:
> I know that we're declaring smca_banks[] to have MAX_NR_BANKS items. But
> shouldn't we directly check that an index is within the bounds of the array?
> We'll have a bug if we check against MAX_NR_BANKS and the definition of
> smca_banks[] changes.
Then we don't need MAX_NR_BANKS. We either keep them in sync or kill it.
next prev parent reply other threads:[~2018-02-14 19:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:48 [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Yazen Ghannam
2018-02-01 18:48 ` [1/3] " Yazen Ghannam
2018-02-01 18:48 ` [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved " Yazen Ghannam
2018-02-01 18:48 ` [2/3] " Yazen Ghannam
2018-02-08 15:15 ` [PATCH 2/3] " Borislav Petkov
2018-02-08 15:15 ` [2/3] " Borislav Petkov
2018-02-14 16:28 ` [PATCH 2/3] " Ghannam, Yazen
2018-02-14 16:28 ` [2/3] " Yazen Ghannam
2018-02-01 18:48 ` [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Yazen Ghannam
2018-02-01 18:48 ` [3/3] " Yazen Ghannam
2018-02-08 15:26 ` [PATCH 3/3] " Borislav Petkov
2018-02-08 15:26 ` [3/3] " Borislav Petkov
2018-04-14 0:42 ` [PATCH 3/3] " Johannes Hirte
2018-04-14 0:42 ` [3/3] " Johannes Hirte
2018-04-16 11:56 ` [PATCH 3/3] " Johannes Hirte
2018-04-16 11:56 ` [3/3] " Johannes Hirte
2018-04-17 13:31 ` [PATCH 3/3] " Ghannam, Yazen
2018-04-17 13:31 ` [3/3] " Yazen Ghannam
2018-05-15 9:39 ` [PATCH 3/3] " Johannes Hirte
2018-05-15 9:39 ` [3/3] " Johannes Hirte
2018-05-16 22:46 ` [PATCH 3/3] " Borislav Petkov
2018-05-16 22:46 ` [3/3] " Boris Petkov
2018-05-17 6:49 ` [PATCH 3/3] " Johannes Hirte
2018-05-17 6:49 ` [3/3] " Johannes Hirte
2018-05-17 10:41 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 10:41 ` [3/3] " Boris Petkov
2018-05-17 13:04 ` [PATCH 3/3] " Ghannam, Yazen
2018-05-17 13:04 ` [3/3] " Yazen Ghannam
2018-05-17 13:44 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 13:44 ` [3/3] " Boris Petkov
2018-05-17 14:05 ` [PATCH 3/3] " Ghannam, Yazen
2018-05-17 14:05 ` [3/3] " Yazen Ghannam
2018-05-17 18:30 ` [PATCH 1/2] x86/MCE/AMD: Cache SMCA MISC block addresses Borislav Petkov
2018-05-17 18:30 ` [1/2] " Boris Petkov
2018-05-17 18:31 ` [PATCH 2/2] x86/MCE/AMD: Read MCx_MISC block addresses on any CPU Borislav Petkov
2018-05-17 18:31 ` [2/2] " Boris Petkov
2018-05-17 19:29 ` [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Johannes Hirte
2018-05-17 19:29 ` [3/3] " Johannes Hirte
2018-05-17 19:33 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 19:33 ` [3/3] " Boris Petkov
2018-05-19 13:21 ` [tip:ras/urgent] x86/MCE/AMD: Cache SMCA MISC block addresses tip-bot for Borislav Petkov
2018-02-08 15:04 ` [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Borislav Petkov
2018-02-08 15:04 ` [1/3] " Borislav Petkov
2018-02-14 16:38 ` [PATCH 1/3] " Ghannam, Yazen
2018-02-14 16:38 ` [1/3] " Yazen Ghannam
2018-02-14 19:35 ` Borislav Petkov [this message]
2018-02-14 19:35 ` Boris Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214193547.GB19502@pd.tnic \
--to=bp@suse.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.