From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Borislav Petkov <bp@suse.de>
Cc: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block
Date: Thu, 17 May 2018 21:29:23 +0200 [thread overview]
Message-ID: <20180517192922.GA11686@probook> (raw)
In-Reply-To: <20180517104124.GA25595@pd.tnic>
On 2018 Mai 17, Borislav Petkov wrote:
> On Thu, May 17, 2018 at 08:49:31AM +0200, Johannes Hirte wrote:
> > Maybe I'm missing something, but those RDMSR IPSs don't happen on
> > pre-SMCA systems, right? So the caching should be avoided here, cause
> > the whole lookup looks more expensive to me than the simple switch-block
> > in get_block_address.
>
> Yeah, and we should simply cache all those MSR values as I suggested then.
>
> The patch at the end should fix your issue.
>
Works as expected on my Carrizo.
--
Regards,
Johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Borislav Petkov <bp@suse.de>
Cc: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: [3/3] x86/MCE/AMD: Get address from already initialized block
Date: Thu, 17 May 2018 21:29:23 +0200 [thread overview]
Message-ID: <20180517192922.GA11686@probook> (raw)
On 2018 Mai 17, Borislav Petkov wrote:
> On Thu, May 17, 2018 at 08:49:31AM +0200, Johannes Hirte wrote:
> > Maybe I'm missing something, but those RDMSR IPSs don't happen on
> > pre-SMCA systems, right? So the caching should be avoided here, cause
> > the whole lookup looks more expensive to me than the simple switch-block
> > in get_block_address.
>
> Yeah, and we should simply cache all those MSR values as I suggested then.
>
> The patch at the end should fix your issue.
>
Works as expected on my Carrizo.
next prev parent reply other threads:[~2018-05-17 19:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:48 [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Yazen Ghannam
2018-02-01 18:48 ` [1/3] " Yazen Ghannam
2018-02-01 18:48 ` [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved " Yazen Ghannam
2018-02-01 18:48 ` [2/3] " Yazen Ghannam
2018-02-08 15:15 ` [PATCH 2/3] " Borislav Petkov
2018-02-08 15:15 ` [2/3] " Borislav Petkov
2018-02-14 16:28 ` [PATCH 2/3] " Ghannam, Yazen
2018-02-14 16:28 ` [2/3] " Yazen Ghannam
2018-02-01 18:48 ` [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Yazen Ghannam
2018-02-01 18:48 ` [3/3] " Yazen Ghannam
2018-02-08 15:26 ` [PATCH 3/3] " Borislav Petkov
2018-02-08 15:26 ` [3/3] " Borislav Petkov
2018-04-14 0:42 ` [PATCH 3/3] " Johannes Hirte
2018-04-14 0:42 ` [3/3] " Johannes Hirte
2018-04-16 11:56 ` [PATCH 3/3] " Johannes Hirte
2018-04-16 11:56 ` [3/3] " Johannes Hirte
2018-04-17 13:31 ` [PATCH 3/3] " Ghannam, Yazen
2018-04-17 13:31 ` [3/3] " Yazen Ghannam
2018-05-15 9:39 ` [PATCH 3/3] " Johannes Hirte
2018-05-15 9:39 ` [3/3] " Johannes Hirte
2018-05-16 22:46 ` [PATCH 3/3] " Borislav Petkov
2018-05-16 22:46 ` [3/3] " Boris Petkov
2018-05-17 6:49 ` [PATCH 3/3] " Johannes Hirte
2018-05-17 6:49 ` [3/3] " Johannes Hirte
2018-05-17 10:41 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 10:41 ` [3/3] " Boris Petkov
2018-05-17 13:04 ` [PATCH 3/3] " Ghannam, Yazen
2018-05-17 13:04 ` [3/3] " Yazen Ghannam
2018-05-17 13:44 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 13:44 ` [3/3] " Boris Petkov
2018-05-17 14:05 ` [PATCH 3/3] " Ghannam, Yazen
2018-05-17 14:05 ` [3/3] " Yazen Ghannam
2018-05-17 18:30 ` [PATCH 1/2] x86/MCE/AMD: Cache SMCA MISC block addresses Borislav Petkov
2018-05-17 18:30 ` [1/2] " Boris Petkov
2018-05-17 18:31 ` [PATCH 2/2] x86/MCE/AMD: Read MCx_MISC block addresses on any CPU Borislav Petkov
2018-05-17 18:31 ` [2/2] " Boris Petkov
2018-05-17 19:29 ` Johannes Hirte [this message]
2018-05-17 19:29 ` [3/3] x86/MCE/AMD: Get address from already initialized block Johannes Hirte
2018-05-17 19:33 ` [PATCH 3/3] " Borislav Petkov
2018-05-17 19:33 ` [3/3] " Boris Petkov
2018-05-19 13:21 ` [tip:ras/urgent] x86/MCE/AMD: Cache SMCA MISC block addresses tip-bot for Borislav Petkov
2018-02-08 15:04 ` [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Borislav Petkov
2018-02-08 15:04 ` [1/3] " Borislav Petkov
2018-02-14 16:38 ` [PATCH 1/3] " Ghannam, Yazen
2018-02-14 16:38 ` [1/3] " Yazen Ghannam
2018-02-14 19:35 ` [PATCH 1/3] " Borislav Petkov
2018-02-14 19:35 ` [1/3] " Boris Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517192922.GA11686@probook \
--to=johannes.hirte@datenkhaos.de \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.