All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch
Date: Thu, 12 Jul 2018 11:59:55 +0100	[thread overview]
Message-ID: <20180712105958.12953-7-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180712105958.12953-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Skip accounting the context save time for anything but the last request of
the coalesced bunch, and also skip drawing those boxes on the timeline.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/trace.pl | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index bd3039511f5d..9bdafa2d7e99 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -607,7 +607,11 @@ foreach my $key (@sorted_keys) {
 	$min_ctx = $db{$key}->{'ctx'} if not defined $min_ctx or
 					 $db{$key}->{'ctx'} < $min_ctx;
 
-	$db{$key}->{'context-complete-delay'} = $end - $notify;
+	unless (exists $db{$key}->{'no-end'}) {
+		$db{$key}->{'context-complete-delay'} = $end - $notify;
+	} else {
+		$db{$key}->{'context-complete-delay'} = 0;
+	}
 	$db{$key}->{'execute-delay'} = $start - $db{$key}->{'submit'};
 	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
 	$db{$key}->{'duration'} = $notify - $start;
@@ -624,7 +628,7 @@ foreach my $key (@sorted_keys) {
 
 	$submit_avg{$ring} += $db{$key}->{'submit-delay'};
 	$execute_avg{$ring} += $db{$key}->{'execute-delay'};
-	$ctxsave_avg{$ring} += $end - $notify;
+	$ctxsave_avg{$ring} += $db{$key}->{'context-complete-delay'};
 }
 
 foreach my $ring (sort keys %batch_avg) {
@@ -1062,7 +1066,7 @@ foreach my $key (sort sortQueue keys %db) {
 	}
 
 	# user interrupt to context complete
-	unless (exists $skip_box{'ctxsave'}) {
+	unless (exists $skip_box{'ctxsave'} or exists $db{$key}->{'no-end'}) {
 		$skey = -2 * $max_seqno * $ctx - 2 * $seqno;
 		$style = box_style($ctx, 'ctxsave');
 		my $ctxsave = $db{$key}->{'end'} - $db{$key}->{'notify'};
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch
Date: Thu, 12 Jul 2018 11:59:55 +0100	[thread overview]
Message-ID: <20180712105958.12953-7-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180712105958.12953-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Skip accounting the context save time for anything but the last request of
the coalesced bunch, and also skip drawing those boxes on the timeline.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/trace.pl | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index bd3039511f5d..9bdafa2d7e99 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -607,7 +607,11 @@ foreach my $key (@sorted_keys) {
 	$min_ctx = $db{$key}->{'ctx'} if not defined $min_ctx or
 					 $db{$key}->{'ctx'} < $min_ctx;
 
-	$db{$key}->{'context-complete-delay'} = $end - $notify;
+	unless (exists $db{$key}->{'no-end'}) {
+		$db{$key}->{'context-complete-delay'} = $end - $notify;
+	} else {
+		$db{$key}->{'context-complete-delay'} = 0;
+	}
 	$db{$key}->{'execute-delay'} = $start - $db{$key}->{'submit'};
 	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
 	$db{$key}->{'duration'} = $notify - $start;
@@ -624,7 +628,7 @@ foreach my $key (@sorted_keys) {
 
 	$submit_avg{$ring} += $db{$key}->{'submit-delay'};
 	$execute_avg{$ring} += $db{$key}->{'execute-delay'};
-	$ctxsave_avg{$ring} += $end - $notify;
+	$ctxsave_avg{$ring} += $db{$key}->{'context-complete-delay'};
 }
 
 foreach my $ring (sort keys %batch_avg) {
@@ -1062,7 +1066,7 @@ foreach my $key (sort sortQueue keys %db) {
 	}
 
 	# user interrupt to context complete
-	unless (exists $skip_box{'ctxsave'}) {
+	unless (exists $skip_box{'ctxsave'} or exists $db{$key}->{'no-end'}) {
 		$skey = -2 * $max_seqno * $ctx - 2 * $seqno;
 		$style = box_style($ctx, 'ctxsave');
 		my $ctxsave = $db{$key}->{'end'} - $db{$key}->{'notify'};
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-07-12 11:00 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 10:59 [PATCH i-g-t 0/9] trace.pl fixes and improvements Tvrtko Ursulin
2018-07-12 10:59 ` [igt-dev] " Tvrtko Ursulin
2018-07-12 10:59 ` [PATCH i-g-t 1/9] trace.pl: Improve time axis labels Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 12:42   ` Tvrtko Ursulin
2018-07-12 12:42     ` Tvrtko Ursulin
2018-07-12 22:35     ` John Harrison
2018-07-12 22:35       ` John Harrison
2018-07-13  9:55       ` [PATCH i-g-t v2 " Tvrtko Ursulin
2018-07-13  9:55         ` [igt-dev] " Tvrtko Ursulin
2018-07-16 17:53         ` John Harrison
2018-07-16 17:53           ` [Intel-gfx] " John Harrison
2018-07-17  8:56           ` [igt-dev] " Tvrtko Ursulin
2018-07-17  8:56             ` [Intel-gfx] " Tvrtko Ursulin
2018-07-17 15:11             ` John Harrison
2018-07-17 15:11               ` John Harrison
2018-07-17 15:31               ` John Harrison
2018-07-17 15:31                 ` John Harrison
2018-07-17 16:22                 ` Tvrtko Ursulin
2018-07-17 16:22                   ` Tvrtko Ursulin
2018-07-17 17:57                   ` John Harrison
2018-07-17 17:57                     ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 2/9] trace.pl: Scale timeline for better precision Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:21   ` John Harrison
2018-07-13  0:21     ` [igt-dev] " John Harrison
2018-07-13 10:02   ` [PATCH i-g-t v3 " Tvrtko Ursulin
2018-07-13 10:02     ` [igt-dev] " Tvrtko Ursulin
2018-07-16 18:15     ` John Harrison
2018-07-16 18:15       ` [igt-dev] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 3/9] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:51   ` John Harrison
2018-07-13  0:51     ` [Intel-gfx] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 4/9] trace.pl: Improve context colouring for large context id's Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:51   ` John Harrison
2018-07-13  0:51     ` [Intel-gfx] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 5/9] trace.pl: Improved key/colours Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 11:03   ` Tvrtko Ursulin
2018-07-12 11:03     ` Tvrtko Ursulin
2018-07-13  0:52   ` John Harrison
2018-07-13  0:52     ` [igt-dev] " John Harrison
2018-07-13  9:56     ` [PATCH i-g-t v3 " Tvrtko Ursulin
2018-07-13  9:56       ` [igt-dev] " Tvrtko Ursulin
2018-07-14  0:01       ` John Harrison
2018-07-14  0:01         ` [igt-dev] " John Harrison
2018-07-16  8:49         ` [PATCH i-g-t v4 " Tvrtko Ursulin
2018-07-16  8:49           ` [Intel-gfx] " Tvrtko Ursulin
2018-07-16 19:11           ` John Harrison
2018-07-16 19:11             ` [igt-dev] " John Harrison
2018-07-12 10:59 ` Tvrtko Ursulin [this message]
2018-07-12 10:59   ` [igt-dev] [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-07-13  6:55   ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  7:00   ` John Harrison
2018-07-13  7:00     ` [igt-dev] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 8/9] trace.pl: Basic preemption support Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:54   ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 9/9] trace.pl: Fix request split mode Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev3) Patchwork
2018-07-12 15:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-13 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev6) Patchwork
2018-07-13 13:59 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-07-16 10:03 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev7) Patchwork
2018-07-16 16:41 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-05-10 10:19 [PATCH i-g-t 1/9] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-05-10 10:19 ` [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712105958.12953-7-tvrtko.ursulin@linux.intel.com \
    --to=tursulin@ursulin.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.