All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Harrison <John.C.Harrison@Intel.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling
Date: Fri, 13 Jul 2018 00:00:08 -0700	[thread overview]
Message-ID: <9132d480-72bc-1504-de87-54c6cc526da8@Intel.com> (raw)
In-Reply-To: <20180712105958.12953-8-tvrtko.ursulin@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]

On 7/12/2018 3:59 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Incomplete requests (no notify, no context complete) have to be corrected
> by looking at the engine timeline, and not the sorted-by-start-time view
> as was previously used.
>
> Per-engine timelines are generated on demand and cached for later use.
>
> v2: Find end of current context on the engine timeline instead of just
>      using the next request for adjusting the incomplete start time.
>
> v3: Improve scaling with large datasets by only walking each engine
>      timeline once and some caching. (John Harrison)
>
> v4:
>   * Fix logic fail from v3.
>   * Refactor the code a bit to separate the stages better.
>   * Do not account batches with unknown duration in avg stats.
>   * Handle two user interrupts with the same seqno.
>   * Handle user interrupt arriving after request_out.
>
> v5:
>   * Update for class:instance.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: John Harrison <John.C.Harrison@intel.com>
> ---
>

Reviewed-by: John Harrison<John.C.Harrison@Intel.com>



[-- Attachment #1.2: Type: text/html, Size: 1727 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: John Harrison <John.C.Harrison@Intel.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling
Date: Fri, 13 Jul 2018 00:00:08 -0700	[thread overview]
Message-ID: <9132d480-72bc-1504-de87-54c6cc526da8@Intel.com> (raw)
In-Reply-To: <20180712105958.12953-8-tvrtko.ursulin@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]

On 7/12/2018 3:59 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Incomplete requests (no notify, no context complete) have to be corrected
> by looking at the engine timeline, and not the sorted-by-start-time view
> as was previously used.
>
> Per-engine timelines are generated on demand and cached for later use.
>
> v2: Find end of current context on the engine timeline instead of just
>      using the next request for adjusting the incomplete start time.
>
> v3: Improve scaling with large datasets by only walking each engine
>      timeline once and some caching. (John Harrison)
>
> v4:
>   * Fix logic fail from v3.
>   * Refactor the code a bit to separate the stages better.
>   * Do not account batches with unknown duration in avg stats.
>   * Handle two user interrupts with the same seqno.
>   * Handle user interrupt arriving after request_out.
>
> v5:
>   * Update for class:instance.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: John Harrison <John.C.Harrison@intel.com>
> ---
>

Reviewed-by: John Harrison<John.C.Harrison@Intel.com>



[-- Attachment #1.2: Type: text/html, Size: 1727 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-07-13  7:00 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 10:59 [PATCH i-g-t 0/9] trace.pl fixes and improvements Tvrtko Ursulin
2018-07-12 10:59 ` [igt-dev] " Tvrtko Ursulin
2018-07-12 10:59 ` [PATCH i-g-t 1/9] trace.pl: Improve time axis labels Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 12:42   ` Tvrtko Ursulin
2018-07-12 12:42     ` Tvrtko Ursulin
2018-07-12 22:35     ` John Harrison
2018-07-12 22:35       ` John Harrison
2018-07-13  9:55       ` [PATCH i-g-t v2 " Tvrtko Ursulin
2018-07-13  9:55         ` [igt-dev] " Tvrtko Ursulin
2018-07-16 17:53         ` John Harrison
2018-07-16 17:53           ` [Intel-gfx] " John Harrison
2018-07-17  8:56           ` [igt-dev] " Tvrtko Ursulin
2018-07-17  8:56             ` [Intel-gfx] " Tvrtko Ursulin
2018-07-17 15:11             ` John Harrison
2018-07-17 15:11               ` John Harrison
2018-07-17 15:31               ` John Harrison
2018-07-17 15:31                 ` John Harrison
2018-07-17 16:22                 ` Tvrtko Ursulin
2018-07-17 16:22                   ` Tvrtko Ursulin
2018-07-17 17:57                   ` John Harrison
2018-07-17 17:57                     ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 2/9] trace.pl: Scale timeline for better precision Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:21   ` John Harrison
2018-07-13  0:21     ` [igt-dev] " John Harrison
2018-07-13 10:02   ` [PATCH i-g-t v3 " Tvrtko Ursulin
2018-07-13 10:02     ` [igt-dev] " Tvrtko Ursulin
2018-07-16 18:15     ` John Harrison
2018-07-16 18:15       ` [igt-dev] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 3/9] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:51   ` John Harrison
2018-07-13  0:51     ` [Intel-gfx] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 4/9] trace.pl: Improve context colouring for large context id's Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:51   ` John Harrison
2018-07-13  0:51     ` [Intel-gfx] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 5/9] trace.pl: Improved key/colours Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 11:03   ` Tvrtko Ursulin
2018-07-12 11:03     ` Tvrtko Ursulin
2018-07-13  0:52   ` John Harrison
2018-07-13  0:52     ` [igt-dev] " John Harrison
2018-07-13  9:56     ` [PATCH i-g-t v3 " Tvrtko Ursulin
2018-07-13  9:56       ` [igt-dev] " Tvrtko Ursulin
2018-07-14  0:01       ` John Harrison
2018-07-14  0:01         ` [igt-dev] " John Harrison
2018-07-16  8:49         ` [PATCH i-g-t v4 " Tvrtko Ursulin
2018-07-16  8:49           ` [Intel-gfx] " Tvrtko Ursulin
2018-07-16 19:11           ` John Harrison
2018-07-16 19:11             ` [igt-dev] " John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  6:55   ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  7:00   ` John Harrison [this message]
2018-07-13  7:00     ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 8/9] trace.pl: Basic preemption support Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-13  0:54   ` John Harrison
2018-07-12 10:59 ` [PATCH i-g-t 9/9] trace.pl: Fix request split mode Tvrtko Ursulin
2018-07-12 10:59   ` [igt-dev] " Tvrtko Ursulin
2018-07-12 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev3) Patchwork
2018-07-12 15:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-13 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev6) Patchwork
2018-07-13 13:59 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-07-16 10:03 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes and improvements (rev7) Patchwork
2018-07-16 16:41 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-05-10 10:19 [PATCH i-g-t 1/9] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-05-10 10:19 ` [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9132d480-72bc-1504-de87-54c6cc526da8@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.