All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: balbi@kernel.org, hminas@synopsys.com, gregkh@linuxfoundation.org
Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com,
	Bruno Herrera <bruherrera@gmail.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	john.stultz@linaro.org, Stephen Warren <swarren@wwwdotorg.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
Date: Thu, 26 Jul 2018 13:07:29 -0700	[thread overview]
Message-ID: <20180726200730.18290-4-dianders@chromium.org> (raw)
In-Reply-To: <20180726200730.18290-1-dianders@chromium.org>

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Amlogic since commit f94310ac076e
("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
after most of the recent improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
the parameters were copied from another platform and the uframe
scheduler wasn't tried.

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index db97bb16ecc4..93380f7c32b4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
-- 
2.18.0.345.g5c9ce644c3-goog


WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: balbi@kernel.org, hminas@synopsys.com, gregkh@linuxfoundation.org
Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com,
	Bruno Herrera <bruherrera@gmail.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	john.stultz@linaro.org, Stephen Warren <swarren@wwwdotorg.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [REPOST,3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
Date: Thu, 26 Jul 2018 13:07:29 -0700	[thread overview]
Message-ID: <20180726200730.18290-4-dianders@chromium.org> (raw)

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Amlogic since commit f94310ac076e
("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
after most of the recent improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
the parameters were copied from another platform and the uframe
scheduler wasn't tried.

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index db97bb16ecc4..93380f7c32b4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)

  parent reply	other threads:[~2018-07-26 20:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 20:07 [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
2018-07-26 20:07 ` [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,1/4] " Doug Anderson
2018-07-27 11:09   ` [REPOST PATCH 1/4] " Minas Harutyunyan
2018-07-27 11:09     ` [REPOST,1/4] " Minas Harutyunyan
2018-07-26 20:07 ` [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,2/4] " Doug Anderson
2018-07-27 11:00   ` [REPOST PATCH 2/4] " Minas Harutyunyan
2018-07-27 11:00     ` [REPOST,2/4] " Minas Harutyunyan
2018-07-26 20:07 ` Douglas Anderson [this message]
2018-07-26 20:07   ` [REPOST,3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Doug Anderson
2018-07-27 11:11   ` [REPOST PATCH 3/4] " Minas Harutyunyan
2018-07-27 11:11     ` [REPOST,3/4] " Minas Harutyunyan
2018-07-26 20:07 ` [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,4/4] " Doug Anderson
2018-07-27 11:11   ` [REPOST PATCH 4/4] " Minas Harutyunyan
2018-07-27 11:11     ` [REPOST,4/4] " Minas Harutyunyan
2018-07-27 10:01 ` [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Felipe Balbi
2018-07-27 11:00 ` Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726200730.18290-4-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=balbi@kernel.org \
    --cc=bruherrera@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grigor.tovmasyan@synopsys.com \
    --cc=hminas@synopsys.com \
    --cc=jbrunet@baylibre.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=swarren@wwwdotorg.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.