From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> To: Douglas Anderson <dianders@chromium.org>, "balbi@kernel.org" <balbi@kernel.org>, "Minas.Harutyunyan@synopsys.com" <Minas.Harutyunyan@synopsys.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> Cc: "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>, "grigor.tovmasyan@synopsys.com" <grigor.tovmasyan@synopsys.com>, "Bruno Herrera" <bruherrera@gmail.com>, Zhangfei Gao <zhangfei.gao@linaro.org>, "john.stultz@linaro.org" <john.stultz@linaro.org>, Stephen Warren <swarren@wwwdotorg.org>, Jerome Brunet <jbrunet@baylibre.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Date: Fri, 27 Jul 2018 11:09:39 +0000 [thread overview] Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE23@am04wembxa.internal.synopsys.com> (raw) In-Reply-To: 20180726200730.18290-2-dianders@chromium.org On 7/27/2018 12:08 AM, Douglas Anderson wrote: > There's no reason to have the uframe scheduler off on dwc2. Running > with uframe_sched = False is equivalent to saying "I don't want to run > the correct code, I want to run the old and incorrect code". > > The uframe scheduler has been off on Broadcom since commit > 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835"). > Since then there have been many many improvements, notably the commit > 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe > scheduler") > > Presumably if everyone is good w/ the uframe_sched turned back on we > can kill all the old and crufty non-uframe sched code. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Acked-by: Minas Harutyunyan <hminas@synopsys.com> > --- > > drivers/usb/dwc2/params.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index af075d4da895..14b8742e62fa 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg) > p->max_transfer_size = 65535; > p->max_packet_count = 511; > p->ahbcfg = 0x10; > - p->uframe_sched = false; > } > > static void dwc2_set_his_params(struct dwc2_hsotg *hsotg) >
WARNING: multiple messages have this Message-ID (diff)
From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> To: Douglas Anderson <dianders@chromium.org>, "balbi@kernel.org" <balbi@kernel.org>, "Minas.Harutyunyan@synopsys.com" <Minas.Harutyunyan@synopsys.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> Cc: "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>, "grigor.tovmasyan@synopsys.com" <grigor.tovmasyan@synopsys.com>, Bruno Herrera <bruherrera@gmail.com>, Zhangfei Gao <zhangfei.gao@linaro.org>, "john.stultz@linaro.org" <john.stultz@linaro.org>, Stephen Warren <swarren@wwwdotorg.org>, Jerome Brunet <jbrunet@baylibre.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Date: Fri, 27 Jul 2018 11:09:39 +0000 [thread overview] Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE23@am04wembxa.internal.synopsys.com> (raw) On 7/27/2018 12:08 AM, Douglas Anderson wrote: > There's no reason to have the uframe scheduler off on dwc2. Running > with uframe_sched = False is equivalent to saying "I don't want to run > the correct code, I want to run the old and incorrect code". > > The uframe scheduler has been off on Broadcom since commit > 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835"). > Since then there have been many many improvements, notably the commit > 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe > scheduler") > > Presumably if everyone is good w/ the uframe_sched turned back on we > can kill all the old and crufty non-uframe sched code. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Acked-by: Minas Harutyunyan <hminas@synopsys.com> > --- > > drivers/usb/dwc2/params.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index af075d4da895..14b8742e62fa 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg) > p->max_transfer_size = 65535; > p->max_packet_count = 511; > p->ahbcfg = 0x10; > - p->uframe_sched = false; > } > > static void dwc2_set_his_params(struct dwc2_hsotg *hsotg) > --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-27 11:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-26 20:07 [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson 2018-07-26 20:07 ` [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Douglas Anderson 2018-07-26 20:07 ` [REPOST,1/4] " Doug Anderson 2018-07-27 11:09 ` Minas Harutyunyan [this message] 2018-07-27 11:09 ` Minas Harutyunyan 2018-07-26 20:07 ` [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms Douglas Anderson 2018-07-26 20:07 ` [REPOST,2/4] " Doug Anderson 2018-07-27 11:00 ` [REPOST PATCH 2/4] " Minas Harutyunyan 2018-07-27 11:00 ` [REPOST,2/4] " Minas Harutyunyan 2018-07-26 20:07 ` [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Douglas Anderson 2018-07-26 20:07 ` [REPOST,3/4] " Doug Anderson 2018-07-27 11:11 ` [REPOST PATCH 3/4] " Minas Harutyunyan 2018-07-27 11:11 ` [REPOST,3/4] " Minas Harutyunyan 2018-07-26 20:07 ` [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Douglas Anderson 2018-07-26 20:07 ` [REPOST,4/4] " Doug Anderson 2018-07-27 11:11 ` [REPOST PATCH 4/4] " Minas Harutyunyan 2018-07-27 11:11 ` [REPOST,4/4] " Minas Harutyunyan 2018-07-27 10:01 ` [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Felipe Balbi 2018-07-27 11:00 ` Minas Harutyunyan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=410670D7E743164D87FA6160E7907A56013A5CBE23@am04wembxa.internal.synopsys.com \ --to=minas.harutyunyan@synopsys.com \ --cc=balbi@kernel.org \ --cc=bruherrera@gmail.com \ --cc=dianders@chromium.org \ --cc=gregkh@linuxfoundation.org \ --cc=grigor.tovmasyan@synopsys.com \ --cc=jbrunet@baylibre.com \ --cc=john.stultz@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=stefan.wahren@i2se.com \ --cc=swarren@wwwdotorg.org \ --cc=zhangfei.gao@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.