From: Abel Vesa <abel.vesa@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Steve Twiss <stwiss.opensource@diasemi.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
DEVICETREE <devicetree@vger.kernel.org>,
LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 08:42:41 +0000 [thread overview]
Message-ID: <20190321084240.fveqkhfrbtg7qr4q@fsr-ub1664-175> (raw)
In-Reply-To: <CAOMZO5By8=j7gZRAdf2-h-5ak-Qo34rqwDL4+HA_97cMXTAnEQ@mail.gmail.com>
On 19-03-20 14:04:42, Fabio Estevam wrote:
> Hi Steve,
>
> [Adding Andrew]
>
> On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss
> <stwiss.opensource@diasemi.com> wrote:
> >
> > Hi Fabio,
> >
> > On 20 March 2019 12:17, Fabio Estevam wrote:
> > > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
> > >
> > > Hi Steve,
> > >
> > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss
> > > <stwiss.opensource@diasemi.com> wrote:
> > > >
> > > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> > > > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were
> > >
> > > This patch declares it as 'rgmii-id', which contradicts the commit log.
> >
> > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> > 'rgmii' instead of 'rgmii-id'.
> >
> > Can that be read two ways?
> > I meant the phy-mode is currently qualified as 'rgmii' instead of what it
> > should be: 'rgmii-id'.
>
> Thanks for the clarification.
>
> >
> > [...]
> >
> > > > This patch fixes the network problems seen on the Freescale i.MX6Q/DL
> > >
> > > Please provide a Fixes tag. It would be good to know if this fix needs
> > > to be applied to older kernels.
> >
> > I didn't put a Fixes tag in because I find this patch fixes v5.1-rc1 (which I see as broken).
> > But the patch is not needed in v5.0 because I see that as working.
> > So didn't see the need for a Cc: stable.
>
> It seems we have other boards that need to be fixed and we can not
> have an old dtb with functional Ethernet with a new kernel.
>
> Does anyone know if this issue is AR8031 specific?
I can confirm the same fix is works on imx6sx too.
>
> Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Support Opensource <Support.Opensource@diasemi.com>,
DEVICETREE <devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Steve Twiss <stwiss.opensource@diasemi.com>,
dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 08:42:41 +0000 [thread overview]
Message-ID: <20190321084240.fveqkhfrbtg7qr4q@fsr-ub1664-175> (raw)
In-Reply-To: <CAOMZO5By8=j7gZRAdf2-h-5ak-Qo34rqwDL4+HA_97cMXTAnEQ@mail.gmail.com>
On 19-03-20 14:04:42, Fabio Estevam wrote:
> Hi Steve,
>
> [Adding Andrew]
>
> On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss
> <stwiss.opensource@diasemi.com> wrote:
> >
> > Hi Fabio,
> >
> > On 20 March 2019 12:17, Fabio Estevam wrote:
> > > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
> > >
> > > Hi Steve,
> > >
> > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss
> > > <stwiss.opensource@diasemi.com> wrote:
> > > >
> > > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> > > > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were
> > >
> > > This patch declares it as 'rgmii-id', which contradicts the commit log.
> >
> > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> > 'rgmii' instead of 'rgmii-id'.
> >
> > Can that be read two ways?
> > I meant the phy-mode is currently qualified as 'rgmii' instead of what it
> > should be: 'rgmii-id'.
>
> Thanks for the clarification.
>
> >
> > [...]
> >
> > > > This patch fixes the network problems seen on the Freescale i.MX6Q/DL
> > >
> > > Please provide a Fixes tag. It would be good to know if this fix needs
> > > to be applied to older kernels.
> >
> > I didn't put a Fixes tag in because I find this patch fixes v5.1-rc1 (which I see as broken).
> > But the patch is not needed in v5.0 because I see that as working.
> > So didn't see the need for a Cc: stable.
>
> It seems we have other boards that need to be fixed and we can not
> have an old dtb with functional Ethernet with a new kernel.
>
> Does anyone know if this issue is AR8031 specific?
I can confirm the same fix is works on imx6sx too.
>
> Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-21 8:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:03 [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss
2019-03-20 11:03 ` Steve Twiss
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 16:03 ` Steve Twiss
2019-03-20 16:03 ` Steve Twiss
2019-03-20 17:04 ` Fabio Estevam
2019-03-20 17:04 ` Fabio Estevam
2019-03-21 8:42 ` Abel Vesa [this message]
2019-03-21 8:42 ` Abel Vesa
2019-03-21 11:17 ` Fabio Estevam
2019-03-21 11:17 ` Fabio Estevam
2019-03-21 11:32 ` Steve Twiss
2019-03-21 11:32 ` Steve Twiss
2019-03-21 11:50 ` Andrew Lunn
2019-03-21 11:50 ` Andrew Lunn
2019-03-21 11:45 ` Andrew Lunn
2019-03-21 11:45 ` Andrew Lunn
2019-03-21 12:43 ` Lucas Stach
2019-03-21 12:43 ` Lucas Stach
2019-03-22 1:11 ` Shawn Guo
2019-03-22 1:11 ` Shawn Guo
2019-03-22 2:00 ` Fabio Estevam
2019-03-22 2:00 ` Fabio Estevam
2019-03-22 2:15 ` Shawn Guo
2019-03-22 2:15 ` Shawn Guo
2019-03-22 2:24 ` Fabio Estevam
2019-03-22 2:24 ` Fabio Estevam
2019-03-22 10:20 ` Michal Vokáč
2019-03-22 10:20 ` Michal Vokáč
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:50 ` Steve Twiss
2019-03-22 10:59 ` Andrew Lunn
2019-03-22 10:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321084240.fveqkhfrbtg7qr4q@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=Support.Opensource@diasemi.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.