All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Fabio Estevam <festevam@gmail.com>, Abel Vesa <abel.vesa@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	dl-linux-imx <linux-imx@nxp.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 12:50:25 +0100	[thread overview]
Message-ID: <20190321115025.GH2900@lunn.ch> (raw)
In-Reply-To: <VI1PR10MB2352D2C805B675A1C4CBDC6AFE420@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM>

> I bisected to the original breakage (for the NFS rootfs) back to this commit:
> commit 13d0ab6750b20957ac1466da4e44dc0af746ff28

I don't think that is the correct patch. Yes, it broke here, but that
was a different problem. 

I think the real commit is:
6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")

That commit contains a fix for broken behaviour in the PHY driver,
when then also causes broken DTs to fail.

	     Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	Abel Vesa <abel.vesa@nxp.com>, Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Thu, 21 Mar 2019 12:50:25 +0100	[thread overview]
Message-ID: <20190321115025.GH2900@lunn.ch> (raw)
In-Reply-To: <VI1PR10MB2352D2C805B675A1C4CBDC6AFE420@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM>

> I bisected to the original breakage (for the NFS rootfs) back to this commit:
> commit 13d0ab6750b20957ac1466da4e44dc0af746ff28

I don't think that is the correct patch. Yes, it broke here, but that
was a different problem. 

I think the real commit is:
6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")

That commit contains a fix for broken behaviour in the PHY driver,
when then also causes broken DTs to fail.

	     Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-21 11:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 11:03 [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss
2019-03-20 11:03 ` Steve Twiss
2019-03-20 12:16 ` Fabio Estevam
2019-03-20 12:16   ` Fabio Estevam
2019-03-20 16:03   ` Steve Twiss
2019-03-20 16:03     ` Steve Twiss
2019-03-20 17:04     ` Fabio Estevam
2019-03-20 17:04       ` Fabio Estevam
2019-03-21  8:42       ` Abel Vesa
2019-03-21  8:42         ` Abel Vesa
2019-03-21 11:17         ` Fabio Estevam
2019-03-21 11:17           ` Fabio Estevam
2019-03-21 11:32           ` Steve Twiss
2019-03-21 11:32             ` Steve Twiss
2019-03-21 11:50             ` Andrew Lunn [this message]
2019-03-21 11:50               ` Andrew Lunn
2019-03-21 11:45           ` Andrew Lunn
2019-03-21 11:45             ` Andrew Lunn
2019-03-21 12:43           ` Lucas Stach
2019-03-21 12:43             ` Lucas Stach
2019-03-22  1:11           ` Shawn Guo
2019-03-22  1:11             ` Shawn Guo
2019-03-22  2:00             ` Fabio Estevam
2019-03-22  2:00               ` Fabio Estevam
2019-03-22  2:15               ` Shawn Guo
2019-03-22  2:15                 ` Shawn Guo
2019-03-22  2:24                 ` Fabio Estevam
2019-03-22  2:24                   ` Fabio Estevam
2019-03-22 10:20                   ` Michal Vokáč
2019-03-22 10:20                     ` Michal Vokáč
2019-03-22 10:50                     ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:59                       ` Andrew Lunn
2019-03-22 10:59                         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321115025.GH2900@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Support.Opensource@diasemi.com \
    --cc=abel.vesa@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.