Re: [PATCH 1/5] pci: use pci_sbdf_t in pci_dev

From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Brian Woods <brian.woods@amd.com>
Subject: Re: [PATCH 1/5] pci: use pci_sbdf_t in pci_dev
Date: Mon, 13 May 2019 09:53:02 +0200	[thread overview]
Message-ID: <20190513075302.echqmnxfkhp524lp@Air-de-Roger> (raw)
In-Reply-To: <5CD90DE1020000780022DF5B@prv1-mh.provo.novell.com>

On Mon, May 13, 2019 at 12:25:37AM -0600, Jan Beulich wrote:
> >>> On 10.05.19 at 18:16, <andrew.cooper3@citrix.com> wrote:
> > On 10/05/2019 17:10, Roger Pau Monne wrote:
> >> --- a/xen/arch/x86/hvm/vmsi.c
> >> +++ b/xen/arch/x86/hvm/vmsi.c
> >> @@ -688,8 +688,8 @@ static int vpci_msi_update(const struct pci_dev *pdev, uint32_t data,
> >>          {
> >>              gdprintk(XENLOG_ERR,
> >>                       "%04x:%02x:%02x.%u: failed to bind PIRQ %u: %d\n",
> >> -                     pdev->seg, pdev->bus, PCI_SLOT(pdev->devfn),
> >> -                     PCI_FUNC(pdev->devfn), pirq + i, rc);
> >> +                     pdev->sbdf.seg, pdev->sbdf.bus, pdev->sbdf.dev,
> >> +                     pdev->sbdf.func, pirq + i, rc);
> > 
> > A pci_sbdf_t is 32 bits wide.  I do actually have a custom %p formatter
> > from a year or so ago, which simplifies code like this substantially.
> > 
> > Is there any interest in dusting off that patch and folding it into this
> > cleanup series?  ISTR it also came with several corrections to existing
> > SBDF rendering.
> 
> Afaic: Yes please! The one thing I'm not sure about is whether this
> should be PCI-specific, or whether it wouldn't better be a more
> general device thing. But I guess we use SBDF also independent of
> struct pci_dev.

See patch 4 which introduces a printf format specifier for pci_sbdf_t.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel