From: "Jan Beulich" <JBeulich@suse.com> To: Andrew Cooper <andrew.cooper3@citrix.com> Cc: Kevin Tian <kevin.tian@intel.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Julien Grall <julien.grall@arm.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, xen-devel <xen-devel@lists.xenproject.org>, Brian Woods <brian.woods@amd.com>, Roger Pau Monne <roger.pau@citrix.com> Subject: Re: [PATCH 4/5] print: introduce a format specifier for pci_sbdf_t Date: Fri, 24 May 2019 05:16:57 -0600 [thread overview] Message-ID: <5CE7D2A90200007800231F9A@prv1-mh.provo.novell.com> (raw) In-Reply-To: <5d339f33-a5e7-49be-ee40-5782401ceab1@citrix.com> >>> On 24.05.19 at 12:59, <andrew.cooper3@citrix.com> wrote: > On 24/05/2019 11:36, Jan Beulich wrote: >>>>> On 10.05.19 at 18:10, <roger.pau@citrix.com> wrote: >>> The new format specifier is '%pp', and prints a pci_sbdf_t using the >>> seg:bus:dev.func format. Replace all SBDFs printed using >>> '%04x:%02x:%02x.%u' to use the new format specifier. >> So on the positive side Linux doesn't use 'p' yet, so we're only at risk >> of a future conflict. However, having to pass a 64-bit pointer just >> to print a 32-bit entity seems rather wasteful to me. Since we can't >> use entirely new format specifiers, did you consider (ab)using one >> we rarely use, like %o, suffixed similarly like we do for %p? The >> extension could be restricted to apply only when neither field width >> nor precision nor any flags were specified, i.e. only to plain %o (at >> least initially). >> >> We'd then have something along the lines of >> >> #define PRI_sbdf "op" >> #define PRI_SBDF(v) ((v).sbdf) >> >> and >> >> printk("%" PRI_sbdf ": ...\n", PRI_SBDF(pdev->sbdf), ...); > > Except the answer will be the same as every time you've asked this in > the past. I don't recall suggesting any use of %o so far. The one thing I do recall suggesting (and which turned out bad) was using an l modifier with %pb. > No, because -Wformat doesn't tolerate it. How would -Wformat choke here? %o accepts (unsigned) integers, doesn't it? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com> To: "Andrew Cooper" <andrew.cooper3@citrix.com> Cc: Kevin Tian <kevin.tian@intel.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Julien Grall <julien.grall@arm.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, xen-devel <xen-devel@lists.xenproject.org>, Brian Woods <brian.woods@amd.com>, Roger Pau Monne <roger.pau@citrix.com> Subject: Re: [Xen-devel] [PATCH 4/5] print: introduce a format specifier for pci_sbdf_t Date: Fri, 24 May 2019 05:16:57 -0600 [thread overview] Message-ID: <5CE7D2A90200007800231F9A@prv1-mh.provo.novell.com> (raw) Message-ID: <20190524111657.joxJGiracviZjmT83K-aWvwE8y5kOECOxPWcS1nXJLg@z> (raw) In-Reply-To: <5d339f33-a5e7-49be-ee40-5782401ceab1@citrix.com> >>> On 24.05.19 at 12:59, <andrew.cooper3@citrix.com> wrote: > On 24/05/2019 11:36, Jan Beulich wrote: >>>>> On 10.05.19 at 18:10, <roger.pau@citrix.com> wrote: >>> The new format specifier is '%pp', and prints a pci_sbdf_t using the >>> seg:bus:dev.func format. Replace all SBDFs printed using >>> '%04x:%02x:%02x.%u' to use the new format specifier. >> So on the positive side Linux doesn't use 'p' yet, so we're only at risk >> of a future conflict. However, having to pass a 64-bit pointer just >> to print a 32-bit entity seems rather wasteful to me. Since we can't >> use entirely new format specifiers, did you consider (ab)using one >> we rarely use, like %o, suffixed similarly like we do for %p? The >> extension could be restricted to apply only when neither field width >> nor precision nor any flags were specified, i.e. only to plain %o (at >> least initially). >> >> We'd then have something along the lines of >> >> #define PRI_sbdf "op" >> #define PRI_SBDF(v) ((v).sbdf) >> >> and >> >> printk("%" PRI_sbdf ": ...\n", PRI_SBDF(pdev->sbdf), ...); > > Except the answer will be the same as every time you've asked this in > the past. I don't recall suggesting any use of %o so far. The one thing I do recall suggesting (and which turned out bad) was using an l modifier with %pb. > No, because -Wformat doesn't tolerate it. How would -Wformat choke here? %o accepts (unsigned) integers, doesn't it? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-24 11:17 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-10 16:10 [PATCH 0/5] pci: expand usage of pci_sbdf_t Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-10 16:10 ` [PATCH 1/5] pci: use pci_sbdf_t in pci_dev Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-10 16:16 ` Andrew Cooper 2019-05-10 16:16 ` [Xen-devel] " Andrew Cooper 2019-05-13 6:25 ` Jan Beulich 2019-05-13 6:25 ` [Xen-devel] " Jan Beulich 2019-05-13 7:53 ` Roger Pau Monné 2019-05-13 7:53 ` [Xen-devel] " Roger Pau Monné 2019-05-23 15:29 ` Jan Beulich 2019-05-23 15:29 ` [Xen-devel] " Jan Beulich 2019-05-27 15:51 ` Roger Pau Monné 2019-05-27 15:51 ` [Xen-devel] " Roger Pau Monné 2019-05-10 16:10 ` [PATCH 2/5] pci: use function generation macros for pci_config_{write, read}<size> Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-24 9:10 ` Jan Beulich 2019-05-24 9:10 ` [Xen-devel] " Jan Beulich 2019-05-24 9:29 ` Andrew Cooper 2019-05-24 9:29 ` [Xen-devel] " Andrew Cooper 2019-05-27 16:08 ` Roger Pau Monné 2019-05-27 16:08 ` [Xen-devel] " Roger Pau Monné 2019-05-28 8:54 ` Jan Beulich 2019-05-28 8:54 ` [Xen-devel] " Jan Beulich 2019-05-10 16:10 ` [PATCH 3/5] pci: switch pci_conf_{read/write} to use pci_sbdf_t Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-24 9:40 ` Andrew Cooper 2019-05-24 9:40 ` [Xen-devel] " Andrew Cooper 2019-05-24 10:01 ` Jan Beulich 2019-05-24 10:01 ` [Xen-devel] " Jan Beulich 2019-05-27 16:44 ` Roger Pau Monné 2019-05-27 16:44 ` [Xen-devel] " Roger Pau Monné 2019-05-28 8:51 ` Jan Beulich 2019-05-28 8:51 ` [Xen-devel] " Jan Beulich 2019-05-28 10:05 ` Roger Pau Monné 2019-05-28 10:05 ` [Xen-devel] " Roger Pau Monné 2019-05-28 10:38 ` Jan Beulich 2019-05-28 10:38 ` [Xen-devel] " Jan Beulich 2019-05-10 16:10 ` [PATCH 4/5] print: introduce a format specifier for pci_sbdf_t Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-24 10:36 ` Jan Beulich 2019-05-24 10:36 ` [Xen-devel] " Jan Beulich 2019-05-24 10:59 ` Andrew Cooper 2019-05-24 10:59 ` [Xen-devel] " Andrew Cooper 2019-05-24 11:16 ` Jan Beulich [this message] 2019-05-24 11:16 ` Jan Beulich 2019-05-27 15:48 ` Roger Pau Monné 2019-05-27 15:48 ` [Xen-devel] " Roger Pau Monné 2019-05-27 15:58 ` Jan Beulich 2019-05-27 15:58 ` [Xen-devel] " Jan Beulich 2019-05-10 16:10 ` [PATCH 5/5] pci: switch PCI capabilities related functions to use pci_sbdf_t Roger Pau Monne 2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne 2019-05-24 10:52 ` Jan Beulich 2019-05-24 10:52 ` [Xen-devel] " Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5CE7D2A90200007800231F9A@prv1-mh.provo.novell.com \ --to=jbeulich@suse.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=Ian.Jackson@eu.citrix.com \ --cc=andrew.cooper3@citrix.com \ --cc=brian.woods@amd.com \ --cc=julien.grall@arm.com \ --cc=kevin.tian@intel.com \ --cc=konrad.wilk@oracle.com \ --cc=roger.pau@citrix.com \ --cc=sstabellini@kernel.org \ --cc=suravee.suthikulpanit@amd.com \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.