From: Catalin Marinas <catalin.marinas@arm.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, ndesaulniers@google.com, will@kernel.org, tglx@linutronix.de Subject: Re: [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Date: Thu, 26 Sep 2019 16:13:51 +0100 [thread overview] Message-ID: <20190926151351.GG9689@arrakis.emea.arm.com> (raw) In-Reply-To: <20190926133805.52348-2-vincenzo.frascino@arm.com> On Thu, Sep 26, 2019 at 02:38:02PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 37c610963eee..13e2d2e16af7 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -110,7 +110,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT) > + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_GCC) > select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_PCI > @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET > default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS > default 0xffffffffffffffff > > +config COMPATCC_IS_GCC > + def_bool $(success,$(CROSS_COMPILE_COMPAT)gcc --version | head -n 1 | grep -q arm) Nitpick: COMPAT_CC_IS_ARM_GCC together with 'grep -q "arm-.*-gcc"' The patch below allows me to use $(COMPATCC) directly here and also set either CROSS_COMPILE_COMPAT or COMPATCC on the command line: ----------8<---------------------------------- diff --git a/arch/arm64/Kbuild b/arch/arm64/Kbuild index 75cf8c796d0e..d6465823b281 100644 --- a/arch/arm64/Kbuild +++ b/arch/arm64/Kbuild @@ -4,9 +4,3 @@ obj-$(CONFIG_NET) += net/ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(CONFIG_CRYPTO) += crypto/ - -# as-instr-compat -# Usage: cflags-y += $(call as-instr-compat,instr,option1,option2) - -as-instr-compat = $(call try-run,\ - printf "%b\n" "$(1)" | $(COMPATCC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 5d4be0b4f980..811c89fa2b71 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -110,7 +110,7 @@ config ARM64 select GENERIC_STRNLEN_USER select GENERIC_TIME_VSYSCALL select GENERIC_GETTIMEOFDAY - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_GCC) + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC) select HANDLE_DOMAIN_IRQ select HARDIRQS_SW_RESEND select HAVE_PCI @@ -313,8 +313,8 @@ config KASAN_SHADOW_OFFSET default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS default 0xffffffffffffffff -config COMPATCC_IS_GCC - def_bool $(success,$(CROSS_COMPILE_COMPAT)gcc --version | head -n 1 | grep -q arm) +config COMPATCC_IS_ARM_GCC + def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc") source "arch/arm64/Kconfig.platforms" diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 34f53eb11878..6b4eb5c444c5 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -53,6 +53,9 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable) endif endif +COMPATCC ?= $(CROSS_COMPILE_COMPAT)gcc +export COMPATCC + ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y) export CONFIG_COMPAT_VDSO := y compat_vdso := -DCONFIG_COMPAT_VDSO=1 diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index 22f0d31ea528..77aa61340374 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -8,8 +8,6 @@ ARCH_REL_TYPE_ABS := R_ARM_JUMP_SLOT|R_ARM_GLOB_DAT|R_ARM_ABS32 include $(srctree)/lib/vdso/Makefile -COMPATCC := $(CROSS_COMPILE_COMPAT)gcc - # Same as cc-*option, but using COMPATCC instead of CC cc32-option = $(call try-run,\ $(COMPATCC) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2))
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Date: Thu, 26 Sep 2019 16:13:51 +0100 [thread overview] Message-ID: <20190926151351.GG9689@arrakis.emea.arm.com> (raw) In-Reply-To: <20190926133805.52348-2-vincenzo.frascino@arm.com> On Thu, Sep 26, 2019 at 02:38:02PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 37c610963eee..13e2d2e16af7 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -110,7 +110,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT) > + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_GCC) > select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_PCI > @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET > default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS > default 0xffffffffffffffff > > +config COMPATCC_IS_GCC > + def_bool $(success,$(CROSS_COMPILE_COMPAT)gcc --version | head -n 1 | grep -q arm) Nitpick: COMPAT_CC_IS_ARM_GCC together with 'grep -q "arm-.*-gcc"' The patch below allows me to use $(COMPATCC) directly here and also set either CROSS_COMPILE_COMPAT or COMPATCC on the command line: ----------8<---------------------------------- diff --git a/arch/arm64/Kbuild b/arch/arm64/Kbuild index 75cf8c796d0e..d6465823b281 100644 --- a/arch/arm64/Kbuild +++ b/arch/arm64/Kbuild @@ -4,9 +4,3 @@ obj-$(CONFIG_NET) += net/ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(CONFIG_CRYPTO) += crypto/ - -# as-instr-compat -# Usage: cflags-y += $(call as-instr-compat,instr,option1,option2) - -as-instr-compat = $(call try-run,\ - printf "%b\n" "$(1)" | $(COMPATCC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 5d4be0b4f980..811c89fa2b71 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -110,7 +110,7 @@ config ARM64 select GENERIC_STRNLEN_USER select GENERIC_TIME_VSYSCALL select GENERIC_GETTIMEOFDAY - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_GCC) + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC) select HANDLE_DOMAIN_IRQ select HARDIRQS_SW_RESEND select HAVE_PCI @@ -313,8 +313,8 @@ config KASAN_SHADOW_OFFSET default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS default 0xffffffffffffffff -config COMPATCC_IS_GCC - def_bool $(success,$(CROSS_COMPILE_COMPAT)gcc --version | head -n 1 | grep -q arm) +config COMPATCC_IS_ARM_GCC + def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc") source "arch/arm64/Kconfig.platforms" diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 34f53eb11878..6b4eb5c444c5 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -53,6 +53,9 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable) endif endif +COMPATCC ?= $(CROSS_COMPILE_COMPAT)gcc +export COMPATCC + ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y) export CONFIG_COMPAT_VDSO := y compat_vdso := -DCONFIG_COMPAT_VDSO=1 diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index 22f0d31ea528..77aa61340374 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -8,8 +8,6 @@ ARCH_REL_TYPE_ABS := R_ARM_JUMP_SLOT|R_ARM_GLOB_DAT|R_ARM_ABS32 include $(srctree)/lib/vdso/Makefile -COMPATCC := $(CROSS_COMPILE_COMPAT)gcc - # Same as cc-*option, but using COMPATCC instead of CC cc32-option = $(call try-run,\ $(COMPATCC) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-26 15:13 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-20 14:27 Problems with arm64 compat vdso Will Deacon 2019-09-20 16:33 ` Vincenzo Frascino 2019-09-23 16:41 ` Ard Biesheuvel 2019-09-24 12:11 ` Vincenzo Frascino 2019-09-24 18:06 ` Nick Desaulniers 2019-09-24 20:42 ` Vincenzo Frascino 2019-09-25 15:58 ` Ard Biesheuvel 2019-09-26 6:03 ` [PATCH 0/4] arm64: vdso32: Address various issues Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:06 ` Catalin Marinas 2019-09-26 8:06 ` Catalin Marinas 2019-09-26 10:56 ` Vincenzo Frascino 2019-09-26 10:56 ` Vincenzo Frascino 2019-09-26 11:02 ` Vincenzo Frascino 2019-09-26 11:02 ` Vincenzo Frascino 2019-09-26 15:23 ` Catalin Marinas 2019-09-26 15:23 ` Catalin Marinas 2019-09-26 12:22 ` Vincenzo Frascino 2019-09-26 12:22 ` Vincenzo Frascino 2019-09-26 15:17 ` Catalin Marinas 2019-09-26 15:17 ` Catalin Marinas 2019-09-26 20:17 ` Vincenzo Frascino 2019-09-26 20:17 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:30 ` Catalin Marinas 2019-09-26 8:30 ` Catalin Marinas 2019-09-26 10:59 ` Vincenzo Frascino 2019-09-26 10:59 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:32 ` Catalin Marinas 2019-09-26 8:32 ` Catalin Marinas 2019-09-26 11:03 ` Vincenzo Frascino 2019-09-26 11:03 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:34 ` Catalin Marinas 2019-09-26 8:34 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 13:38 ` [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:13 ` Catalin Marinas [this message] 2019-09-26 15:13 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 14:26 ` Catalin Marinas 2019-09-26 14:26 ` Catalin Marinas 2019-09-26 20:19 ` Vincenzo Frascino 2019-09-26 20:19 ` Vincenzo Frascino 2019-09-26 15:59 ` Catalin Marinas 2019-09-26 15:59 ` Catalin Marinas 2019-09-26 21:17 ` Vincenzo Frascino 2019-09-26 21:17 ` Vincenzo Frascino 2019-09-26 16:23 ` Nick Desaulniers 2019-09-26 16:23 ` Nick Desaulniers 2019-09-26 13:38 ` [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:22 ` Catalin Marinas 2019-09-26 15:22 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:31 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Catalin Marinas 2019-09-26 15:31 ` Catalin Marinas 2019-09-26 20:29 ` Vincenzo Frascino 2019-09-26 20:29 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 0/5]arm64: " Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:24 ` Catalin Marinas 2019-09-27 9:24 ` Catalin Marinas 2019-10-01 13:14 ` Will Deacon 2019-10-01 13:14 ` Will Deacon 2019-10-01 13:27 ` Catalin Marinas 2019-10-01 13:27 ` Catalin Marinas 2019-10-01 14:20 ` Vincenzo Frascino 2019-10-01 14:20 ` Vincenzo Frascino 2019-10-01 14:20 ` Will Deacon 2019-10-01 14:20 ` Will Deacon 2019-10-01 14:37 ` Vincenzo Frascino 2019-10-01 14:37 ` Vincenzo Frascino 2019-10-01 14:43 ` Will Deacon 2019-10-01 14:43 ` Will Deacon 2019-10-01 14:59 ` Vincenzo Frascino 2019-10-01 14:59 ` Vincenzo Frascino 2019-10-01 15:30 ` Catalin Marinas 2019-10-01 15:30 ` Catalin Marinas 2019-10-01 16:46 ` Will Deacon 2019-10-01 16:46 ` Will Deacon 2019-10-01 16:59 ` Nick Desaulniers 2019-10-01 16:59 ` Nick Desaulniers 2019-10-01 17:07 ` Will Deacon 2019-10-01 17:07 ` Will Deacon 2019-10-01 17:12 ` Nick Desaulniers 2019-10-01 17:12 ` Nick Desaulniers 2019-10-01 17:14 ` Will Deacon 2019-10-01 17:14 ` Will Deacon 2019-09-26 21:43 ` [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:25 ` Catalin Marinas 2019-09-27 9:25 ` Catalin Marinas 2019-10-01 13:26 ` Will Deacon 2019-10-01 13:26 ` Will Deacon 2019-10-01 14:23 ` Vincenzo Frascino 2019-10-01 14:23 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 3/5] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:26 ` Catalin Marinas 2019-09-27 9:26 ` Catalin Marinas 2019-10-01 13:21 ` Will Deacon 2019-10-01 13:21 ` Will Deacon 2019-10-01 14:41 ` Vincenzo Frascino 2019-10-01 14:41 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 4/5] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 5/5] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:27 ` Catalin Marinas 2019-09-27 9:27 ` Catalin Marinas 2019-09-27 10:46 ` [PATCH v3 0/5]arm64: vdso32: Address various issues Catalin Marinas 2019-09-27 10:46 ` Catalin Marinas 2019-10-01 13:27 ` Will Deacon 2019-10-01 13:27 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190926151351.GG9689@arrakis.emea.arm.com \ --to=catalin.marinas@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ndesaulniers@google.com \ --cc=tglx@linutronix.de \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.