From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Will Deacon <will@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, ndesaulniers@google.com, tglx@linutronix.de Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Date: Tue, 1 Oct 2019 15:37:49 +0100 [thread overview] Message-ID: <7558914c-fc2d-d05a-ccbe-76ef451670ae@arm.com> (raw) In-Reply-To: <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> On 10/1/19 3:20 PM, Will Deacon wrote: > On Tue, Oct 01, 2019 at 03:20:35PM +0100, Vincenzo Frascino wrote: >> On 10/1/19 2:27 PM, Catalin Marinas wrote: >>> On Tue, Oct 01, 2019 at 02:14:23PM +0100, Will Deacon wrote: >>>> On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote: >>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>>>> index 37c610963eee..0e5beb928af5 100644 >>>>> --- a/arch/arm64/Kconfig >>>>> +++ b/arch/arm64/Kconfig >>>>> @@ -110,7 +110,7 @@ config ARM64 >>>>> select GENERIC_STRNLEN_USER >>>>> select GENERIC_TIME_VSYSCALL >>>>> select GENERIC_GETTIMEOFDAY >>>>> - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT) >>>>> + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC) >>>>> select HANDLE_DOMAIN_IRQ >>>>> select HARDIRQS_SW_RESEND >>>>> select HAVE_PCI >>>>> @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET >>>>> default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS >>>>> default 0xffffffffffffffff >>>>> >>>>> +config COMPATCC_IS_ARM_GCC >>>>> + def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc") >>>> >>>> I've seen toolchains where the first part of the tuple is "armv7-", so they >>>> won't get detected here. However, do we really need to detect this? If >>>> somebody passes a duff compiler, then the build will fail in the same way as >>>> if they passed it to CROSS_COMPILE=. >>> >>> Not sure what happens if we pass an aarch64 compiler. Can we end up with >>> a 64-bit compat vDSO? >>> >> >> I agree with Catalin here. The problem is not only when you pass and aarch64 >> toolchain but even an x86 and so on. > > I disagree. What happens if you do: > > $ make ARCH=arm64 CROSS_COMPILE=x86_64-linux-gnu- > > on your x86 box? > The kernel compilation breaks as follows: x86_64-linux-gnu-gcc: error: unrecognized command line option ‘-mlittle-endian’; did you mean ‘-fconvert=little-endian’? /data1/Projects/LinuxKernel/linux/scripts/Makefile.build:265: recipe for target 'scripts/mod/empty.o' failed make[2]: *** [scripts/mod/empty.o] Error 1 /data1/Projects/LinuxKernel/linux/Makefile:1128: recipe for target 'prepare0' failed make[1]: *** [prepare0] Error 2 make[1]: Leaving directory '/data1/Projects/LinuxKernel/linux-out' Makefile:179: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Similar issue in the compat vdso library compilation if I do (without the check): $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_COMPAT=x86_64-linux-gnu- With this check the compilation completes correctly but the compat vdso does not get built (unless my environment is playing me tricks ;) ). >> If the problem is related to armv7- we can change the rule as "arm.*-gcc" which >> should detect them as well. Do you know what is the triple that an armv7- >> toolchain prints? > > 'fraid not, since I don't have one to hand. I think you'd end up matching > arm*-gcc, which is pretty broad. > If we all agree I can extend this rule then. > Will > -- Regards, Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Will Deacon <will@kernel.org> Cc: ard.biesheuvel@linaro.org, Catalin Marinas <catalin.marinas@arm.com>, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Date: Tue, 1 Oct 2019 15:37:49 +0100 [thread overview] Message-ID: <7558914c-fc2d-d05a-ccbe-76ef451670ae@arm.com> (raw) In-Reply-To: <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> On 10/1/19 3:20 PM, Will Deacon wrote: > On Tue, Oct 01, 2019 at 03:20:35PM +0100, Vincenzo Frascino wrote: >> On 10/1/19 2:27 PM, Catalin Marinas wrote: >>> On Tue, Oct 01, 2019 at 02:14:23PM +0100, Will Deacon wrote: >>>> On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote: >>>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>>>> index 37c610963eee..0e5beb928af5 100644 >>>>> --- a/arch/arm64/Kconfig >>>>> +++ b/arch/arm64/Kconfig >>>>> @@ -110,7 +110,7 @@ config ARM64 >>>>> select GENERIC_STRNLEN_USER >>>>> select GENERIC_TIME_VSYSCALL >>>>> select GENERIC_GETTIMEOFDAY >>>>> - select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT) >>>>> + select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC) >>>>> select HANDLE_DOMAIN_IRQ >>>>> select HARDIRQS_SW_RESEND >>>>> select HAVE_PCI >>>>> @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET >>>>> default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS >>>>> default 0xffffffffffffffff >>>>> >>>>> +config COMPATCC_IS_ARM_GCC >>>>> + def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc") >>>> >>>> I've seen toolchains where the first part of the tuple is "armv7-", so they >>>> won't get detected here. However, do we really need to detect this? If >>>> somebody passes a duff compiler, then the build will fail in the same way as >>>> if they passed it to CROSS_COMPILE=. >>> >>> Not sure what happens if we pass an aarch64 compiler. Can we end up with >>> a 64-bit compat vDSO? >>> >> >> I agree with Catalin here. The problem is not only when you pass and aarch64 >> toolchain but even an x86 and so on. > > I disagree. What happens if you do: > > $ make ARCH=arm64 CROSS_COMPILE=x86_64-linux-gnu- > > on your x86 box? > The kernel compilation breaks as follows: x86_64-linux-gnu-gcc: error: unrecognized command line option ‘-mlittle-endian’; did you mean ‘-fconvert=little-endian’? /data1/Projects/LinuxKernel/linux/scripts/Makefile.build:265: recipe for target 'scripts/mod/empty.o' failed make[2]: *** [scripts/mod/empty.o] Error 1 /data1/Projects/LinuxKernel/linux/Makefile:1128: recipe for target 'prepare0' failed make[1]: *** [prepare0] Error 2 make[1]: Leaving directory '/data1/Projects/LinuxKernel/linux-out' Makefile:179: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Similar issue in the compat vdso library compilation if I do (without the check): $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_COMPAT=x86_64-linux-gnu- With this check the compilation completes correctly but the compat vdso does not get built (unless my environment is playing me tricks ;) ). >> If the problem is related to armv7- we can change the rule as "arm.*-gcc" which >> should detect them as well. Do you know what is the triple that an armv7- >> toolchain prints? > > 'fraid not, since I don't have one to hand. I think you'd end up matching > arm*-gcc, which is pretty broad. > If we all agree I can extend this rule then. > Will > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-01 14:36 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-20 14:27 Problems with arm64 compat vdso Will Deacon 2019-09-20 16:33 ` Vincenzo Frascino 2019-09-23 16:41 ` Ard Biesheuvel 2019-09-24 12:11 ` Vincenzo Frascino 2019-09-24 18:06 ` Nick Desaulniers 2019-09-24 20:42 ` Vincenzo Frascino 2019-09-25 15:58 ` Ard Biesheuvel 2019-09-26 6:03 ` [PATCH 0/4] arm64: vdso32: Address various issues Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:06 ` Catalin Marinas 2019-09-26 8:06 ` Catalin Marinas 2019-09-26 10:56 ` Vincenzo Frascino 2019-09-26 10:56 ` Vincenzo Frascino 2019-09-26 11:02 ` Vincenzo Frascino 2019-09-26 11:02 ` Vincenzo Frascino 2019-09-26 15:23 ` Catalin Marinas 2019-09-26 15:23 ` Catalin Marinas 2019-09-26 12:22 ` Vincenzo Frascino 2019-09-26 12:22 ` Vincenzo Frascino 2019-09-26 15:17 ` Catalin Marinas 2019-09-26 15:17 ` Catalin Marinas 2019-09-26 20:17 ` Vincenzo Frascino 2019-09-26 20:17 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:30 ` Catalin Marinas 2019-09-26 8:30 ` Catalin Marinas 2019-09-26 10:59 ` Vincenzo Frascino 2019-09-26 10:59 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:32 ` Catalin Marinas 2019-09-26 8:32 ` Catalin Marinas 2019-09-26 11:03 ` Vincenzo Frascino 2019-09-26 11:03 ` Vincenzo Frascino 2019-09-26 6:03 ` [PATCH 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 6:03 ` Vincenzo Frascino 2019-09-26 8:34 ` Catalin Marinas 2019-09-26 8:34 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 13:38 ` [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:13 ` Catalin Marinas 2019-09-26 15:13 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 14:26 ` Catalin Marinas 2019-09-26 14:26 ` Catalin Marinas 2019-09-26 20:19 ` Vincenzo Frascino 2019-09-26 20:19 ` Vincenzo Frascino 2019-09-26 15:59 ` Catalin Marinas 2019-09-26 15:59 ` Catalin Marinas 2019-09-26 21:17 ` Vincenzo Frascino 2019-09-26 21:17 ` Vincenzo Frascino 2019-09-26 16:23 ` Nick Desaulniers 2019-09-26 16:23 ` Nick Desaulniers 2019-09-26 13:38 ` [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:22 ` Catalin Marinas 2019-09-26 15:22 ` Catalin Marinas 2019-09-26 13:38 ` [PATCH v2 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 13:38 ` Vincenzo Frascino 2019-09-26 15:31 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Catalin Marinas 2019-09-26 15:31 ` Catalin Marinas 2019-09-26 20:29 ` Vincenzo Frascino 2019-09-26 20:29 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 0/5]arm64: " Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:24 ` Catalin Marinas 2019-09-27 9:24 ` Catalin Marinas 2019-10-01 13:14 ` Will Deacon 2019-10-01 13:14 ` Will Deacon 2019-10-01 13:27 ` Catalin Marinas 2019-10-01 13:27 ` Catalin Marinas 2019-10-01 14:20 ` Vincenzo Frascino 2019-10-01 14:20 ` Vincenzo Frascino 2019-10-01 14:20 ` Will Deacon 2019-10-01 14:20 ` Will Deacon 2019-10-01 14:37 ` Vincenzo Frascino [this message] 2019-10-01 14:37 ` Vincenzo Frascino 2019-10-01 14:43 ` Will Deacon 2019-10-01 14:43 ` Will Deacon 2019-10-01 14:59 ` Vincenzo Frascino 2019-10-01 14:59 ` Vincenzo Frascino 2019-10-01 15:30 ` Catalin Marinas 2019-10-01 15:30 ` Catalin Marinas 2019-10-01 16:46 ` Will Deacon 2019-10-01 16:46 ` Will Deacon 2019-10-01 16:59 ` Nick Desaulniers 2019-10-01 16:59 ` Nick Desaulniers 2019-10-01 17:07 ` Will Deacon 2019-10-01 17:07 ` Will Deacon 2019-10-01 17:12 ` Nick Desaulniers 2019-10-01 17:12 ` Nick Desaulniers 2019-10-01 17:14 ` Will Deacon 2019-10-01 17:14 ` Will Deacon 2019-09-26 21:43 ` [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:25 ` Catalin Marinas 2019-09-27 9:25 ` Catalin Marinas 2019-10-01 13:26 ` Will Deacon 2019-10-01 13:26 ` Will Deacon 2019-10-01 14:23 ` Vincenzo Frascino 2019-10-01 14:23 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 3/5] arm64: vdso32: Fix compilation warning Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:26 ` Catalin Marinas 2019-09-27 9:26 ` Catalin Marinas 2019-10-01 13:21 ` Will Deacon 2019-10-01 13:21 ` Will Deacon 2019-10-01 14:41 ` Vincenzo Frascino 2019-10-01 14:41 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 4/5] arm64: Remove gettimeofday.S Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-26 21:43 ` [PATCH v3 5/5] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino 2019-09-26 21:43 ` Vincenzo Frascino 2019-09-27 9:27 ` Catalin Marinas 2019-09-27 9:27 ` Catalin Marinas 2019-09-27 10:46 ` [PATCH v3 0/5]arm64: vdso32: Address various issues Catalin Marinas 2019-09-27 10:46 ` Catalin Marinas 2019-10-01 13:27 ` Will Deacon 2019-10-01 13:27 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7558914c-fc2d-d05a-ccbe-76ef451670ae@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ndesaulniers@google.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.