From: Stefan Hajnoczi <stefanha@gmail.com> To: Jason Wang <jasowang@redhat.com> Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akrowiak@linux.ibm.com, freude@linux.ibm.com, lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, christophe.de.dinechin@gmail.com, kevin.tian@intel.com Subject: Re: [PATCH V3 6/7] virtio: introduce a mdev based transport Date: Mon, 14 Oct 2019 18:39:42 +0100 [thread overview] Message-ID: <20191014173942.GB5359@stefanha-x1.localdomain> (raw) In-Reply-To: <20191011081557.28302-7-jasowang@redhat.com> [-- Attachment #1: Type: text/plain, Size: 1151 bytes --] On Fri, Oct 11, 2019 at 04:15:56PM +0800, Jason Wang wrote: > +struct virtio_mdev_device { > + struct virtio_device vdev; > + struct mdev_device *mdev; > + unsigned long version; > + > + struct virtqueue **vqs; > + /* The lock to protect virtqueue list */ > + spinlock_t lock; > + struct list_head virtqueues; Is this a list of struct virtio_mdev_vq_info? Please document the actual type in a comment. > +static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs, > + struct virtqueue *vqs[], > + vq_callback_t *callbacks[], > + const char * const names[], > + const bool *ctx, > + struct irq_affinity *desc) > +{ > + struct virtio_mdev_device *vm_dev = to_virtio_mdev_device(vdev); > + struct mdev_device *mdev = vm_get_mdev(vdev); > + const struct virtio_mdev_device_ops *ops = mdev_get_dev_ops(mdev); > + struct virtio_mdev_callback cb; > + int i, err, queue_idx = 0; > + > + vm_dev->vqs = kmalloc_array(queue_idx, sizeof(*vm_dev->vqs), > + GFP_KERNEL); kmalloc_array(0, ...)? I would have expected nvqs instead of queue_idx (0). What is this the purpose of vm_dev->vqs and does anything ever access it? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@gmail.com> To: Jason Wang <jasowang@redhat.com> Cc: christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, joonas.lahtinen@linux.intel.com, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, zhi.a.wang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, xiao.w.wang@intel.com, freude@linux.ibm.com, zhenyuw@linux.intel.com, parav@mellanox.com, zhihong.wang@intel.com, rodrigo.vivi@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coque Subject: Re: [PATCH V3 6/7] virtio: introduce a mdev based transport Date: Mon, 14 Oct 2019 18:39:42 +0100 [thread overview] Message-ID: <20191014173942.GB5359@stefanha-x1.localdomain> (raw) In-Reply-To: <20191011081557.28302-7-jasowang@redhat.com> [-- Attachment #1.1: Type: text/plain, Size: 1151 bytes --] On Fri, Oct 11, 2019 at 04:15:56PM +0800, Jason Wang wrote: > +struct virtio_mdev_device { > + struct virtio_device vdev; > + struct mdev_device *mdev; > + unsigned long version; > + > + struct virtqueue **vqs; > + /* The lock to protect virtqueue list */ > + spinlock_t lock; > + struct list_head virtqueues; Is this a list of struct virtio_mdev_vq_info? Please document the actual type in a comment. > +static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs, > + struct virtqueue *vqs[], > + vq_callback_t *callbacks[], > + const char * const names[], > + const bool *ctx, > + struct irq_affinity *desc) > +{ > + struct virtio_mdev_device *vm_dev = to_virtio_mdev_device(vdev); > + struct mdev_device *mdev = vm_get_mdev(vdev); > + const struct virtio_mdev_device_ops *ops = mdev_get_dev_ops(mdev); > + struct virtio_mdev_callback cb; > + int i, err, queue_idx = 0; > + > + vm_dev->vqs = kmalloc_array(queue_idx, sizeof(*vm_dev->vqs), > + GFP_KERNEL); kmalloc_array(0, ...)? I would have expected nvqs instead of queue_idx (0). What is this the purpose of vm_dev->vqs and does anything ever access it? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2019-10-14 17:39 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-11 8:15 [PATCH V3 0/7] mdev based hardware virtio offloading support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 1/7] mdev: class id support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 12:12 ` Jason Wang 2019-10-15 12:12 ` Jason Wang 2019-10-15 12:12 ` Jason Wang 2019-10-15 16:38 ` Alex Williamson 2019-10-15 16:38 ` Alex Williamson 2019-10-16 4:38 ` Jason Wang 2019-10-16 4:38 ` Jason Wang 2019-10-16 4:38 ` Jason Wang 2019-10-15 16:38 ` Alex Williamson 2019-10-16 4:57 ` Parav Pandit 2019-10-16 4:57 ` Parav Pandit 2019-10-16 4:57 ` Parav Pandit 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 2/7] mdev: bus uevent support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:27 ` Cornelia Huck 2019-10-15 10:27 ` Cornelia Huck 2019-10-15 12:13 ` Jason Wang 2019-10-15 12:13 ` Jason Wang 2019-10-15 12:13 ` Jason Wang 2019-10-15 10:27 ` Cornelia Huck 2019-10-16 5:06 ` Parav Pandit 2019-10-16 5:06 ` Parav Pandit 2019-10-16 5:06 ` Parav Pandit 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 3/7] modpost: add support for mdev class id Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 4/7] mdev: introduce device specific ops Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:41 ` Cornelia Huck 2019-10-15 10:41 ` Cornelia Huck 2019-10-15 12:17 ` Jason Wang 2019-10-15 12:17 ` Jason Wang 2019-10-15 12:17 ` Jason Wang 2019-10-15 17:26 ` Alex Williamson 2019-10-15 17:26 ` Alex Williamson 2019-10-15 17:26 ` Alex Williamson 2019-10-16 5:50 ` Parav Pandit 2019-10-16 8:52 ` Cornelia Huck 2019-10-16 15:31 ` Parav Pandit 2019-10-16 16:53 ` Alex Williamson 2019-10-16 20:48 ` Parav Pandit 2019-10-16 22:37 ` Alex Williamson 2019-10-17 16:29 ` Parav Pandit 2019-10-17 8:30 ` Jason Wang 2019-10-17 8:30 ` Jason Wang 2019-10-17 8:45 ` Cornelia Huck 2019-10-17 8:46 ` Jason Wang 2019-10-17 8:46 ` Jason Wang 2019-10-16 16:53 ` Alex Williamson 2019-10-15 10:41 ` Cornelia Huck 2019-10-11 8:15 ` [PATCH V3 5/7] mdev: introduce virtio device and its device ops Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-15 3:27 ` Jason Wang 2019-10-15 3:27 ` Jason Wang 2019-10-15 3:27 ` Jason Wang 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 6/7] virtio: introduce a mdev based transport Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-14 17:39 ` Stefan Hajnoczi [this message] 2019-10-14 17:39 ` Stefan Hajnoczi 2019-10-15 3:29 ` Jason Wang 2019-10-15 3:29 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 7/7] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev4) Patchwork 2019-10-11 10:03 ` ✓ Fi.CI.BAT: success " Patchwork 2019-10-11 17:40 ` ✓ Fi.CI.IGT: " Patchwork 2019-10-14 17:49 ` [PATCH V3 0/7] mdev based hardware virtio offloading support Stefan Hajnoczi 2019-10-14 17:49 ` Stefan Hajnoczi 2019-10-14 17:49 ` Stefan Hajnoczi 2019-10-15 3:37 ` Jason Wang 2019-10-15 3:37 ` Jason Wang 2019-10-15 3:37 ` Jason Wang 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-17 1:42 ` Jason Wang 2019-10-17 1:42 ` Jason Wang 2019-10-17 1:42 ` Jason Wang 2019-10-17 9:43 ` Stefan Hajnoczi 2019-10-17 9:43 ` Stefan Hajnoczi 2019-10-17 9:43 ` Stefan Hajnoczi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191014173942.GB5359@stefanha-x1.localdomain \ --to=stefanha@gmail.com \ --cc=airlied@linux.ie \ --cc=akrowiak@linux.ibm.com \ --cc=alex.williamson@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=christophe.de.dinechin@gmail.com \ --cc=cohuck@redhat.com \ --cc=cunming.liang@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=eperezma@redhat.com \ --cc=farman@linux.ibm.com \ --cc=freude@linux.ibm.com \ --cc=gor@linux.ibm.com \ --cc=haotian.wang@sifive.com \ --cc=heiko.carstens@de.ibm.com \ --cc=idos@mellanox.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-gvt-dev@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=jasowang@redhat.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=kwankhede@nvidia.com \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=oberpar@linux.ibm.com \ --cc=parav@mellanox.com \ --cc=pasic@linux.ibm.com \ --cc=rob.miller@broadcom.com \ --cc=rodrigo.vivi@intel.com \ --cc=sebott@linux.ibm.com \ --cc=tiwei.bie@intel.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ --cc=zhenyuw@linux.intel.com \ --cc=zhi.a.wang@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.