From: Jason Wang <jasowang@redhat.com> To: Parav Pandit <parav@mellanox.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "intel-gvt-dev@lists.freedesktop.org" <intel-gvt-dev@lists.freedesktop.org>, "kwankhede@nvidia.com" <kwankhede@nvidia.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "mst@redhat.com" <mst@redhat.com>, "tiwei.bie@intel.com" <tiwei.bie@intel.com> Cc: "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "cohuck@redhat.com" <cohuck@redhat.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "cunming.liang@intel.com" <cunming.liang@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "rob.miller@broadcom.com" <rob.miller@broadcom.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "haotian.wang@sifive.com" <haotian.wang@sifive.com>, "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>, "zhi.a.wang@intel.com" <zhi.a.wang@intel.com>, "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>, "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>, "rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>, "airlied@linux.ie" <airlied@linux.ie>, "daniel@ffwll.ch" <daniel@ffwll.ch>, "farman@linux.ibm.com" <farman@linux.ibm.com>, "pasic@linux.ibm.com" <pasic@linux.ibm.com>, "sebott@linux.ibm.com" <sebott@linux.ibm.com>, "oberpar@linux.ibm.com" <oberpar@linux.ibm.com>, "heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>, "gor@linux.ibm.com" <gor@linux.ibm.com>, "borntraeger@de.ibm.com" <borntraeger@de.ibm.com>, "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>, "freude@linux.ibm.com" <freude@linux.ibm.com>, "lingshan.zhu@intel.com" <lingshan.zhu@intel.com>, Ido Shamay <idos@mellanox.com>, "eperezma@redhat.com" <eperezma@redhat.com>, "lulu@redhat.com" <lulu@redhat.com>, "christophe.de.dinechin@gmail.com" <christophe.de.dinechin@gmail.com>, "kevin.tian@intel.com" <kevin.tian@intel.com> Subject: Re: [PATCH V3 1/7] mdev: class id support Date: Thu, 17 Oct 2019 16:27:41 +0800 [thread overview] Message-ID: <67b645a6-1b70-094d-6a12-fc6591e07a13@redhat.com> (raw) In-Reply-To: <AM0PR05MB4866481AEE614FDF766C6A25D1920@AM0PR05MB4866.eurprd05.prod.outlook.com> On 2019/10/16 下午12:57, Parav Pandit wrote: >> +static struct mdev_class_id id_table[] = { > static const > >> + { MDEV_ID_VFIO }, > I guess you don't need extra braces for each entry. > Since this enum represents MDEV class id, it better to name it as MDEV_CLASS_ID_VFIO. > (Similar to PCI_VENDOR_ID, PCI_DEVICE_ID).. > Gcc start to complain like: warning: missing braces around initializer [-Wmissing-braces] static const struct mdev_class_id id_table[] = { ^ MDEV_ID_VFIO, 0, { } { }; } So I will keep this part untouched. Thanks >> + { 0 }, >> +};
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Parav Pandit <parav@mellanox.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "intel-gvt-dev@lists.freedesktop.org" <intel-gvt-dev@lists.freedesktop.org>, "kwankhede@nvidia.com" <kwankhede@nvidia.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "mst@redhat.com" <mst@redhat.com>, "tiwei.bie@intel.com" <tiwei.bie@intel.com> Cc: "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "cohuck@redhat.com" <cohuck@redhat.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "cunming.liang@intel.com" <cunming.liang@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "rob.miller@broadcom.com" <rob.miller@broadcom.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "haotian.wang@sifive.com" <haotian.wang@sifive.com>, "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>, "zhi.a.wang@intel.com" <zhi.a.wang@intel.com>, "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>, "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>, "rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com> Subject: Re: [PATCH V3 1/7] mdev: class id support Date: Thu, 17 Oct 2019 16:27:41 +0800 [thread overview] Message-ID: <67b645a6-1b70-094d-6a12-fc6591e07a13@redhat.com> (raw) In-Reply-To: <AM0PR05MB4866481AEE614FDF766C6A25D1920@AM0PR05MB4866.eurprd05.prod.outlook.com> On 2019/10/16 下午12:57, Parav Pandit wrote: >> +static struct mdev_class_id id_table[] = { > static const > >> + { MDEV_ID_VFIO }, > I guess you don't need extra braces for each entry. > Since this enum represents MDEV class id, it better to name it as MDEV_CLASS_ID_VFIO. > (Similar to PCI_VENDOR_ID, PCI_DEVICE_ID).. > Gcc start to complain like: warning: missing braces around initializer [-Wmissing-braces] static const struct mdev_class_id id_table[] = { ^ MDEV_ID_VFIO, 0, { } { }; } So I will keep this part untouched. Thanks >> + { 0 }, >> +};
next prev parent reply other threads:[~2019-10-17 8:28 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-11 8:15 [PATCH V3 0/7] mdev based hardware virtio offloading support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 1/7] mdev: class id support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 10:26 ` Cornelia Huck 2019-10-15 12:12 ` Jason Wang 2019-10-15 12:12 ` Jason Wang 2019-10-15 12:12 ` Jason Wang 2019-10-15 16:38 ` Alex Williamson 2019-10-15 16:38 ` Alex Williamson 2019-10-16 4:38 ` Jason Wang 2019-10-16 4:38 ` Jason Wang 2019-10-16 4:38 ` Jason Wang 2019-10-15 16:38 ` Alex Williamson 2019-10-16 4:57 ` Parav Pandit 2019-10-16 4:57 ` Parav Pandit 2019-10-16 4:57 ` Parav Pandit 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-16 10:37 ` Jason Wang 2019-10-17 8:27 ` Jason Wang [this message] 2019-10-17 8:27 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-17 8:27 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 2/7] mdev: bus uevent support Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:27 ` Cornelia Huck 2019-10-15 10:27 ` Cornelia Huck 2019-10-15 12:13 ` Jason Wang 2019-10-15 12:13 ` Jason Wang 2019-10-15 12:13 ` Jason Wang 2019-10-15 10:27 ` Cornelia Huck 2019-10-16 5:06 ` Parav Pandit 2019-10-16 5:06 ` Parav Pandit 2019-10-16 5:06 ` Parav Pandit 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 3/7] modpost: add support for mdev class id Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 4/7] mdev: introduce device specific ops Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-15 10:41 ` Cornelia Huck 2019-10-15 10:41 ` Cornelia Huck 2019-10-15 12:17 ` Jason Wang 2019-10-15 12:17 ` Jason Wang 2019-10-15 12:17 ` Jason Wang 2019-10-15 17:26 ` Alex Williamson 2019-10-15 17:26 ` Alex Williamson 2019-10-15 17:26 ` Alex Williamson 2019-10-16 5:50 ` Parav Pandit 2019-10-16 8:52 ` Cornelia Huck 2019-10-16 15:31 ` Parav Pandit 2019-10-16 16:53 ` Alex Williamson 2019-10-16 20:48 ` Parav Pandit 2019-10-16 22:37 ` Alex Williamson 2019-10-17 16:29 ` Parav Pandit 2019-10-17 8:30 ` Jason Wang 2019-10-17 8:30 ` Jason Wang 2019-10-17 8:45 ` Cornelia Huck 2019-10-17 8:46 ` Jason Wang 2019-10-17 8:46 ` Jason Wang 2019-10-16 16:53 ` Alex Williamson 2019-10-15 10:41 ` Cornelia Huck 2019-10-11 8:15 ` [PATCH V3 5/7] mdev: introduce virtio device and its device ops Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-15 3:27 ` Jason Wang 2019-10-15 3:27 ` Jason Wang 2019-10-15 3:27 ` Jason Wang 2019-10-14 17:23 ` Stefan Hajnoczi 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 6/7] virtio: introduce a mdev based transport Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-14 17:39 ` Stefan Hajnoczi 2019-10-14 17:39 ` Stefan Hajnoczi 2019-10-15 3:29 ` Jason Wang 2019-10-15 3:29 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` [PATCH V3 7/7] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 8:15 ` Jason Wang 2019-10-11 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev4) Patchwork 2019-10-11 10:03 ` ✓ Fi.CI.BAT: success " Patchwork 2019-10-11 17:40 ` ✓ Fi.CI.IGT: " Patchwork 2019-10-14 17:49 ` [PATCH V3 0/7] mdev based hardware virtio offloading support Stefan Hajnoczi 2019-10-14 17:49 ` Stefan Hajnoczi 2019-10-14 17:49 ` Stefan Hajnoczi 2019-10-15 3:37 ` Jason Wang 2019-10-15 3:37 ` Jason Wang 2019-10-15 3:37 ` Jason Wang 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-15 14:37 ` Stefan Hajnoczi 2019-10-17 1:42 ` Jason Wang 2019-10-17 1:42 ` Jason Wang 2019-10-17 1:42 ` Jason Wang 2019-10-17 9:43 ` Stefan Hajnoczi 2019-10-17 9:43 ` Stefan Hajnoczi 2019-10-17 9:43 ` Stefan Hajnoczi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=67b645a6-1b70-094d-6a12-fc6591e07a13@redhat.com \ --to=jasowang@redhat.com \ --cc=airlied@linux.ie \ --cc=akrowiak@linux.ibm.com \ --cc=alex.williamson@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=christophe.de.dinechin@gmail.com \ --cc=cohuck@redhat.com \ --cc=cunming.liang@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=eperezma@redhat.com \ --cc=farman@linux.ibm.com \ --cc=freude@linux.ibm.com \ --cc=gor@linux.ibm.com \ --cc=haotian.wang@sifive.com \ --cc=heiko.carstens@de.ibm.com \ --cc=idos@mellanox.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-gvt-dev@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=kwankhede@nvidia.com \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=oberpar@linux.ibm.com \ --cc=parav@mellanox.com \ --cc=pasic@linux.ibm.com \ --cc=rob.miller@broadcom.com \ --cc=rodrigo.vivi@intel.com \ --cc=sebott@linux.ibm.com \ --cc=tiwei.bie@intel.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ --cc=zhenyuw@linux.intel.com \ --cc=zhi.a.wang@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.