From: Logan Gunthorpe <logang@deltatee.com> To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>, Max Gurtovoy <maxg@mellanox.com>, Stephen Bates <sbates@raithlin.com>, Logan Gunthorpe <logang@deltatee.com> Subject: [PATCH 1/7] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data() Date: Wed, 23 Oct 2019 10:35:39 -0600 [thread overview] Message-ID: <20191023163545.4193-2-logang@deltatee.com> (raw) In-Reply-To: <20191023163545.4193-1-logang@deltatee.com> None of the other transports check data_len which is verified in core code. The function should instead check that the sgl length is non-zero. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> --- drivers/nvme/target/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index d535080b781f..1e2d92f818ad 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -320,7 +320,7 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd) struct nvme_sgl_desc *sgl = &cmd->req.cmd->common.dptr.sgl; u32 len = le32_to_cpu(sgl->length); - if (!cmd->req.data_len) + if (!len) return 0; if (sgl->type == ((NVME_SGL_FMT_DATA_DESC << 4) | -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com> To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Sagi Grimberg <sagi@grimberg.me>, Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>, Stephen Bates <sbates@raithlin.com>, Max Gurtovoy <maxg@mellanox.com>, Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de> Subject: [PATCH 1/7] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data() Date: Wed, 23 Oct 2019 10:35:39 -0600 [thread overview] Message-ID: <20191023163545.4193-2-logang@deltatee.com> (raw) In-Reply-To: <20191023163545.4193-1-logang@deltatee.com> None of the other transports check data_len which is verified in core code. The function should instead check that the sgl length is non-zero. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> --- drivers/nvme/target/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index d535080b781f..1e2d92f818ad 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -320,7 +320,7 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd) struct nvme_sgl_desc *sgl = &cmd->req.cmd->common.dptr.sgl; u32 len = le32_to_cpu(sgl->length); - if (!cmd->req.data_len) + if (!len) return 0; if (sgl->type == ((NVME_SGL_FMT_DATA_DESC << 4) | -- 2.20.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-23 16:36 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-23 16:35 [PATCH 0/7] Remove data_len field from the nvmet_req struct Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe [this message] 2019-10-23 16:35 ` [PATCH 1/7] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data() Logan Gunthorpe 2019-10-24 1:15 ` Christoph Hellwig 2019-10-24 1:15 ` Christoph Hellwig 2019-10-23 16:35 ` [PATCH 2/7] nvmet-tcp: Don't set the request's data_len Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-24 1:15 ` Christoph Hellwig 2019-10-24 1:15 ` Christoph Hellwig 2019-10-23 16:35 ` [PATCH 3/7] nvmet: Introduce common execute function for get_log_page and identify Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 20:31 ` Chaitanya Kulkarni 2019-10-23 20:31 ` Chaitanya Kulkarni 2019-10-24 1:17 ` Christoph Hellwig 2019-10-24 1:17 ` Christoph Hellwig 2019-10-24 17:18 ` Logan Gunthorpe 2019-10-24 17:18 ` Logan Gunthorpe 2019-10-24 22:01 ` Keith Busch 2019-10-24 22:01 ` Keith Busch 2019-10-24 22:40 ` Logan Gunthorpe 2019-10-24 22:40 ` Logan Gunthorpe 2019-10-23 16:35 ` [PATCH 4/7] nvmet: Cleanup discovery execute handlers Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 16:35 ` [PATCH 5/7] nvmet: Introduce nvmet_dsm_len() helper Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 20:31 ` Chaitanya Kulkarni 2019-10-23 20:31 ` Chaitanya Kulkarni 2019-10-23 16:35 ` [PATCH 6/7] nvmet: Remove the data_len field from the nvmet_req struct Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 16:35 ` [PATCH 7/7] nvmet: Open code nvmet_req_execute() Logan Gunthorpe 2019-10-23 16:35 ` Logan Gunthorpe 2019-10-23 20:34 ` Chaitanya Kulkarni 2019-10-23 20:34 ` Chaitanya Kulkarni 2019-10-25 0:20 ` [PATCH 0/7] Remove data_len field from the nvmet_req struct Keith Busch 2019-10-25 0:20 ` Keith Busch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191023163545.4193-2-logang@deltatee.com \ --to=logang@deltatee.com \ --cc=Chaitanya.Kulkarni@wdc.com \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=maxg@mellanox.com \ --cc=sagi@grimberg.me \ --cc=sbates@raithlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.