From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Max Gurtovoy <maxg@mellanox.com>,
Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH 2/7] nvmet-tcp: Don't set the request's data_len
Date: Thu, 24 Oct 2019 03:15:53 +0200 [thread overview]
Message-ID: <20191024011553.GB5190@lst.de> (raw)
In-Reply-To: <20191023163545.4193-3-logang@deltatee.com>
On Wed, Oct 23, 2019 at 10:35:40AM -0600, Logan Gunthorpe wrote:
> It's not apprporiate for the transports to set the data_len
> field of the request which is only used by the core.
>
> In this case, just use a variable on the stack to store the
> length of the sgl for comparison.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Stephen Bates <sbates@raithlin.com>,
Max Gurtovoy <maxg@mellanox.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/7] nvmet-tcp: Don't set the request's data_len
Date: Thu, 24 Oct 2019 03:15:53 +0200 [thread overview]
Message-ID: <20191024011553.GB5190@lst.de> (raw)
In-Reply-To: <20191023163545.4193-3-logang@deltatee.com>
On Wed, Oct 23, 2019 at 10:35:40AM -0600, Logan Gunthorpe wrote:
> It's not apprporiate for the transports to set the data_len
> field of the request which is only used by the core.
>
> In this case, just use a variable on the stack to store the
> length of the sgl for comparison.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-24 1:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:35 [PATCH 0/7] Remove data_len field from the nvmet_req struct Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 1/7] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data() Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-24 1:15 ` Christoph Hellwig
2019-10-24 1:15 ` Christoph Hellwig
2019-10-23 16:35 ` [PATCH 2/7] nvmet-tcp: Don't set the request's data_len Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-24 1:15 ` Christoph Hellwig [this message]
2019-10-24 1:15 ` Christoph Hellwig
2019-10-23 16:35 ` [PATCH 3/7] nvmet: Introduce common execute function for get_log_page and identify Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-24 1:17 ` Christoph Hellwig
2019-10-24 1:17 ` Christoph Hellwig
2019-10-24 17:18 ` Logan Gunthorpe
2019-10-24 17:18 ` Logan Gunthorpe
2019-10-24 22:01 ` Keith Busch
2019-10-24 22:01 ` Keith Busch
2019-10-24 22:40 ` Logan Gunthorpe
2019-10-24 22:40 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 4/7] nvmet: Cleanup discovery execute handlers Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 5/7] nvmet: Introduce nvmet_dsm_len() helper Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 16:35 ` [PATCH 6/7] nvmet: Remove the data_len field from the nvmet_req struct Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 7/7] nvmet: Open code nvmet_req_execute() Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:34 ` Chaitanya Kulkarni
2019-10-23 20:34 ` Chaitanya Kulkarni
2019-10-25 0:20 ` [PATCH 0/7] Remove data_len field from the nvmet_req struct Keith Busch
2019-10-25 0:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024011553.GB5190@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.