All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: "David S . Miller" <davem@davemloft.net>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Robert Hancock <hancock@sedsystems.ca>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/14] net: axienet: Add mii-tool support
Date: Fri, 10 Jan 2020 11:54:10 +0000	[thread overview]
Message-ID: <20200110115415.75683-10-andre.przywara@arm.com> (raw)
In-Reply-To: <20200110115415.75683-1-andre.przywara@arm.com>

mii-tool is useful for debugging, and all it requires to work is to wire
up the ioctl ops function pointer.
Add this to the axienet driver to enable mii-tool.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 7a747345e98e..64f799f3d248 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1152,6 +1152,16 @@ static void axienet_poll_controller(struct net_device *ndev)
 }
 #endif
 
+static int axienet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
+{
+	struct axienet_local *lp = netdev_priv(dev);
+
+	if (!netif_running(dev))
+		return -EINVAL;
+
+	return phylink_mii_ioctl(lp->phylink, rq, cmd);
+}
+
 static const struct net_device_ops axienet_netdev_ops = {
 	.ndo_open = axienet_open,
 	.ndo_stop = axienet_stop,
@@ -1159,6 +1169,7 @@ static const struct net_device_ops axienet_netdev_ops = {
 	.ndo_change_mtu	= axienet_change_mtu,
 	.ndo_set_mac_address = netdev_set_mac_address,
 	.ndo_validate_addr = eth_validate_addr,
+	.ndo_do_ioctl = axienet_ioctl,
 	.ndo_set_rx_mode = axienet_set_multicast_list,
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	.ndo_poll_controller = axienet_poll_controller,
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: "David S . Miller" <davem@davemloft.net>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc: Robert Hancock <hancock@sedsystems.ca>,
	netdev@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/14] net: axienet: Add mii-tool support
Date: Fri, 10 Jan 2020 11:54:10 +0000	[thread overview]
Message-ID: <20200110115415.75683-10-andre.przywara@arm.com> (raw)
In-Reply-To: <20200110115415.75683-1-andre.przywara@arm.com>

mii-tool is useful for debugging, and all it requires to work is to wire
up the ioctl ops function pointer.
Add this to the axienet driver to enable mii-tool.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 7a747345e98e..64f799f3d248 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1152,6 +1152,16 @@ static void axienet_poll_controller(struct net_device *ndev)
 }
 #endif
 
+static int axienet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
+{
+	struct axienet_local *lp = netdev_priv(dev);
+
+	if (!netif_running(dev))
+		return -EINVAL;
+
+	return phylink_mii_ioctl(lp->phylink, rq, cmd);
+}
+
 static const struct net_device_ops axienet_netdev_ops = {
 	.ndo_open = axienet_open,
 	.ndo_stop = axienet_stop,
@@ -1159,6 +1169,7 @@ static const struct net_device_ops axienet_netdev_ops = {
 	.ndo_change_mtu	= axienet_change_mtu,
 	.ndo_set_mac_address = netdev_set_mac_address,
 	.ndo_validate_addr = eth_validate_addr,
+	.ndo_do_ioctl = axienet_ioctl,
 	.ndo_set_rx_mode = axienet_set_multicast_list,
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	.ndo_poll_controller = axienet_poll_controller,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-01-10 11:55 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 11:54 [PATCH 00/14] net: axienet: Error handling, SGMII and 64-bit DMA fixes Andre Przywara
2020-01-10 11:54 ` Andre Przywara
2020-01-10 11:54 ` [PATCH 01/14] net: xilinx: temac: Relax Kconfig dependencies Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 14:19   ` Radhey Shyam Pandey
2020-01-10 14:19     ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 02/14] net: axienet: Propagate failure of DMA descriptor setup Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 14:54   ` Radhey Shyam Pandey
2020-01-10 14:54     ` Radhey Shyam Pandey
2020-01-10 17:53     ` Radhey Shyam Pandey
2020-01-10 17:53       ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 03/14] net: axienet: Fix DMA descriptor cleanup path Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 15:14   ` Radhey Shyam Pandey
2020-01-10 15:14     ` Radhey Shyam Pandey
2020-01-10 15:43     ` Andre Przywara
2020-01-10 15:43       ` Andre Przywara
2020-01-10 17:05       ` Radhey Shyam Pandey
2020-01-10 17:05         ` Radhey Shyam Pandey
2020-01-16 18:03         ` Andre Przywara
2020-01-16 18:03           ` Andre Przywara
2020-01-20 18:32           ` Radhey Shyam Pandey
2020-01-20 18:32             ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 04/14] net: axienet: Improve DMA error handling Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 15:26   ` Radhey Shyam Pandey
2020-01-10 15:26     ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 05/14] net: axienet: Factor out TX descriptor chain cleanup Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 18:04   ` Radhey Shyam Pandey
2020-01-10 18:04     ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 06/14] net: axienet: Check for DMA mapping errors Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-13  5:54   ` Radhey Shyam Pandey
2020-01-13  5:54     ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 07/14] net: axienet: Fix SGMII support Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 14:04   ` Andrew Lunn
2020-01-10 14:04     ` Andrew Lunn
2020-01-10 14:20     ` Andre Przywara
2020-01-10 14:20       ` Andre Przywara
2020-01-10 14:26       ` Andrew Lunn
2020-01-10 14:26         ` Andrew Lunn
2020-01-10 15:04       ` Russell King - ARM Linux admin
2020-01-10 15:04         ` Russell King - ARM Linux admin
2020-01-10 15:22         ` Russell King - ARM Linux admin
2020-01-10 15:22           ` Russell King - ARM Linux admin
2020-01-10 17:04           ` Russell King - ARM Linux admin
2020-01-10 17:04             ` Russell King - ARM Linux admin
2020-01-18 11:22             ` Russell King - ARM Linux admin
2020-01-18 11:22               ` Russell King - ARM Linux admin
2020-01-20 14:50               ` Andre Przywara
2020-01-20 14:50                 ` Andre Przywara
2020-01-20 15:45                 ` Russell King - ARM Linux admin
2020-01-20 15:45                   ` Russell King - ARM Linux admin
2020-01-27 17:04                   ` Andre Przywara
2020-01-27 17:04                     ` Andre Przywara
2020-01-27 17:20                     ` Radhey Shyam Pandey
2020-01-27 17:20                       ` Radhey Shyam Pandey
2020-01-27 18:53                     ` Russell King - ARM Linux admin
2020-01-27 18:53                       ` Russell King - ARM Linux admin
2020-04-22  1:45                       ` Xilinx axienet 1000BaseX support (was: Re: [PATCH 07/14] net: axienet: Fix SGMII support) Robert Hancock
2020-04-22  1:45                         ` Robert Hancock
2020-04-22  7:51                         ` Russell King - ARM Linux admin
2020-04-22  7:51                           ` Russell King - ARM Linux admin
2020-04-22 16:31                           ` Xilinx axienet 1000BaseX support Robert Hancock
2020-04-22 16:31                             ` Robert Hancock
2020-04-28 21:59                           ` Robert Hancock
2020-04-28 21:59                             ` Robert Hancock
2020-04-28 23:01                             ` Russell King - ARM Linux admin
2020-04-28 23:01                               ` Russell King - ARM Linux admin
2020-04-28 23:51                               ` Robert Hancock
2020-04-28 23:51                                 ` Robert Hancock
2020-04-29  8:21                                 ` Russell King - ARM Linux admin
2020-04-29  8:21                                   ` Russell King - ARM Linux admin
2020-01-10 14:58   ` [PATCH 07/14] net: axienet: Fix SGMII support Russell King - ARM Linux admin
2020-01-10 14:58     ` Russell King - ARM Linux admin
2020-01-10 17:32     ` Andre Przywara
2020-01-10 17:32       ` Andre Przywara
2020-01-10 18:05       ` Russell King - ARM Linux admin
2020-01-10 18:05         ` Russell King - ARM Linux admin
2020-01-10 19:33         ` Andrew Lunn
2020-01-10 19:33           ` Andrew Lunn
2020-01-10 11:54 ` [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from ethtools dump Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-13  6:02   ` Radhey Shyam Pandey
2020-01-13  6:02     ` Radhey Shyam Pandey
2020-01-10 11:54 ` Andre Przywara [this message]
2020-01-10 11:54   ` [PATCH 09/14] net: axienet: Add mii-tool support Andre Przywara
2020-01-13  6:12   ` Radhey Shyam Pandey
2020-01-13  6:12     ` Radhey Shyam Pandey
2020-03-12 11:41     ` Andre Przywara
2020-03-12 11:41       ` Andre Przywara
2020-01-10 11:54 ` [PATCH 10/14] net: axienet: Wrap DMA pointer writes to prepare for 64 bit Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 11:54 ` [PATCH 11/14] net: axienet: Upgrade descriptors to hold 64-bit addresses Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-14 16:35   ` Radhey Shyam Pandey
2020-01-14 16:35     ` Radhey Shyam Pandey
2020-01-14 17:29     ` Andre Przywara
2020-01-14 17:29       ` Andre Przywara
2020-01-10 11:54 ` [PATCH 12/14] net: axienet: Autodetect 64-bit DMA capability Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 14:08   ` Andrew Lunn
2020-01-10 14:08     ` Andrew Lunn
2020-01-10 14:13     ` Andre Przywara
2020-01-10 14:13       ` Andre Przywara
2020-01-10 14:22       ` Andrew Lunn
2020-01-10 14:22         ` Andrew Lunn
2020-01-10 15:08         ` Andre Przywara
2020-01-10 15:08           ` Andre Przywara
2020-01-10 15:22           ` Andrew Lunn
2020-01-10 15:22             ` Andrew Lunn
2020-01-14 17:03   ` Radhey Shyam Pandey
2020-01-14 17:03     ` Radhey Shyam Pandey
2020-01-14 17:41     ` Andre Przywara
2020-01-14 17:41       ` Andre Przywara
2020-01-15  6:02       ` Radhey Shyam Pandey
2020-01-15  6:02         ` Radhey Shyam Pandey
2020-01-10 11:54 ` [PATCH 13/14] net: axienet: Allow DMA to beyond 4GB Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-10 11:54 ` [PATCH 14/14] net: axienet: Update devicetree binding documentation Andre Przywara
2020-01-10 11:54   ` Andre Przywara
2020-01-21 21:51   ` Rob Herring
2020-01-21 21:51     ` Rob Herring
2020-01-24 16:29     ` Andre Przywara
2020-01-24 16:29       ` Andre Przywara
2020-01-27  9:28       ` Radhey Shyam Pandey
2020-01-27  9:28         ` Radhey Shyam Pandey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110115415.75683-10-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=davem@davemloft.net \
    --cc=hancock@sedsystems.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=radhey.shyam.pandey@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.