From: Krzysztof Kozlowski <krzk@kernel.org> To: Nicolin Chen <nicoleotsuka@gmail.com> Cc: thierry.reding@gmail.com, joro@8bytes.org, digetx@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller() Date: Wed, 30 Sep 2020 12:27:15 +0200 [thread overview] Message-ID: <20200930102715.GB1147@pi3> (raw) In-Reply-To: <20200930094145.GB6686@Asurada-Nvidia> On Wed, Sep 30, 2020 at 02:41:45AM -0700, Nicolin Chen wrote: > On Wed, Sep 30, 2020 at 11:07:32AM +0200, Krzysztof Kozlowski wrote: > > "On Wed, 30 Sep 2020 at 10:48, Nicolin Chen <nicoleotsuka@gmail.com> wrote: > > > > > > From: Dmitry Osipenko <digetx@gmail.com> > > > > > > Multiple Tegra drivers need to retrieve Memory Controller and hence there > > > is quite some duplication of the retrieval code among the drivers. Let's > > > add a new common helper for the retrieval of the MC. > > > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > > --- > > > > > > Changelog > > > v2->v3: > > > * Replaced with Dimtry's devm_tegra_get_memory_controller() > > > v1->v2: > > > * N/A > > > > > > drivers/memory/tegra/mc.c | 39 +++++++++++++++++++++++++++++++++++++++ > > > include/soc/tegra/mc.h | 17 +++++++++++++++++ > > > 2 files changed, 56 insertions(+) > > > > > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > > > index ec8403557ed4..dd691dc3738e 100644 > > > --- a/drivers/memory/tegra/mc.c > > > +++ b/drivers/memory/tegra/mc.c > > > @@ -42,6 +42,45 @@ static const struct of_device_id tegra_mc_of_match[] = { > > > }; > > > MODULE_DEVICE_TABLE(of, tegra_mc_of_match); > > > > > > +static void tegra_mc_devm_action_put_device(void *data) > > > > devm_tegra_memory_controller_put() My bad here, this is not a "put" helper so the previous name was actually good. No need to change. > > > > > +{ > > > + struct tegra_mc *mc = data; > > > + > > > + put_device(mc->dev); > > > +} > > > + > > > +struct tegra_mc *devm_tegra_get_memory_controller(struct device *dev) > > > > Usually 'get' is a suffix (e.g. clk, gpiod, iio, led), so: > > devm_tegra_memory_controller_get() > > > > > +{ > > > + struct platform_device *pdev; > > > + struct device_node *np; > > > + struct tegra_mc *mc; > > > + int err; > > > + > > > + np = of_find_matching_node_and_match(NULL, tegra_mc_of_match, NULL); > > > + if (!np) > > > + return ERR_PTR(-ENOENT); > > > + > > > + pdev = of_find_device_by_node(np); > > > + of_node_put(np); > > > + if (!pdev) > > > + return ERR_PTR(-ENODEV); > > > + > > > + mc = platform_get_drvdata(pdev); > > > + if (!mc) { > > > + put_device(mc->dev); > > > + return ERR_PTR(-EPROBE_DEFER); > > > + } > > > + > > > + err = devm_add_action(dev, tegra_mc_devm_action_put_device, mc); This can be simpler with devm_add_action_or_reset. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Nicolin Chen <nicoleotsuka@gmail.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, iommu@lists.linux-foundation.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, digetx@gmail.com Subject: Re: [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller() Date: Wed, 30 Sep 2020 12:27:15 +0200 [thread overview] Message-ID: <20200930102715.GB1147@pi3> (raw) In-Reply-To: <20200930094145.GB6686@Asurada-Nvidia> On Wed, Sep 30, 2020 at 02:41:45AM -0700, Nicolin Chen wrote: > On Wed, Sep 30, 2020 at 11:07:32AM +0200, Krzysztof Kozlowski wrote: > > "On Wed, 30 Sep 2020 at 10:48, Nicolin Chen <nicoleotsuka@gmail.com> wrote: > > > > > > From: Dmitry Osipenko <digetx@gmail.com> > > > > > > Multiple Tegra drivers need to retrieve Memory Controller and hence there > > > is quite some duplication of the retrieval code among the drivers. Let's > > > add a new common helper for the retrieval of the MC. > > > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > > --- > > > > > > Changelog > > > v2->v3: > > > * Replaced with Dimtry's devm_tegra_get_memory_controller() > > > v1->v2: > > > * N/A > > > > > > drivers/memory/tegra/mc.c | 39 +++++++++++++++++++++++++++++++++++++++ > > > include/soc/tegra/mc.h | 17 +++++++++++++++++ > > > 2 files changed, 56 insertions(+) > > > > > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > > > index ec8403557ed4..dd691dc3738e 100644 > > > --- a/drivers/memory/tegra/mc.c > > > +++ b/drivers/memory/tegra/mc.c > > > @@ -42,6 +42,45 @@ static const struct of_device_id tegra_mc_of_match[] = { > > > }; > > > MODULE_DEVICE_TABLE(of, tegra_mc_of_match); > > > > > > +static void tegra_mc_devm_action_put_device(void *data) > > > > devm_tegra_memory_controller_put() My bad here, this is not a "put" helper so the previous name was actually good. No need to change. > > > > > +{ > > > + struct tegra_mc *mc = data; > > > + > > > + put_device(mc->dev); > > > +} > > > + > > > +struct tegra_mc *devm_tegra_get_memory_controller(struct device *dev) > > > > Usually 'get' is a suffix (e.g. clk, gpiod, iio, led), so: > > devm_tegra_memory_controller_get() > > > > > +{ > > > + struct platform_device *pdev; > > > + struct device_node *np; > > > + struct tegra_mc *mc; > > > + int err; > > > + > > > + np = of_find_matching_node_and_match(NULL, tegra_mc_of_match, NULL); > > > + if (!np) > > > + return ERR_PTR(-ENOENT); > > > + > > > + pdev = of_find_device_by_node(np); > > > + of_node_put(np); > > > + if (!pdev) > > > + return ERR_PTR(-ENODEV); > > > + > > > + mc = platform_get_drvdata(pdev); > > > + if (!mc) { > > > + put_device(mc->dev); > > > + return ERR_PTR(-EPROBE_DEFER); > > > + } > > > + > > > + err = devm_add_action(dev, tegra_mc_devm_action_put_device, mc); This can be simpler with devm_add_action_or_reset. Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-30 10:27 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 8:42 [PATCH v3 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen 2020-09-30 8:42 ` Nicolin Chen 2020-09-30 8:42 ` [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller() Nicolin Chen 2020-09-30 8:42 ` Nicolin Chen 2020-09-30 9:07 ` Krzysztof Kozlowski 2020-09-30 9:07 ` Krzysztof Kozlowski 2020-09-30 9:41 ` Nicolin Chen 2020-09-30 9:41 ` Nicolin Chen 2020-09-30 10:27 ` Krzysztof Kozlowski [this message] 2020-09-30 10:27 ` Krzysztof Kozlowski 2020-09-30 14:41 ` Dmitry Osipenko 2020-09-30 14:41 ` Dmitry Osipenko 2020-09-30 14:45 ` Krzysztof Kozlowski 2020-09-30 14:45 ` Krzysztof Kozlowski 2020-09-30 15:22 ` Dmitry Osipenko 2020-09-30 15:22 ` Dmitry Osipenko 2020-09-30 15:23 ` Thierry Reding 2020-09-30 15:23 ` Thierry Reding 2020-09-30 15:27 ` Dmitry Osipenko 2020-09-30 15:27 ` Dmitry Osipenko 2020-09-30 15:53 ` Dmitry Osipenko 2020-09-30 15:53 ` Dmitry Osipenko 2020-09-30 16:03 ` Thierry Reding 2020-09-30 16:03 ` Thierry Reding 2020-09-30 16:06 ` Dmitry Osipenko 2020-09-30 16:06 ` Dmitry Osipenko 2020-09-30 16:15 ` Thierry Reding 2020-09-30 16:15 ` Thierry Reding 2020-09-30 16:26 ` Dmitry Osipenko 2020-09-30 16:26 ` Dmitry Osipenko 2020-09-30 16:38 ` Thierry Reding 2020-09-30 16:38 ` Thierry Reding 2020-09-30 17:32 ` Dmitry Osipenko 2020-09-30 17:32 ` Dmitry Osipenko 2020-09-30 8:42 ` [PATCH v3 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Nicolin Chen 2020-09-30 8:42 ` Nicolin Chen 2020-09-30 9:21 ` Krzysztof Kozlowski 2020-09-30 9:21 ` Krzysztof Kozlowski 2020-09-30 9:40 ` Nicolin Chen 2020-09-30 9:40 ` Nicolin Chen 2020-09-30 10:19 ` Krzysztof Kozlowski 2020-09-30 10:19 ` Krzysztof Kozlowski 2020-09-30 14:41 ` Dmitry Osipenko 2020-09-30 14:41 ` Dmitry Osipenko 2020-09-30 15:09 ` Dmitry Osipenko 2020-09-30 15:09 ` Dmitry Osipenko 2020-09-30 20:51 ` Nicolin Chen 2020-09-30 20:51 ` Nicolin Chen 2020-09-30 15:31 ` Thierry Reding 2020-09-30 15:31 ` Thierry Reding 2020-09-30 15:36 ` Dmitry Osipenko 2020-09-30 15:36 ` Dmitry Osipenko 2020-09-30 16:06 ` Thierry Reding 2020-09-30 16:06 ` Thierry Reding 2020-09-30 16:25 ` Dmitry Osipenko 2020-09-30 16:25 ` Dmitry Osipenko 2020-09-30 16:47 ` Thierry Reding 2020-09-30 16:47 ` Thierry Reding 2020-10-01 2:11 ` Dmitry Osipenko 2020-10-01 2:11 ` Dmitry Osipenko 2020-10-01 7:58 ` Thierry Reding 2020-10-01 7:58 ` Thierry Reding 2020-10-01 19:04 ` Dmitry Osipenko 2020-10-01 19:04 ` Dmitry Osipenko 2020-10-05 9:16 ` Thierry Reding 2020-10-05 9:16 ` Thierry Reding 2020-10-05 9:38 ` Dmitry Osipenko 2020-10-05 9:38 ` Dmitry Osipenko 2020-10-05 10:27 ` Thierry Reding 2020-10-05 10:27 ` Thierry Reding 2020-09-30 16:10 ` Thierry Reding 2020-09-30 16:10 ` Thierry Reding 2020-09-30 16:29 ` Dmitry Osipenko 2020-09-30 16:29 ` Dmitry Osipenko 2020-10-01 7:59 ` Thierry Reding 2020-10-01 7:59 ` Thierry Reding 2020-09-30 20:36 ` Nicolin Chen 2020-09-30 20:36 ` Nicolin Chen 2020-09-30 21:24 ` Dmitry Osipenko 2020-09-30 21:24 ` Dmitry Osipenko 2020-09-30 21:32 ` Nicolin Chen 2020-09-30 21:32 ` Nicolin Chen 2020-09-30 21:56 ` Dmitry Osipenko 2020-09-30 21:56 ` Dmitry Osipenko 2020-10-01 1:26 ` Nicolin Chen 2020-10-01 1:26 ` Nicolin Chen 2020-10-01 2:06 ` Dmitry Osipenko 2020-10-01 2:06 ` Dmitry Osipenko 2020-10-01 2:48 ` Nicolin Chen 2020-10-01 2:48 ` Nicolin Chen 2020-10-01 4:04 ` Dmitry Osipenko 2020-10-01 4:04 ` Dmitry Osipenko 2020-10-01 10:23 ` Thierry Reding 2020-10-01 10:23 ` Thierry Reding 2020-10-01 11:04 ` Nicolin Chen 2020-10-01 11:04 ` Nicolin Chen 2020-10-01 20:33 ` Dmitry Osipenko 2020-10-01 20:33 ` Dmitry Osipenko 2020-10-02 1:07 ` Nicolin Chen 2020-10-02 1:07 ` Nicolin Chen 2020-10-02 1:55 ` Dmitry Osipenko 2020-10-02 1:55 ` Dmitry Osipenko 2020-10-02 2:54 ` Nicolin Chen 2020-10-02 2:54 ` Nicolin Chen 2020-10-05 7:24 ` Thierry Reding 2020-10-05 7:24 ` Thierry Reding 2020-10-05 7:13 ` Thierry Reding 2020-10-05 7:13 ` Thierry Reding 2020-10-05 8:14 ` Dmitry Osipenko 2020-10-05 8:14 ` Dmitry Osipenko 2020-10-05 9:31 ` Thierry Reding 2020-10-05 9:31 ` Thierry Reding 2020-10-01 9:54 ` Thierry Reding 2020-10-01 9:54 ` Thierry Reding 2020-10-01 9:51 ` Thierry Reding 2020-10-01 9:51 ` Thierry Reding 2020-10-01 10:33 ` Nicolin Chen 2020-10-01 10:33 ` Nicolin Chen 2020-10-01 10:42 ` Thierry Reding 2020-10-01 10:42 ` Thierry Reding 2020-10-01 9:47 ` Thierry Reding 2020-10-01 9:47 ` Thierry Reding 2020-10-01 10:46 ` Thierry Reding 2020-10-01 10:46 ` Thierry Reding 2020-10-02 1:29 ` Nicolin Chen 2020-10-02 1:29 ` Nicolin Chen 2020-09-30 8:42 ` [PATCH v3 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen 2020-09-30 8:42 ` Nicolin Chen 2020-09-30 14:53 ` Dmitry Osipenko 2020-09-30 14:53 ` Dmitry Osipenko 2020-09-30 20:03 ` Nicolin Chen 2020-09-30 20:03 ` Nicolin Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200930102715.GB1147@pi3 \ --to=krzk@kernel.org \ --cc=digetx@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jonathanh@nvidia.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=nicoleotsuka@gmail.com \ --cc=thierry.reding@gmail.com \ --cc=vdumpa@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.