From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [net-next PATCH v5 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Date: Tue, 09 Feb 2021 11:41:24 +0300 [thread overview]
Message-ID: <20210209084124.GL2696@kadam> (raw)
In-Reply-To: <20210208151244.16338-8-calvin.johnson@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3474 bytes --]
Hi Calvin,
url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-dpaa2-driver/20210209-084334
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/phy/mdio_bus.c:134 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
Old smatch warnings:
drivers/net/phy/mdio_bus.c:157 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
drivers/net/phy/mdio_bus.c:167 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
vim +/mii_ts +134 drivers/net/phy/mdio_bus.c
36305d64c94998 Calvin Johnson 2021-02-08 110 int fwnode_mdiobus_register_phy(struct mii_bus *bus,
36305d64c94998 Calvin Johnson 2021-02-08 111 struct fwnode_handle *child, u32 addr)
36305d64c94998 Calvin Johnson 2021-02-08 112 {
36305d64c94998 Calvin Johnson 2021-02-08 113 struct mii_timestamper *mii_ts;
36305d64c94998 Calvin Johnson 2021-02-08 114 struct phy_device *phy;
36305d64c94998 Calvin Johnson 2021-02-08 115 bool is_c45 = false;
36305d64c94998 Calvin Johnson 2021-02-08 116 u32 phy_id;
36305d64c94998 Calvin Johnson 2021-02-08 117 int rc;
36305d64c94998 Calvin Johnson 2021-02-08 118
36305d64c94998 Calvin Johnson 2021-02-08 119 if (is_of_node(child)) {
36305d64c94998 Calvin Johnson 2021-02-08 120 mii_ts = of_find_mii_timestamper(to_of_node(child));
36305d64c94998 Calvin Johnson 2021-02-08 121 if (IS_ERR(mii_ts))
36305d64c94998 Calvin Johnson 2021-02-08 122 return PTR_ERR(mii_ts);
36305d64c94998 Calvin Johnson 2021-02-08 123 }
"mii_ts" is not initialized on the else path.
36305d64c94998 Calvin Johnson 2021-02-08 124
36305d64c94998 Calvin Johnson 2021-02-08 125 rc = fwnode_property_match_string(child, "compatible", "ethernet-phy-ieee802.3-c45");
36305d64c94998 Calvin Johnson 2021-02-08 126 if (rc >= 0)
36305d64c94998 Calvin Johnson 2021-02-08 127 is_c45 = true;
36305d64c94998 Calvin Johnson 2021-02-08 128
36305d64c94998 Calvin Johnson 2021-02-08 129 if (is_c45 || fwnode_get_phy_id(child, &phy_id))
36305d64c94998 Calvin Johnson 2021-02-08 130 phy = get_phy_device(bus, addr, is_c45);
36305d64c94998 Calvin Johnson 2021-02-08 131 else
36305d64c94998 Calvin Johnson 2021-02-08 132 phy = phy_device_create(bus, addr, phy_id, 0, NULL);
36305d64c94998 Calvin Johnson 2021-02-08 133 if (IS_ERR(phy)) {
36305d64c94998 Calvin Johnson 2021-02-08 @134 if (mii_ts && is_of_node(child))
^^^^^^
36305d64c94998 Calvin Johnson 2021-02-08 135 unregister_mii_timestamper(mii_ts);
36305d64c94998 Calvin Johnson 2021-02-08 136 return PTR_ERR(phy);
36305d64c94998 Calvin Johnson 2021-02-08 137 }
36305d64c94998 Calvin Johnson 2021-02-08 138
36305d64c94998 Calvin Johnson 2021-02-08 139 if (is_acpi_node(child)) {
36305d64c94998 Calvin Johnson 2021-02-08 140 phy->irq = bus->irq[addr];
36305d64c94998 Calvin Johnson 2021-02-08 141
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37161 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [net-next PATCH v5 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Date: Tue, 09 Feb 2021 11:41:24 +0300 [thread overview]
Message-ID: <20210209084124.GL2696@kadam> (raw)
In-Reply-To: <20210208151244.16338-8-calvin.johnson@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3474 bytes --]
Hi Calvin,
url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-dpaa2-driver/20210209-084334
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/phy/mdio_bus.c:134 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
Old smatch warnings:
drivers/net/phy/mdio_bus.c:157 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
drivers/net/phy/mdio_bus.c:167 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'.
vim +/mii_ts +134 drivers/net/phy/mdio_bus.c
36305d64c94998 Calvin Johnson 2021-02-08 110 int fwnode_mdiobus_register_phy(struct mii_bus *bus,
36305d64c94998 Calvin Johnson 2021-02-08 111 struct fwnode_handle *child, u32 addr)
36305d64c94998 Calvin Johnson 2021-02-08 112 {
36305d64c94998 Calvin Johnson 2021-02-08 113 struct mii_timestamper *mii_ts;
36305d64c94998 Calvin Johnson 2021-02-08 114 struct phy_device *phy;
36305d64c94998 Calvin Johnson 2021-02-08 115 bool is_c45 = false;
36305d64c94998 Calvin Johnson 2021-02-08 116 u32 phy_id;
36305d64c94998 Calvin Johnson 2021-02-08 117 int rc;
36305d64c94998 Calvin Johnson 2021-02-08 118
36305d64c94998 Calvin Johnson 2021-02-08 119 if (is_of_node(child)) {
36305d64c94998 Calvin Johnson 2021-02-08 120 mii_ts = of_find_mii_timestamper(to_of_node(child));
36305d64c94998 Calvin Johnson 2021-02-08 121 if (IS_ERR(mii_ts))
36305d64c94998 Calvin Johnson 2021-02-08 122 return PTR_ERR(mii_ts);
36305d64c94998 Calvin Johnson 2021-02-08 123 }
"mii_ts" is not initialized on the else path.
36305d64c94998 Calvin Johnson 2021-02-08 124
36305d64c94998 Calvin Johnson 2021-02-08 125 rc = fwnode_property_match_string(child, "compatible", "ethernet-phy-ieee802.3-c45");
36305d64c94998 Calvin Johnson 2021-02-08 126 if (rc >= 0)
36305d64c94998 Calvin Johnson 2021-02-08 127 is_c45 = true;
36305d64c94998 Calvin Johnson 2021-02-08 128
36305d64c94998 Calvin Johnson 2021-02-08 129 if (is_c45 || fwnode_get_phy_id(child, &phy_id))
36305d64c94998 Calvin Johnson 2021-02-08 130 phy = get_phy_device(bus, addr, is_c45);
36305d64c94998 Calvin Johnson 2021-02-08 131 else
36305d64c94998 Calvin Johnson 2021-02-08 132 phy = phy_device_create(bus, addr, phy_id, 0, NULL);
36305d64c94998 Calvin Johnson 2021-02-08 133 if (IS_ERR(phy)) {
36305d64c94998 Calvin Johnson 2021-02-08 @134 if (mii_ts && is_of_node(child))
^^^^^^
36305d64c94998 Calvin Johnson 2021-02-08 135 unregister_mii_timestamper(mii_ts);
36305d64c94998 Calvin Johnson 2021-02-08 136 return PTR_ERR(phy);
36305d64c94998 Calvin Johnson 2021-02-08 137 }
36305d64c94998 Calvin Johnson 2021-02-08 138
36305d64c94998 Calvin Johnson 2021-02-08 139 if (is_acpi_node(child)) {
36305d64c94998 Calvin Johnson 2021-02-08 140 phy->irq = bus->irq[addr];
36305d64c94998 Calvin Johnson 2021-02-08 141
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37161 bytes --]
next prev parent reply other threads:[~2021-02-09 8:41 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 15:12 [net-next PATCH v5 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 20:01 ` Randy Dunlap
2021-02-08 20:01 ` Randy Dunlap
2021-02-09 14:34 ` Calvin Johnson
2021-02-09 14:34 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 17:40 ` Russell King - ARM Linux admin
2021-02-08 17:40 ` Russell King - ARM Linux admin
2021-02-09 15:04 ` Calvin Johnson
2021-02-09 15:04 ` Calvin Johnson
2021-02-09 8:41 ` Dan Carpenter [this message]
2021-02-09 8:41 ` Dan Carpenter
2021-02-08 15:12 ` [net-next PATCH v5 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 09/15] ACPI: utils: Introduce acpi_get_local_address() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 16:16 ` Andy Shevchenko
2021-02-08 16:16 ` Andy Shevchenko
2021-02-08 15:12 ` [net-next PATCH v5 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:31 ` Russell King - ARM Linux admin
2021-02-08 15:31 ` Russell King - ARM Linux admin
2021-02-15 5:55 ` Calvin Johnson
2021-02-15 5:55 ` Calvin Johnson
2021-02-15 6:01 ` Calvin Johnson
2021-02-15 6:01 ` Calvin Johnson
2021-02-08 16:20 ` Russell King - ARM Linux admin
2021-02-08 16:20 ` Russell King - ARM Linux admin
2021-02-08 15:12 ` [net-next PATCH v5 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 15:12 ` [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2021-02-08 15:12 ` Calvin Johnson
2021-02-08 16:21 ` Andy Shevchenko
2021-02-08 16:21 ` Andy Shevchenko
2021-02-08 16:28 ` Russell King - ARM Linux admin
2021-02-08 16:28 ` Russell King - ARM Linux admin
2021-02-15 12:33 ` Calvin Johnson
2021-02-15 12:33 ` Calvin Johnson
2021-02-15 15:13 ` Andy Shevchenko
2021-02-15 15:13 ` Andy Shevchenko
2021-02-15 15:15 ` Andy Shevchenko
2021-02-15 15:15 ` Andy Shevchenko
2021-02-16 9:59 ` Calvin Johnson
2021-02-16 9:59 ` Calvin Johnson
2021-02-09 8:33 [net-next PATCH v5 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209084124.GL2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.