From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Calvin Johnson <calvin.johnson@oss.nxp.com> Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>, Grant Likely <grant.likely@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Madalin Bucur <madalin.bucur@oss.nxp.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>, Randy Dunlap <rdunlap@infradead.org>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux.cj" <linux.cj@gmail.com>, Diana Madalina Craciun <diana.craciun@nxp.com>, netdev <netdev@vger.kernel.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Ioana Radulescu <ruxandra.radulescu@nxp.com>, Jakub Kicinski <kuba@kernel.org> Subject: Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Date: Mon, 15 Feb 2021 17:13:44 +0200 [thread overview] Message-ID: <CAHp75VcpR1uf-6me9-MiXzESP9gtE0=Oz5TaFj0E93C3w4=Fgg@mail.gmail.com> (raw) In-Reply-To: <20210215123309.GA5067@lsv03152.swis.in-blr01.nxp.com> On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson <calvin.johnson@oss.nxp.com> wrote: > On Mon, Feb 08, 2021 at 04:28:31PM +0000, Russell King - ARM Linux admin wrote: ... > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > --- a/drivers/net/mdio/of_mdio.c > +++ b/drivers/net/mdio/of_mdio.c > @@ -439,6 +439,9 @@ bool of_phy_is_fixed_link(struct device_node *np) > int len, err; > const char *managed; > > + if (!np) > + return false; AFAICS this doesn't add anything: all of the of_* APIs should handle OF nodes being NULL below. > /* New binding */ > dn = of_get_child_by_name(np, "fixed-link"); > if (dn) { -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Calvin Johnson <calvin.johnson@oss.nxp.com> Cc: Andrew Lunn <andrew@lunn.ch>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Grant Likely <grant.likely@arm.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Florian Fainelli <f.fainelli@gmail.com>, Saravana Kannan <saravanak@google.com>, Jon <jon@solid-run.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Diana Madalina Craciun <diana.craciun@nxp.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@oss.nxp.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Marcin Wojtas <mw@semihalf.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Ioana Radulescu <ruxandra.radulescu@nxp.com>, netdev <netdev@vger.kernel.org>, Randy Dunlap <rdunlap@infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, "linux.cj" <linux.cj@gmail.com>, "David S. Miller" <davem@davemloft.net> Subject: Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Date: Mon, 15 Feb 2021 17:13:44 +0200 [thread overview] Message-ID: <CAHp75VcpR1uf-6me9-MiXzESP9gtE0=Oz5TaFj0E93C3w4=Fgg@mail.gmail.com> (raw) In-Reply-To: <20210215123309.GA5067@lsv03152.swis.in-blr01.nxp.com> On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson <calvin.johnson@oss.nxp.com> wrote: > On Mon, Feb 08, 2021 at 04:28:31PM +0000, Russell King - ARM Linux admin wrote: ... > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > --- a/drivers/net/mdio/of_mdio.c > +++ b/drivers/net/mdio/of_mdio.c > @@ -439,6 +439,9 @@ bool of_phy_is_fixed_link(struct device_node *np) > int len, err; > const char *managed; > > + if (!np) > + return false; AFAICS this doesn't add anything: all of the of_* APIs should handle OF nodes being NULL below. > /* New binding */ > dn = of_get_child_by_name(np, "fixed-link"); > if (dn) { -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-15 15:15 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-08 15:12 [net-next PATCH v5 00/15] ACPI support for dpaa2 driver Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 20:01 ` Randy Dunlap 2021-02-08 20:01 ` Randy Dunlap 2021-02-09 14:34 ` Calvin Johnson 2021-02-09 14:34 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 17:40 ` Russell King - ARM Linux admin 2021-02-08 17:40 ` Russell King - ARM Linux admin 2021-02-09 15:04 ` Calvin Johnson 2021-02-09 15:04 ` Calvin Johnson 2021-02-09 8:41 ` Dan Carpenter 2021-02-09 8:41 ` Dan Carpenter 2021-02-08 15:12 ` [net-next PATCH v5 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 09/15] ACPI: utils: Introduce acpi_get_local_address() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 16:16 ` Andy Shevchenko 2021-02-08 16:16 ` Andy Shevchenko 2021-02-08 15:12 ` [net-next PATCH v5 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:31 ` Russell King - ARM Linux admin 2021-02-08 15:31 ` Russell King - ARM Linux admin 2021-02-15 5:55 ` Calvin Johnson 2021-02-15 5:55 ` Calvin Johnson 2021-02-15 6:01 ` Calvin Johnson 2021-02-15 6:01 ` Calvin Johnson 2021-02-08 16:20 ` Russell King - ARM Linux admin 2021-02-08 16:20 ` Russell King - ARM Linux admin 2021-02-08 15:12 ` [net-next PATCH v5 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 15:12 ` [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson 2021-02-08 15:12 ` Calvin Johnson 2021-02-08 16:21 ` Andy Shevchenko 2021-02-08 16:21 ` Andy Shevchenko 2021-02-08 16:28 ` Russell King - ARM Linux admin 2021-02-08 16:28 ` Russell King - ARM Linux admin 2021-02-15 12:33 ` Calvin Johnson 2021-02-15 12:33 ` Calvin Johnson 2021-02-15 15:13 ` Andy Shevchenko [this message] 2021-02-15 15:13 ` Andy Shevchenko 2021-02-15 15:15 ` Andy Shevchenko 2021-02-15 15:15 ` Andy Shevchenko 2021-02-16 9:59 ` Calvin Johnson 2021-02-16 9:59 ` Calvin Johnson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75VcpR1uf-6me9-MiXzESP9gtE0=Oz5TaFj0E93C3w4=Fgg@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=andrew@lunn.ch \ --cc=calvin.johnson@oss.nxp.com \ --cc=cristian.sovaiala@nxp.com \ --cc=davem@davemloft.net \ --cc=diana.craciun@nxp.com \ --cc=f.fainelli@gmail.com \ --cc=florinlaurentiu.chiculita@nxp.com \ --cc=grant.likely@arm.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=ioana.ciornei@nxp.com \ --cc=jeremy.linton@arm.com \ --cc=jon@solid-run.com \ --cc=kuba@kernel.org \ --cc=laurentiu.tudor@nxp.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux.cj@gmail.com \ --cc=linux@armlinux.org.uk \ --cc=madalin.bucur@oss.nxp.com \ --cc=mw@semihalf.com \ --cc=netdev@vger.kernel.org \ --cc=pieter.jansenvv@bamboosystems.io \ --cc=rafael@kernel.org \ --cc=rdunlap@infradead.org \ --cc=ruxandra.radulescu@nxp.com \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.