* [PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support @ 2021-02-12 15:12 Maxime Chevallier 2021-02-12 15:12 ` [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 Maxime Chevallier 2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier 0 siblings, 2 replies; 9+ messages in thread From: Maxime Chevallier @ 2021-02-12 15:12 UTC (permalink / raw) To: davem Cc: Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni, gregory.clement Hi everyone, This small series adds basic support for mqprio offloading, by having the rx queueing mirroring the TCs based on VLAN prio fields. This was tested on Armada 3700, and proves useful to make sure high-priority traffic has a better chance not getting dropped when there's lots of packets incoming. The first patch of the series deals with the per-cpu interrupts on the armada 3700. Since they don't work, there were already some patches applied to keep all queue mappings to CPU0, but there still were some remaining mappings left to be dealt with. The second patch implements the MQPrio offloading for the receive path. Thanks ! Maxime Maxime Chevallier (2): net: mvneta: Remove per-cpu queue mapping for Armada 3700 net: mvneta: Implement mqprio support drivers/net/ethernet/marvell/mvneta.c | 74 ++++++++++++++++++++++++++- 1 file changed, 73 insertions(+), 1 deletion(-) -- 2.25.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 2021-02-12 15:12 [PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support Maxime Chevallier @ 2021-02-12 15:12 ` Maxime Chevallier 2021-02-14 23:50 ` Pali Rohár 2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier 1 sibling, 1 reply; 9+ messages in thread From: Maxime Chevallier @ 2021-02-12 15:12 UTC (permalink / raw) To: davem Cc: Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni, gregory.clement According to Errata #23 "The per-CPU GbE interrupt is limited to Core 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 familly. This is correctly checked for RSS configuration, but the initial queue mapping is still done by having the queues spread across all the CPUs in the system, both in the init path and in the cpu_hotplug path. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- drivers/net/ethernet/marvell/mvneta.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 6290bfb6494e..8e410fafff8d 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -3428,7 +3428,9 @@ static int mvneta_txq_sw_init(struct mvneta_port *pp, return -ENOMEM; /* Setup XPS mapping */ - if (txq_number > 1) + if (pp->neta_armada3700) + cpu = 0; + else if (txq_number > 1) cpu = txq->id % num_present_cpus(); else cpu = pp->rxq_def % num_present_cpus(); @@ -4206,6 +4208,11 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node) node_online); struct mvneta_pcpu_port *port = per_cpu_ptr(pp->ports, cpu); + /* Armada 3700's per-cpu interrupt for mvneta is broken, all interrupts + * are routed to CPU 0, so we don't need all the cpu-hotplug support + */ + if (pp->neta_armada3700) + return 0; spin_lock(&pp->lock); /* -- 2.25.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 2021-02-12 15:12 ` [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 Maxime Chevallier @ 2021-02-14 23:50 ` Pali Rohár 2021-02-15 15:06 ` Maxime Chevallier 0 siblings, 1 reply; 9+ messages in thread From: Pali Rohár @ 2021-02-14 23:50 UTC (permalink / raw) To: Maxime Chevallier Cc: davem, gregory.clement, linux-kernel, netdev, thomas.petazzoni > According to Errata #23 "The per-CPU GbE interrupt is limited to Core > 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 > familly. > > This is correctly checked for RSS configuration, but the initial queue > mapping is still done by having the queues spread across all the CPUs in > the system, both in the init path and in the cpu_hotplug path. Hello Maxime! This patch looks like a bug fix for Armada 3700 SoC. What about marking this commit with Fixes line? E.g.: Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC") ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 2021-02-14 23:50 ` Pali Rohár @ 2021-02-15 15:06 ` Maxime Chevallier 0 siblings, 0 replies; 9+ messages in thread From: Maxime Chevallier @ 2021-02-15 15:06 UTC (permalink / raw) To: Pali Rohár Cc: davem, gregory.clement, linux-kernel, netdev, thomas.petazzoni Hi Pali, On Mon, 15 Feb 2021 00:50:58 +0100 Pali Rohár <pali@kernel.org> wrote: >> According to Errata #23 "The per-CPU GbE interrupt is limited to Core >> 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 >> familly. >> >> This is correctly checked for RSS configuration, but the initial queue >> mapping is still done by having the queues spread across all the CPUs in >> the system, both in the init path and in the cpu_hotplug path. > >Hello Maxime! > >This patch looks like a bug fix for Armada 3700 SoC. What about marking >this commit with Fixes line? E.g.: > > Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC") Yes you're correct, I'll add that to the V2 ! Thanks for the review, Maxime -- Maxime Chevallier, Bootlin Embedded Linux and kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next 2/2] net: mvneta: Implement mqprio support 2021-02-12 15:12 [PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support Maxime Chevallier 2021-02-12 15:12 ` [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 Maxime Chevallier @ 2021-02-12 15:12 ` Maxime Chevallier 2021-02-12 17:53 ` kernel test robot 2021-02-13 19:45 ` Andrew Lunn 1 sibling, 2 replies; 9+ messages in thread From: Maxime Chevallier @ 2021-02-12 15:12 UTC (permalink / raw) To: davem Cc: Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni, gregory.clement Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- drivers/net/ethernet/marvell/mvneta.c | 65 +++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 8e410fafff8d..5389d195d4ce 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -102,6 +102,8 @@ #define MVNETA_TX_NO_DATA_SWAP BIT(5) #define MVNETA_DESC_SWAP BIT(6) #define MVNETA_TX_BRST_SZ_MASK(burst) ((burst) << 22) +#define MVNETA_VLAN_PRIO_TO_RXQ 0x2440 +#define MVNETA_VLAN_PRIO_RXQ_MAP(prio, rxq) ((rxq) << ((prio) * 3)) #define MVNETA_PORT_STATUS 0x2444 #define MVNETA_TX_IN_PRGRS BIT(1) #define MVNETA_TX_FIFO_EMPTY BIT(8) @@ -490,6 +492,7 @@ struct mvneta_port { u8 mcast_count[256]; u16 tx_ring_size; u16 rx_ring_size; + u8 prio_tc_map[8]; phy_interface_t phy_interface; struct device_node *dn; @@ -4922,6 +4925,67 @@ static int mvneta_ethtool_set_eee(struct net_device *dev, return phylink_ethtool_set_eee(pp->phylink, eee); } +static void mvneta_clear_rx_prio_map(struct mvneta_port *pp) +{ + mvreg_write(pp, MVNETA_VLAN_PRIO_TO_RXQ, 0); +} + +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp) +{ + int i; + u32 val = 0; + + for (i = 0; i < rxq_number; i++) + val |= MVNETA_VLAN_PRIO_RXQ_MAP(i, pp->prio_tc_map[i]); + + mvreg_write(pp, MVNETA_VLAN_PRIO_TO_RXQ, val); +} + +static int mvneta_setup_mqprio(struct net_device *dev, + struct tc_mqprio_qopt *qopt) +{ + struct mvneta_port *pp = netdev_priv(dev); + u8 num_tc; + int i; + + qopt->hw = TC_MQPRIO_HW_OFFLOAD_TCS; + num_tc = qopt->num_tc; + + if (num_tc > rxq_number) + return -EINVAL; + + if (!num_tc) { + mvneta_clear_rx_prio_map(pp); + netdev_reset_tc(dev); + return 0; + } + + if (qopt->prio_tc_map) { + memcpy(pp->prio_tc_map, qopt->prio_tc_map, + sizeof(pp->prio_tc_map)); + + mvneta_setup_rx_prio_map(pp); + + netdev_set_num_tc(dev, qopt->num_tc); + for (i = 0; i < qopt->num_tc; i++) + netdev_set_tc_queue(dev, i, qopt->count[i], + qopt->offset[i]); + } + + return 0; +} + +static int mvneta_setup_tc(struct net_device *dev, enum tc_setup_type type, + void *type_data) +{ + switch (type) { + case TC_SETUP_QDISC_MQPRIO: + return mvneta_setup_mqprio(dev, type_data); + default: + return -EOPNOTSUPP; + } +} + static const struct net_device_ops mvneta_netdev_ops = { .ndo_open = mvneta_open, .ndo_stop = mvneta_stop, @@ -4934,6 +4998,7 @@ static const struct net_device_ops mvneta_netdev_ops = { .ndo_do_ioctl = mvneta_ioctl, .ndo_bpf = mvneta_xdp, .ndo_xdp_xmit = mvneta_xdp_xmit, + .ndo_setup_tc = mvneta_setup_tc, }; static const struct ethtool_ops mvneta_eth_tool_ops = { -- 2.25.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support 2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier @ 2021-02-12 17:53 ` kernel test robot 2021-02-13 19:45 ` Andrew Lunn 1 sibling, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-02-12 17:53 UTC (permalink / raw) To: Maxime Chevallier, davem Cc: kbuild-all, clang-built-linux, Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni, gregory.clement [-- Attachment #1: Type: text/plain, Size: 8941 bytes --] Hi Maxime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxime-Chevallier/net-mvneta-Implement-basic-MQPrio-support/20210212-231937 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e4b62cf7559f2ef9a022de235e5a09a8d7ded520 config: powerpc-randconfig-r023-20210209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/0day-ci/linux/commit/0cfab93df7365f1378834302d2c3b28b425b64fd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Maxime-Chevallier/net-mvneta-Implement-basic-MQPrio-support/20210212-231937 git checkout 0cfab93df7365f1378834302d2c3b28b425b64fd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): __do_insb ^ arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb' #define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:64:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:66:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:68:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb' #define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:70:1: note: expanded from here __do_outsw ^ arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw' #define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:72:1: note: expanded from here __do_outsl ^ arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl' #define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ >> drivers/net/ethernet/marvell/mvneta.c:4963:12: warning: address of array 'qopt->prio_tc_map' will always evaluate to 'true' [-Wpointer-bool-conversion] if (qopt->prio_tc_map) { ~~ ~~~~~~^~~~~~~~~~~ 7 warnings generated. vim +4963 drivers/net/ethernet/marvell/mvneta.c 4943 4944 static int mvneta_setup_mqprio(struct net_device *dev, 4945 struct tc_mqprio_qopt *qopt) 4946 { 4947 struct mvneta_port *pp = netdev_priv(dev); 4948 u8 num_tc; 4949 int i; 4950 4951 qopt->hw = TC_MQPRIO_HW_OFFLOAD_TCS; 4952 num_tc = qopt->num_tc; 4953 4954 if (num_tc > rxq_number) 4955 return -EINVAL; 4956 4957 if (!num_tc) { 4958 mvneta_clear_rx_prio_map(pp); 4959 netdev_reset_tc(dev); 4960 return 0; 4961 } 4962 > 4963 if (qopt->prio_tc_map) { 4964 memcpy(pp->prio_tc_map, qopt->prio_tc_map, 4965 sizeof(pp->prio_tc_map)); 4966 4967 mvneta_setup_rx_prio_map(pp); 4968 4969 netdev_set_num_tc(dev, qopt->num_tc); 4970 for (i = 0; i < qopt->num_tc; i++) 4971 netdev_set_tc_queue(dev, i, qopt->count[i], 4972 qopt->offset[i]); 4973 } 4974 4975 return 0; 4976 } 4977 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 40333 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support @ 2021-02-12 17:53 ` kernel test robot 0 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-02-12 17:53 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 9117 bytes --] Hi Maxime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxime-Chevallier/net-mvneta-Implement-basic-MQPrio-support/20210212-231937 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e4b62cf7559f2ef9a022de235e5a09a8d7ded520 config: powerpc-randconfig-r023-20210209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/0day-ci/linux/commit/0cfab93df7365f1378834302d2c3b28b425b64fd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Maxime-Chevallier/net-mvneta-Implement-basic-MQPrio-support/20210212-231937 git checkout 0cfab93df7365f1378834302d2c3b28b425b64fd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): __do_insb ^ arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb' #define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:64:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:66:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:68:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb' #define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:70:1: note: expanded from here __do_outsw ^ arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw' #define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from drivers/net/ethernet/marvell/mvneta.c:16: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:72:1: note: expanded from here __do_outsl ^ arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl' #define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ >> drivers/net/ethernet/marvell/mvneta.c:4963:12: warning: address of array 'qopt->prio_tc_map' will always evaluate to 'true' [-Wpointer-bool-conversion] if (qopt->prio_tc_map) { ~~ ~~~~~~^~~~~~~~~~~ 7 warnings generated. vim +4963 drivers/net/ethernet/marvell/mvneta.c 4943 4944 static int mvneta_setup_mqprio(struct net_device *dev, 4945 struct tc_mqprio_qopt *qopt) 4946 { 4947 struct mvneta_port *pp = netdev_priv(dev); 4948 u8 num_tc; 4949 int i; 4950 4951 qopt->hw = TC_MQPRIO_HW_OFFLOAD_TCS; 4952 num_tc = qopt->num_tc; 4953 4954 if (num_tc > rxq_number) 4955 return -EINVAL; 4956 4957 if (!num_tc) { 4958 mvneta_clear_rx_prio_map(pp); 4959 netdev_reset_tc(dev); 4960 return 0; 4961 } 4962 > 4963 if (qopt->prio_tc_map) { 4964 memcpy(pp->prio_tc_map, qopt->prio_tc_map, 4965 sizeof(pp->prio_tc_map)); 4966 4967 mvneta_setup_rx_prio_map(pp); 4968 4969 netdev_set_num_tc(dev, qopt->num_tc); 4970 for (i = 0; i < qopt->num_tc; i++) 4971 netdev_set_tc_queue(dev, i, qopt->count[i], 4972 qopt->offset[i]); 4973 } 4974 4975 return 0; 4976 } 4977 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 40333 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support 2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier 2021-02-12 17:53 ` kernel test robot @ 2021-02-13 19:45 ` Andrew Lunn 2021-02-15 15:08 ` Maxime Chevallier 1 sibling, 1 reply; 9+ messages in thread From: Andrew Lunn @ 2021-02-13 19:45 UTC (permalink / raw) To: Maxime Chevallier Cc: davem, netdev, linux-kernel, thomas.petazzoni, gregory.clement On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote: > +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp) > +{ > + int i; > + u32 val = 0; Hi Maxime Reverse Chrismtass tree please. Andrew ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support 2021-02-13 19:45 ` Andrew Lunn @ 2021-02-15 15:08 ` Maxime Chevallier 0 siblings, 0 replies; 9+ messages in thread From: Maxime Chevallier @ 2021-02-15 15:08 UTC (permalink / raw) To: Andrew Lunn Cc: davem, netdev, linux-kernel, thomas.petazzoni, gregory.clement Hi Andrew, On Sat, 13 Feb 2021 20:45:25 +0100 Andrew Lunn <andrew@lunn.ch> wrote: >On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote: >> +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp) >> +{ >> + int i; >> + u32 val = 0; > >Hi Maxime > >Reverse Chrismtass tree please. Ah yes sorry, I'll fix that in V2. Thanks for the review, Maxime -- Maxime Chevallier, Bootlin Embedded Linux and kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-15 15:16 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-12 15:12 [PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support Maxime Chevallier 2021-02-12 15:12 ` [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 Maxime Chevallier 2021-02-14 23:50 ` Pali Rohár 2021-02-15 15:06 ` Maxime Chevallier 2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier 2021-02-12 17:53 ` kernel test robot 2021-02-12 17:53 ` kernel test robot 2021-02-13 19:45 ` Andrew Lunn 2021-02-15 15:08 ` Maxime Chevallier
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.