All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	qemu Developers <qemu-devel@nongnu.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID
Date: Wed, 10 Mar 2021 14:29:20 +0100	[thread overview]
Message-ID: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210303152948.59943-2-akihiko.odaki@gmail.com>

  Hi,

> -static void xenfb_update_interval(void *opaque, uint64_t interval)
> +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)

> -    .update_interval = xenfb_update_interval,
> +    .ui_info     = xenfb_ui_info,

Hmm, I suspect xenfb really wants the actual refresh rate, even in case
vnc/sdl change it dynamically.  Anthony?  Stefano?

I guess we should just leave the update_interval callback as-is, for
those who want know, and use ui_info->refresh_rate for the virtual edid
refresh rate (which may not match the actual update interval in case of
dynamic changes).  Adding a comment explaining the difference to
console.h is a good idea too.

Otherwise looks good to me overall.  Splitting the ui/gtk update to a
separate patch is probably a good idea.

take care,
  Gerd



WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: qemu Developers <qemu-devel@nongnu.org>,
	xen-devel@lists.xenproject.org,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID
Date: Wed, 10 Mar 2021 14:29:20 +0100	[thread overview]
Message-ID: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210303152948.59943-2-akihiko.odaki@gmail.com>

  Hi,

> -static void xenfb_update_interval(void *opaque, uint64_t interval)
> +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)

> -    .update_interval = xenfb_update_interval,
> +    .ui_info     = xenfb_ui_info,

Hmm, I suspect xenfb really wants the actual refresh rate, even in case
vnc/sdl change it dynamically.  Anthony?  Stefano?

I guess we should just leave the update_interval callback as-is, for
those who want know, and use ui_info->refresh_rate for the virtual edid
refresh rate (which may not match the actual update interval in case of
dynamic changes).  Adding a comment explaining the difference to
console.h is a good idea too.

Otherwise looks good to me overall.  Splitting the ui/gtk update to a
separate patch is probably a good idea.

take care,
  Gerd



  reply	other threads:[~2021-03-10 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 15:29 [PATCH v2 1/2] edid: Make refresh rate configurable Akihiko Odaki
2021-03-03 15:29 ` Akihiko Odaki
2021-03-03 15:29 ` [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID Akihiko Odaki
2021-03-03 15:29   ` Akihiko Odaki
2021-03-10 13:29   ` Gerd Hoffmann [this message]
2021-03-10 13:29     ` Gerd Hoffmann
2021-03-10 16:08     ` Akihiko Odaki
2021-03-10 16:08       ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=anthony.perard@citrix.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.