From: Matthew Wilcox <willy@infradead.org>
To: William Kucharski <william.kucharski@oracle.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Ian Campbell <ijc@hellion.org.uk>,
Jaya Kumar <jayakumar.lkml@gmail.com>,
Jani Nikula <jani.nikula@intel.com>,
Christoph Hellwig <hch@lst.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations
Date: Wed, 10 Mar 2021 18:49:04 +0000 [thread overview]
Message-ID: <20210310184904.GS3479805@casper.infradead.org> (raw)
In-Reply-To: <B2F0192D-2C63-4BD0-8B5C-461361C7F0DD@oracle.com>
On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote:
> Looks good, just one super minor nit inline.
> > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info)
> >
> > BUG_ON(!fbdefio);
> > cancel_delayed_work_sync(&info->deferred_work);
> > -
> > - /* clear out the mapping that we setup */
> > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
> > - page = fb_deferred_io_page(info, i);
> > - page->mapping = NULL;
> > - }
> > -
> > mutex_destroy(&fbdefio->lock);
> > }
>
> We no longer need the definition of "int i" right before the BUG_ON().
Huh. Usually gcc warns about that. let me figure that out and post a v2.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: William Kucharski <william.kucharski@oracle.com>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Ian Campbell <ijc@hellion.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jaya Kumar <jayakumar.lkml@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations
Date: Wed, 10 Mar 2021 18:49:04 +0000 [thread overview]
Message-ID: <20210310184904.GS3479805@casper.infradead.org> (raw)
In-Reply-To: <B2F0192D-2C63-4BD0-8B5C-461361C7F0DD@oracle.com>
On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote:
> Looks good, just one super minor nit inline.
> > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info)
> >
> > BUG_ON(!fbdefio);
> > cancel_delayed_work_sync(&info->deferred_work);
> > -
> > - /* clear out the mapping that we setup */
> > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
> > - page = fb_deferred_io_page(info, i);
> > - page->mapping = NULL;
> > - }
> > -
> > mutex_destroy(&fbdefio->lock);
> > }
>
> We no longer need the definition of "int i" right before the BUG_ON().
Huh. Usually gcc warns about that. let me figure that out and post a v2.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-10 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:51 [PATCH] fb_defio: Remove custom address_space_operations Matthew Wilcox (Oracle)
2021-03-10 13:51 ` Matthew Wilcox (Oracle)
2021-03-10 16:54 ` Christoph Hellwig
2021-03-10 18:38 ` William Kucharski
2021-03-10 18:38 ` William Kucharski
2021-03-10 18:49 ` Matthew Wilcox [this message]
2021-03-10 18:49 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310184904.GS3479805@casper.infradead.org \
--to=willy@infradead.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=ijc@hellion.org.uk \
--cc=jani.nikula@intel.com \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.