All of lore.kernel.org
 help / color / mirror / Atom feed
From: Swetha Joshi <swethajoshi139@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Swetha Joshi <swethajoshi139@gmail.com>
Subject: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled
Date: Mon, 24 May 2021 19:58:23 -0700	[thread overview]
Message-ID: <20210525025823.3208218-1-swethajoshi139@gmail.com> (raw)

Signed-off-by: Swetha Joshi <swethajoshi139@gmail.com>
---
 target/arm/kvm64.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index dff85f6db9..47a4d9d831 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -1403,7 +1403,10 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr)
     hwaddr paddr;
     Object *obj = qdev_get_machine();
     VirtMachineState *vms = VIRT_MACHINE(obj);
-    bool acpi_enabled = virt_is_acpi_enabled(vms);
+    bool acpi_enabled = false;
+#ifdef CONFIG_ARM_VIRT
+    acpi_enabled = virt_is_acpi_enabled(vms);
+#endif /* CONFIG_ARM_VIRT */
 
     assert(code == BUS_MCEERR_AR || code == BUS_MCEERR_AO);
 
@@ -1426,12 +1429,13 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr)
              */
             if (code == BUS_MCEERR_AR) {
                 kvm_cpu_synchronize_state(c);
-                if (!acpi_ghes_record_errors(ACPI_HEST_SRC_ID_SEA, paddr)) {
-                    kvm_inject_arm_sea(c);
-                } else {
+#ifdef CONFIG_ACPI_APEI
+                if (acpi_ghes_record_errors(ACPI_HEST_SRC_ID_SEA, paddr)) {
                     error_report("failed to record the error");
                     abort();
                 }
+#endif /* CONFIG_ACPI_APEI */
+                kvm_inject_arm_sea(c);
             }
             return;
         }
-- 
2.25.1



             reply	other threads:[~2021-05-25  2:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  2:58 Swetha Joshi [this message]
2021-05-25  3:20 ` [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled Richard Henderson
     [not found]   ` <CALf2nmKjSB0FN1ZotYjLKF+BBsWiwLPUDjkNeRgq1HkG4P=Aow@mail.gmail.com>
2021-05-25  4:14     ` Richard Henderson
2021-05-25  6:45   ` Philippe Mathieu-Daudé
2021-05-25  9:04   ` Peter Maydell
2021-05-25 16:27     ` Swetha Joshi
2021-05-25 17:15       ` Peter Maydell
2021-05-26 17:32         ` Swetha Joshi
2021-05-26 18:19           ` Peter Maydell
2021-05-28  7:08             ` Dongjiu Geng
2021-05-28 19:41               ` Swetha Joshi
2021-06-02 13:44                 ` Dongjiu Geng
2021-06-03 17:17                   ` Swetha Joshi
2021-06-03 17:22                 ` Peter Maydell
2021-06-03 17:30                   ` Swetha Joshi
2021-06-04  5:25                     ` Swetha Joshi
2021-06-04  9:03                       ` Peter Maydell
2021-06-04 15:06                         ` Swetha Joshi
2021-09-07 10:02                           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525025823.3208218-1-swethajoshi139@gmail.com \
    --to=swethajoshi139@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.