From: Swetha Joshi <swethajoshi139@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled
Date: Wed, 26 May 2021 10:32:36 -0700 [thread overview]
Message-ID: <CALf2nmKhPaWJa944dR+kFAQ1hCLXF0XPwXaHTqJQ-C6EW7ACKg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-oX0JR80UYzYKvczHsfxWG6oH3Pg4pbM6ByDe57XEHHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
Hello,
One of the qemu machines we use has KVM enabled, but we don't want the
CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physical
hardware that we don't need. The compilation errors I mentioned are not in
the qemu mainline per say but we see them in one of the qemu derived
machines we use.
Thanks,
Swetha.
On Tue, May 25, 2021 at 10:16 AM Peter Maydell <peter.maydell@linaro.org>
wrote:
> On Tue, 25 May 2021 at 17:28, Swetha Joshi <swethajoshi139@gmail.com>
> wrote:
> >
> > Hey Peter, Phil,
> >
> > Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT
> enabled, there are a couple of routines that are being called from virt.h
> and ghes.h, which is resulting in errors. I came up with this simple fix
> but if you think there is a better solution to it I'll let you/ other
> developers who own it decide and fix it because I don't have much
> experience or visibility into what happens internally, my knowledge is
> restricted to just using the configs.
>
> Well, QEMU builds fine for me as-is, because the default config
> always enables the virt board. Do you have repro instructions for
> reproducing the build failure ?
>
> thanks
> -- PMM
>
--
Regards
Swetha Joshi.
[-- Attachment #2: Type: text/html, Size: 1810 bytes --]
next prev parent reply other threads:[~2021-05-26 17:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 2:58 [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled Swetha Joshi
2021-05-25 3:20 ` Richard Henderson
[not found] ` <CALf2nmKjSB0FN1ZotYjLKF+BBsWiwLPUDjkNeRgq1HkG4P=Aow@mail.gmail.com>
2021-05-25 4:14 ` Richard Henderson
2021-05-25 6:45 ` Philippe Mathieu-Daudé
2021-05-25 9:04 ` Peter Maydell
2021-05-25 16:27 ` Swetha Joshi
2021-05-25 17:15 ` Peter Maydell
2021-05-26 17:32 ` Swetha Joshi [this message]
2021-05-26 18:19 ` Peter Maydell
2021-05-28 7:08 ` Dongjiu Geng
2021-05-28 19:41 ` Swetha Joshi
2021-06-02 13:44 ` Dongjiu Geng
2021-06-03 17:17 ` Swetha Joshi
2021-06-03 17:22 ` Peter Maydell
2021-06-03 17:30 ` Swetha Joshi
2021-06-04 5:25 ` Swetha Joshi
2021-06-04 9:03 ` Peter Maydell
2021-06-04 15:06 ` Swetha Joshi
2021-09-07 10:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALf2nmKhPaWJa944dR+kFAQ1hCLXF0XPwXaHTqJQ-C6EW7ACKg@mail.gmail.com \
--to=swethajoshi139@gmail.com \
--cc=gengdongjiu1@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.