All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Swetha Joshi <swethajoshi139@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled
Date: Mon, 24 May 2021 21:14:33 -0700	[thread overview]
Message-ID: <52adb715-5953-da2c-4a84-b81c0ffb5910@linaro.org> (raw)
In-Reply-To: <CALf2nmKjSB0FN1ZotYjLKF+BBsWiwLPUDjkNeRgq1HkG4P=Aow@mail.gmail.com>

On 5/24/21 8:23 PM, Swetha Joshi wrote:
> Where do I add the commit message?

When you use git commit?

> About the outer if, so if config_arm_virt was enabled and if acpi_enabled Is 
> true, we still need to make sure config_acpi_apei was enabled as well.

Done in hw/arm/Kconfig:

config ARM_VIRT
...
     select ACPI_APEI


r~


  parent reply	other threads:[~2021-05-25  4:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  2:58 [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled Swetha Joshi
2021-05-25  3:20 ` Richard Henderson
     [not found]   ` <CALf2nmKjSB0FN1ZotYjLKF+BBsWiwLPUDjkNeRgq1HkG4P=Aow@mail.gmail.com>
2021-05-25  4:14     ` Richard Henderson [this message]
2021-05-25  6:45   ` Philippe Mathieu-Daudé
2021-05-25  9:04   ` Peter Maydell
2021-05-25 16:27     ` Swetha Joshi
2021-05-25 17:15       ` Peter Maydell
2021-05-26 17:32         ` Swetha Joshi
2021-05-26 18:19           ` Peter Maydell
2021-05-28  7:08             ` Dongjiu Geng
2021-05-28 19:41               ` Swetha Joshi
2021-06-02 13:44                 ` Dongjiu Geng
2021-06-03 17:17                   ` Swetha Joshi
2021-06-03 17:22                 ` Peter Maydell
2021-06-03 17:30                   ` Swetha Joshi
2021-06-04  5:25                     ` Swetha Joshi
2021-06-04  9:03                       ` Peter Maydell
2021-06-04 15:06                         ` Swetha Joshi
2021-09-07 10:02                           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52adb715-5953-da2c-4a84-b81c0ffb5910@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=swethajoshi139@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.