From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Jim Quinlan <jim2101024@gmail.com>, Etienne Carriere <etienne.carriere@linaro.org>, Peter Hilber <peter.hilber@opensynergy.com> Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema Date: Thu, 27 May 2021 11:49:06 +0100 [thread overview] Message-ID: <20210527104845.xof6ngrfsj2ybsmb@bogus> (raw) In-Reply-To: <20210527103323.GS28060@e120937-lin> On Thu, May 27, 2021 at 11:33:23AM +0100, Cristian Marussi wrote: > Hi Sudeep, > > Some feedback down below. > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: [...] > > +patternProperties: > > + '^protocol@[0-9a-f]+$': > > + type: object > > + description: | > > + Each sub-node represents a protocol supported. If the platform > > + supports dedicated communication channel for a particular protocol, > > + then corresponding transport properties must be present. > > + > > Not sure if it's needed, but maybe a reference or an example to which > are the transport properties could be useful in this description. > Good point, I will try to add that example. > > + properties: > > + reg: > > + maxItems: 1 > > + > > Shouldn't be expressed that reg is required for these protocol > patternProperties ? (no sure how though...:D) > Hmm, right again need to explore on that. > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > + '#power-domain-cells': > > + const: 1 > > + > > + '#thermal-sensor-cells': > > + const: 1 > > + > > Maybe it does not matter, but all the info present in the old .txt binding > about references to external std bindings like: > > > -This binding for the SCMI power domain providers uses the generic > > power > > -domain binding[2]. > > is no more reported in yaml. Is it fine ? > I think we can add it as $ref if there is yaml schema, I really don't think old .txt based reference adds anything. > > +required: > > + - compatible > > + - shmem > > Indeed shmem is required by chance all the transports defined in this > binding, but it is not really something generally required, in fact > virtio transport won't require it. > > But I'm not sure if it's better to move it now down under some kind of > if: arm,scmi|arm,scmi-smc or just do it later when virtio transport binding > will be defined/introduced. > Yes I was aware of that fact while I wrote this and expect it to be part of virtio update. -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Jim Quinlan <jim2101024@gmail.com>, Etienne Carriere <etienne.carriere@linaro.org>, Peter Hilber <peter.hilber@opensynergy.com> Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema Date: Thu, 27 May 2021 11:49:06 +0100 [thread overview] Message-ID: <20210527104845.xof6ngrfsj2ybsmb@bogus> (raw) In-Reply-To: <20210527103323.GS28060@e120937-lin> On Thu, May 27, 2021 at 11:33:23AM +0100, Cristian Marussi wrote: > Hi Sudeep, > > Some feedback down below. > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: [...] > > +patternProperties: > > + '^protocol@[0-9a-f]+$': > > + type: object > > + description: | > > + Each sub-node represents a protocol supported. If the platform > > + supports dedicated communication channel for a particular protocol, > > + then corresponding transport properties must be present. > > + > > Not sure if it's needed, but maybe a reference or an example to which > are the transport properties could be useful in this description. > Good point, I will try to add that example. > > + properties: > > + reg: > > + maxItems: 1 > > + > > Shouldn't be expressed that reg is required for these protocol > patternProperties ? (no sure how though...:D) > Hmm, right again need to explore on that. > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > + '#power-domain-cells': > > + const: 1 > > + > > + '#thermal-sensor-cells': > > + const: 1 > > + > > Maybe it does not matter, but all the info present in the old .txt binding > about references to external std bindings like: > > > -This binding for the SCMI power domain providers uses the generic > > power > > -domain binding[2]. > > is no more reported in yaml. Is it fine ? > I think we can add it as $ref if there is yaml schema, I really don't think old .txt based reference adds anything. > > +required: > > + - compatible > > + - shmem > > Indeed shmem is required by chance all the transports defined in this > binding, but it is not really something generally required, in fact > virtio transport won't require it. > > But I'm not sure if it's better to move it now down under some kind of > if: arm,scmi|arm,scmi-smc or just do it later when virtio transport binding > will be defined/introduced. > Yes I was aware of that fact while I wrote this and expect it to be part of virtio update. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-27 10:49 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 18:27 [PATCH 0/8] dt-bindings: firmware: Convert SCPI and SCMI to json schema Sudeep Holla 2021-05-26 18:27 ` Sudeep Holla 2021-05-26 18:28 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla 2021-05-26 18:28 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Sudeep Holla 2021-05-27 20:25 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Rob Herring 2021-05-27 20:25 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Rob Herring 2021-05-31 8:15 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla 2021-05-31 8:15 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Sudeep Holla 2021-05-31 8:20 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla 2021-05-31 8:20 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Sudeep Holla 2021-06-01 13:37 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Rob Herring 2021-06-01 13:37 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Rob Herring 2021-06-01 13:53 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla 2021-06-01 13:53 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Sudeep Holla 2021-05-26 18:28 ` [PATCH 2/8] dt-bindings: firmware: arm,scmi: Move arm,scmi-shmem " Sudeep Holla 2021-05-26 18:28 ` [PATCH 2/8] dt-bindings: firmware: arm, scmi: Move arm, scmi-shmem " Sudeep Holla 2021-05-26 18:28 ` [PATCH 3/8] dt-bindings: firmware: juno,scpi: Move to sram.yaml " Sudeep Holla 2021-05-26 18:28 ` [PATCH 3/8] dt-bindings: firmware: juno, scpi: " Sudeep Holla 2021-05-26 18:28 ` [PATCH 4/8] dt-bindings: firmware: amlogic,scpi: Move arm,scpi-shmem to " Sudeep Holla 2021-05-26 18:28 ` [PATCH 4/8] dt-bindings: firmware: amlogic, scpi: Move arm, scpi-shmem " Sudeep Holla 2021-05-26 18:28 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert " Sudeep Holla 2021-05-26 18:28 ` Sudeep Holla 2021-05-27 14:23 ` Rob Herring 2021-05-27 14:23 ` [PATCH 5/8] dt-bindings: firmware: arm, scpi: " Rob Herring 2021-05-27 16:17 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: " Sudeep Holla 2021-05-27 16:17 ` Sudeep Holla 2021-05-26 18:28 ` [PATCH 6/8] dt-bindings: mailbox : arm,mhu: Fix arm,scpi example used here Sudeep Holla 2021-05-26 18:28 ` [PATCH 6/8] dt-bindings: mailbox : arm, mhu: Fix arm, scpi " Sudeep Holla 2021-05-27 14:23 ` Rob Herring 2021-05-27 14:23 ` Rob Herring 2021-05-27 16:25 ` Sudeep Holla 2021-05-27 16:25 ` Sudeep Holla 2021-05-27 20:07 ` Rob Herring 2021-05-27 20:07 ` Rob Herring 2021-05-31 8:17 ` Sudeep Holla 2021-05-31 8:17 ` Sudeep Holla 2021-05-26 18:28 ` [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: Convert to json schema Sudeep Holla 2021-05-26 18:28 ` [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: " Sudeep Holla 2021-05-27 20:33 ` [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: " Rob Herring 2021-05-27 20:33 ` [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: " Rob Herring 2021-05-31 8:36 ` [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: " Sudeep Holla 2021-05-31 8:36 ` [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: " Sudeep Holla 2021-05-26 18:28 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Sudeep Holla 2021-05-26 18:28 ` Sudeep Holla 2021-05-26 18:35 ` Sudeep Holla 2021-05-26 18:35 ` Sudeep Holla 2021-05-27 20:15 ` Rob Herring 2021-05-27 20:15 ` [PATCH 8/8] dt-bindings: firmware: arm, scmi: " Rob Herring 2021-05-27 6:37 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Etienne Carriere 2021-05-27 6:37 ` [PATCH 8/8] dt-bindings: firmware: arm, scmi: " Etienne Carriere 2021-05-27 10:53 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Sudeep Holla 2021-05-27 10:53 ` Sudeep Holla 2021-05-27 10:33 ` Cristian Marussi 2021-05-27 10:33 ` Cristian Marussi 2021-05-27 10:49 ` Sudeep Holla [this message] 2021-05-27 10:49 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210527104845.xof6ngrfsj2ybsmb@bogus \ --to=sudeep.holla@arm.com \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=jim2101024@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=peter.hilber@opensynergy.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.