All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] ext4: remove conflict comment from __ext4_forget
@ 2021-06-23  8:58 Guoqing Jiang
  2021-07-13 15:17 ` Jan Kara
  0 siblings, 1 reply; 3+ messages in thread
From: Guoqing Jiang @ 2021-06-23  8:58 UTC (permalink / raw)
  To: tytso, adilger.kernel; +Cc: linux-ext4

From: Guoqing Jiang <jiangguoqing@kylinos.cn>

We do a bforget and return for no journal case, so let's remove this
conflict comment.

Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
Not sure if my understanding is correct, so this is RFC.

Thanks,
Guoqing

 fs/ext4/ext4_jbd2.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
index be799040a415..6e224b19eae7 100644
--- a/fs/ext4/ext4_jbd2.c
+++ b/fs/ext4/ext4_jbd2.c
@@ -244,9 +244,6 @@ int __ext4_journal_get_write_access(const char *where, unsigned int line,
  * "bh" may be NULL: a metadata block may have been freed from memory
  * but there may still be a record of it in the journal, and that record
  * still needs to be revoked.
- *
- * If the handle isn't valid we're not journaling, but we still need to
- * call into ext4_journal_revoke() to put the buffer head.
  */
 int __ext4_forget(const char *where, unsigned int line, handle_t *handle,
 		  int is_metadata, struct inode *inode,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-14  5:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23  8:58 [RFC PATCH] ext4: remove conflict comment from __ext4_forget Guoqing Jiang
2021-07-13 15:17 ` Jan Kara
2021-07-14  5:52   ` Guoqing Jiang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.