[PATCH] test-runner: fix valgrind after no radio change

[PATCH] test-runner: fix valgrind after no radio change

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

The change adding support for starting IWD with no radios ended up
breaking the valgrind option.
---
 tools/test-runner | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/test-runner b/tools/test-runner
index 17be0593..64407a41 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -668,7 +668,7 @@ class Namespace:
 		self._bus = dbus.bus.BusConnection(address_or_type=self.dbus_address)
 
 	def start_iwd(self, config_dir = '/tmp', storage_dir = '/tmp/iwd'):
-		args = ['iwd', '-E']
+		args = []
 		iwd_radios = ','.join([r.name for r in self.radios if r.use == 'iwd'])
 
 		if self.args.valgrind:
@@ -676,6 +676,8 @@ class Namespace:
 					'--show-leak-kinds=all',
 					'--log-file=/tmp/valgrind.log.%p'])
 
+		args.extend(['iwd', '-E'])
+
 		if iwd_radios != '':
 			args.extend(['-p', iwd_radios])
 
-- 
2.34.1

Re: [PATCH] test-runner: fix valgrind after no radio change

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi James,

On 2/14/22 15:41, James Prestwood wrote:
> The change adding support for starting IWD with no radios ended up
> breaking the valgrind option.
> ---
>   tools/test-runner | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Applied.  I squashed this into the commit in question.

Regards,
-Denis