* Re: [PATCH] test-runner: fix valgrind after no radio change
@ 2022-02-14 22:03 Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2022-02-14 22:03 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
Hi James,
On 2/14/22 15:41, James Prestwood wrote:
> The change adding support for starting IWD with no radios ended up
> breaking the valgrind option.
> ---
> tools/test-runner | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied. I squashed this into the commit in question.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] test-runner: fix valgrind after no radio change
@ 2022-02-14 21:41 James Prestwood
0 siblings, 0 replies; 2+ messages in thread
From: James Prestwood @ 2022-02-14 21:41 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
The change adding support for starting IWD with no radios ended up
breaking the valgrind option.
---
tools/test-runner | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/test-runner b/tools/test-runner
index 17be0593..64407a41 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -668,7 +668,7 @@ class Namespace:
self._bus = dbus.bus.BusConnection(address_or_type=self.dbus_address)
def start_iwd(self, config_dir = '/tmp', storage_dir = '/tmp/iwd'):
- args = ['iwd', '-E']
+ args = []
iwd_radios = ','.join([r.name for r in self.radios if r.use == 'iwd'])
if self.args.valgrind:
@@ -676,6 +676,8 @@ class Namespace:
'--show-leak-kinds=all',
'--log-file=/tmp/valgrind.log.%p'])
+ args.extend(['iwd', '-E'])
+
if iwd_radios != '':
args.extend(['-p', iwd_radios])
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 22:03 [PATCH] test-runner: fix valgrind after no radio change Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2022-02-14 21:41 James Prestwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.