From: Frank Rowand <frowand.list@gmail.com>
To: Zev Weiss <zev@bewilderbeest.net>, openbmc@lists.ozlabs.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] of: make OF_DYNAMIC selectable independently of OF_UNITTEST
Date: Fri, 8 Oct 2021 14:01:43 -0500 [thread overview]
Message-ID: <288e4900-c23c-56ee-5c23-9a51cd3f315e@gmail.com> (raw)
In-Reply-To: <20211007000954.30621-8-zev@bewilderbeest.net>
On 10/6/21 7:09 PM, Zev Weiss wrote:
> The writable status sysfs file enabled by the 'dynamic' DT property
> requires CONFIG_OF_DYNAMIC to be useful, but that shouldn't require
> dragging in CONFIG_OF_UNITTEST as well.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> drivers/of/Kconfig | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 3dfeae8912df..8e0ba87db030 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -55,12 +55,14 @@ config OF_KOBJ
> # Hardly any platforms need this. It is safe to select, but only do so if you
> # need it.
> config OF_DYNAMIC
> - bool "Support for dynamic device trees" if OF_UNITTEST
> + bool "Support for dynamic device trees"
> select OF_KOBJ
> help
> On some platforms, the device tree can be manipulated at runtime.
> - While this option is selected automatically on such platforms, you
> - can enable it manually to improve device tree unit test coverage.
> + With this option enabled, device tree nodes that are marked with
> + the "dynamic" property can have their status toggled between
> + "okay" and "reserved" via sysfs. This can also be enabled to
> + increase test coverage with CONFIG_OF_UNITTEST if desired.
>
> config OF_ADDRESS
> def_bool y
>
The help message should be extended to explain the impact of enabling
OF_DYNAMIC manually (as opposed to auto selected) - it will be to
allow writes to a node's "status" property in sysfs if the node contains
a true value for the "dynamic" property.
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Zev Weiss <zev@bewilderbeest.net>, openbmc@lists.ozlabs.org
Cc: devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>
Subject: Re: [PATCH 7/9] of: make OF_DYNAMIC selectable independently of OF_UNITTEST
Date: Fri, 8 Oct 2021 14:01:43 -0500 [thread overview]
Message-ID: <288e4900-c23c-56ee-5c23-9a51cd3f315e@gmail.com> (raw)
In-Reply-To: <20211007000954.30621-8-zev@bewilderbeest.net>
On 10/6/21 7:09 PM, Zev Weiss wrote:
> The writable status sysfs file enabled by the 'dynamic' DT property
> requires CONFIG_OF_DYNAMIC to be useful, but that shouldn't require
> dragging in CONFIG_OF_UNITTEST as well.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> drivers/of/Kconfig | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 3dfeae8912df..8e0ba87db030 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -55,12 +55,14 @@ config OF_KOBJ
> # Hardly any platforms need this. It is safe to select, but only do so if you
> # need it.
> config OF_DYNAMIC
> - bool "Support for dynamic device trees" if OF_UNITTEST
> + bool "Support for dynamic device trees"
> select OF_KOBJ
> help
> On some platforms, the device tree can be manipulated at runtime.
> - While this option is selected automatically on such platforms, you
> - can enable it manually to improve device tree unit test coverage.
> + With this option enabled, device tree nodes that are marked with
> + the "dynamic" property can have their status toggled between
> + "okay" and "reserved" via sysfs. This can also be enabled to
> + increase test coverage with CONFIG_OF_UNITTEST if desired.
>
> config OF_ADDRESS
> def_bool y
>
The help message should be extended to explain the impact of enabling
OF_DYNAMIC manually (as opposed to auto selected) - it will be to
allow writes to a node's "status" property in sysfs if the node contains
a true value for the "dynamic" property.
next prev parent reply other threads:[~2021-10-08 19:01 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:09 [PATCH 0/9] Dynamic DT device nodes Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:23 ` Greg Kroah-Hartman
2021-10-07 5:23 ` Greg Kroah-Hartman
2021-10-07 5:58 ` Zev Weiss
2021-10-07 5:58 ` Zev Weiss
2021-10-07 6:12 ` Greg Kroah-Hartman
2021-10-07 6:12 ` Greg Kroah-Hartman
2021-10-07 6:55 ` Zev Weiss
2021-10-07 6:55 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 2/9] sysfs: add growable flag to struct bin_attribute Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 3/9] lib/string: add sysfs_buf_streq() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 4/9] of: add self parameter to __of_sysfs_remove_bin_file() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:25 ` Greg Kroah-Hartman
2021-10-07 5:25 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 5/9] of: add self parameter to of_update_property() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 6/9] of: add support for 'dynamic' DT property Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-08 18:51 ` Frank Rowand
2021-10-08 18:51 ` Frank Rowand
2021-10-08 19:19 ` Frank Rowand
2021-10-08 19:19 ` Frank Rowand
2021-10-11 13:58 ` Frank Rowand
2021-10-11 13:58 ` Frank Rowand
2021-10-11 14:46 ` Frank Rowand
2021-10-11 14:46 ` Frank Rowand
2021-10-11 17:35 ` Zev Weiss
2021-10-11 17:35 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 7/9] of: make OF_DYNAMIC selectable independently of OF_UNITTEST Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-08 19:01 ` Frank Rowand [this message]
2021-10-08 19:01 ` Frank Rowand
2021-10-07 0:09 ` [PATCH 8/9] dt-bindings: document new 'dynamic' common property Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 6:03 ` Zev Weiss
2021-10-07 6:03 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 9/9] ARM: dts: aspeed: Add e3c246d4i BIOS flash device Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 2:46 ` [PATCH 0/9] Dynamic DT device nodes Florian Fainelli
2021-10-07 2:46 ` Florian Fainelli
2021-10-07 2:46 ` Florian Fainelli
2021-10-07 5:44 ` Zev Weiss
2021-10-07 5:44 ` Zev Weiss
2021-10-07 5:44 ` Zev Weiss
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 9:05 ` Zev Weiss
2021-10-07 9:05 ` Zev Weiss
2021-10-07 9:05 ` Zev Weiss
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 15:41 ` Zev Weiss
2021-10-07 15:41 ` Zev Weiss
2021-10-07 15:41 ` Zev Weiss
2021-10-07 20:03 ` Rob Herring
2021-10-07 20:03 ` Rob Herring
2021-10-07 20:03 ` Rob Herring
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 19:43 ` Frank Rowand
2021-10-08 19:43 ` Frank Rowand
2021-10-08 19:43 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288e4900-c23c-56ee-5c23-9a51cd3f315e@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.