From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: openbmc@lists.ozlabs.org, Jeremy Kerr <jk@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] of: add self parameter to of_update_property()
Date: Thu, 7 Oct 2021 07:26:01 +0200 [thread overview]
Message-ID: <YV6E6UcMEOyNCXqW@kroah.com> (raw)
In-Reply-To: <20211007000954.30621-6-zev@bewilderbeest.net>
On Wed, Oct 06, 2021 at 05:09:50PM -0700, Zev Weiss wrote:
> --- a/drivers/of/of_private.h
> +++ b/drivers/of/of_private.h
> @@ -64,7 +64,7 @@ int of_node_is_attached(struct device_node *node);
> int __of_add_property_sysfs(struct device_node *np, struct property *pp);
> void __of_remove_property_sysfs(struct device_node *np, struct property *prop);
> void __of_update_property_sysfs(struct device_node *np, struct property *newprop,
> - struct property *oldprop);
> + struct property *oldprop, bool self);
Again, not a good api decision at all
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 5/9] of: add self parameter to of_update_property()
Date: Thu, 7 Oct 2021 07:26:01 +0200 [thread overview]
Message-ID: <YV6E6UcMEOyNCXqW@kroah.com> (raw)
In-Reply-To: <20211007000954.30621-6-zev@bewilderbeest.net>
On Wed, Oct 06, 2021 at 05:09:50PM -0700, Zev Weiss wrote:
> --- a/drivers/of/of_private.h
> +++ b/drivers/of/of_private.h
> @@ -64,7 +64,7 @@ int of_node_is_attached(struct device_node *node);
> int __of_add_property_sysfs(struct device_node *np, struct property *pp);
> void __of_remove_property_sysfs(struct device_node *np, struct property *prop);
> void __of_update_property_sysfs(struct device_node *np, struct property *newprop,
> - struct property *oldprop);
> + struct property *oldprop, bool self);
Again, not a good api decision at all
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-07 5:26 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:09 [PATCH 0/9] Dynamic DT device nodes Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:23 ` Greg Kroah-Hartman
2021-10-07 5:23 ` Greg Kroah-Hartman
2021-10-07 5:58 ` Zev Weiss
2021-10-07 5:58 ` Zev Weiss
2021-10-07 6:12 ` Greg Kroah-Hartman
2021-10-07 6:12 ` Greg Kroah-Hartman
2021-10-07 6:55 ` Zev Weiss
2021-10-07 6:55 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 2/9] sysfs: add growable flag to struct bin_attribute Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 3/9] lib/string: add sysfs_buf_streq() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 4/9] of: add self parameter to __of_sysfs_remove_bin_file() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:25 ` Greg Kroah-Hartman
2021-10-07 5:25 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 5/9] of: add self parameter to of_update_property() Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman [this message]
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 6/9] of: add support for 'dynamic' DT property Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-08 18:51 ` Frank Rowand
2021-10-08 18:51 ` Frank Rowand
2021-10-08 19:19 ` Frank Rowand
2021-10-08 19:19 ` Frank Rowand
2021-10-11 13:58 ` Frank Rowand
2021-10-11 13:58 ` Frank Rowand
2021-10-11 14:46 ` Frank Rowand
2021-10-11 14:46 ` Frank Rowand
2021-10-11 17:35 ` Zev Weiss
2021-10-11 17:35 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 7/9] of: make OF_DYNAMIC selectable independently of OF_UNITTEST Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-08 19:01 ` Frank Rowand
2021-10-08 19:01 ` Frank Rowand
2021-10-07 0:09 ` [PATCH 8/9] dt-bindings: document new 'dynamic' common property Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 6:03 ` Zev Weiss
2021-10-07 6:03 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 9/9] ARM: dts: aspeed: Add e3c246d4i BIOS flash device Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 0:09 ` Zev Weiss
2021-10-07 2:46 ` [PATCH 0/9] Dynamic DT device nodes Florian Fainelli
2021-10-07 2:46 ` Florian Fainelli
2021-10-07 2:46 ` Florian Fainelli
2021-10-07 5:44 ` Zev Weiss
2021-10-07 5:44 ` Zev Weiss
2021-10-07 5:44 ` Zev Weiss
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 9:05 ` Zev Weiss
2021-10-07 9:05 ` Zev Weiss
2021-10-07 9:05 ` Zev Weiss
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 15:41 ` Zev Weiss
2021-10-07 15:41 ` Zev Weiss
2021-10-07 15:41 ` Zev Weiss
2021-10-07 20:03 ` Rob Herring
2021-10-07 20:03 ` Rob Herring
2021-10-07 20:03 ` Rob Herring
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 19:43 ` Frank Rowand
2021-10-08 19:43 ` Frank Rowand
2021-10-08 19:43 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV6E6UcMEOyNCXqW@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.