All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: linux-rpi-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check
Date: Tue, 8 Dec 2020 08:54:07 +0100	[thread overview]
Message-ID: <3142865d-e3c0-686e-5bb0-865d722b770e@suse.de> (raw)
In-Reply-To: <20201207155719.17149-4-maxime@cerno.tech>


[-- Attachment #1.1.1: Type: text/plain, Size: 1115 bytes --]



Am 07.12.20 um 16:57 schrieb Maxime Ripard:
> Reported-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 63495f6b4aed ("drm/vc4: hdmi: Make sure our clock rate is within limits")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 5a608ed1d75e..a88aa20beeb6 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -796,6 +796,9 @@ static int vc4_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
>   		pixel_rate = mode->clock * 1000;
>   	}
>   
> +	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
> +		pixel_rate = pixel_rate * 2;
> +
>   	if (pixel_rate > vc4_hdmi->variant->max_pixel_clock)
>   		return -EINVAL;
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: linux-rpi-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check
Date: Tue, 8 Dec 2020 08:54:07 +0100	[thread overview]
Message-ID: <3142865d-e3c0-686e-5bb0-865d722b770e@suse.de> (raw)
In-Reply-To: <20201207155719.17149-4-maxime@cerno.tech>


[-- Attachment #1.1.1: Type: text/plain, Size: 1115 bytes --]



Am 07.12.20 um 16:57 schrieb Maxime Ripard:
> Reported-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 63495f6b4aed ("drm/vc4: hdmi: Make sure our clock rate is within limits")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 5a608ed1d75e..a88aa20beeb6 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -796,6 +796,9 @@ static int vc4_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
>   		pixel_rate = mode->clock * 1000;
>   	}
>   
> +	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
> +		pixel_rate = pixel_rate * 2;
> +
>   	if (pixel_rate > vc4_hdmi->variant->max_pixel_clock)
>   		return -EINVAL;
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-08  7:55 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 15:57 [PATCH v5 0/9] drm/vc4: hdmi: Support the 10/12 bit output Maxime Ripard
2020-12-07 15:57 ` Maxime Ripard
2020-12-07 15:57 ` [PATCH v5 1/9] drm/vc4: hvs: Align the HVS atomic hooks to the new API Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-07 15:57 ` [PATCH v5 2/9] drm/vc4: Pass the atomic state to encoder hooks Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-08  7:53   ` Thomas Zimmermann
2020-12-08  7:53     ` Thomas Zimmermann
2020-12-07 15:57 ` [PATCH v5 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-08  7:54   ` Thomas Zimmermann [this message]
2020-12-08  7:54     ` Thomas Zimmermann
2020-12-09 15:29   ` Dave Stevenson
2020-12-09 15:29     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 4/9] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-09 15:20   ` Dave Stevenson
2020-12-09 15:20     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 5/9] drm/vc4: hdmi: Create a custom connector state Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-09 15:22   ` Dave Stevenson
2020-12-09 15:22     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 6/9] drm/vc4: hdmi: Store pixel frequency in the " Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-08  7:55   ` Thomas Zimmermann
2020-12-08  7:55     ` Thomas Zimmermann
2020-12-09 15:32   ` Dave Stevenson
2020-12-09 15:32     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 7/9] drm/vc4: hdmi: Use the connector state pixel rate for the PHY Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-09 15:23   ` Dave Stevenson
2020-12-09 15:23     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 8/9] drm/vc4: hdmi: Limit the BCM2711 to the max without scrambling Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-09 15:23   ` Dave Stevenson
2020-12-09 15:23     ` Dave Stevenson
2020-12-07 15:57 ` [PATCH v5 9/9] drm/vc4: hdmi: Enable 10/12 bpc output Maxime Ripard
2020-12-07 15:57   ` Maxime Ripard
2020-12-09 15:27   ` Dave Stevenson
2020-12-09 15:27     ` Dave Stevenson
2020-12-10 14:21     ` Maxime Ripard
2020-12-10 14:21       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3142865d-e3c0-686e-5bb0-865d722b770e@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=daniel.vetter@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime@cerno.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.