From: Dave Stevenson <dave.stevenson@raspberrypi.com> To: Maxime Ripard <maxime@cerno.tech> Cc: David Airlie <airlied@linux.ie>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, DRI Development <dri-devel@lists.freedesktop.org>, Eric Anholt <eric@anholt.net>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 4/9] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails Date: Wed, 9 Dec 2020 15:20:30 +0000 [thread overview] Message-ID: <CAPY8ntC5VPc8Ctcxdp9vyrt1de2Y3dAO9fpqKJCMNe2gjTAc2A@mail.gmail.com> (raw) In-Reply-To: <20201207155719.17149-5-maxime@cerno.tech> Hi Maxime On Mon, 7 Dec 2020 at 15:57, Maxime Ripard <maxime@cerno.tech> wrote: > > drm_atomic_helper_connector_reset uses kmalloc which, from an API > standpoint, can fail, and thus setting connector->state to NULL. > However, our reset hook then calls drm_atomic_helper_connector_tv_reset > that will access connector->state without checking if it's a valid > pointer or not. > > Make sure we don't end up accessing a NULL pointer. > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > Suggested-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index a88aa20beeb6..61039cc89d9d 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -171,7 +171,9 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector) > static void vc4_hdmi_connector_reset(struct drm_connector *connector) > { > drm_atomic_helper_connector_reset(connector); > - drm_atomic_helper_connector_tv_reset(connector); > + > + if (connector->state) > + drm_atomic_helper_connector_tv_reset(connector); > } > > static const struct drm_connector_funcs vc4_hdmi_connector_funcs = { > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dave Stevenson <dave.stevenson@raspberrypi.com> To: Maxime Ripard <maxime@cerno.tech> Cc: David Airlie <airlied@linux.ie>, DRI Development <dri-devel@lists.freedesktop.org>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 4/9] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails Date: Wed, 9 Dec 2020 15:20:30 +0000 [thread overview] Message-ID: <CAPY8ntC5VPc8Ctcxdp9vyrt1de2Y3dAO9fpqKJCMNe2gjTAc2A@mail.gmail.com> (raw) In-Reply-To: <20201207155719.17149-5-maxime@cerno.tech> Hi Maxime On Mon, 7 Dec 2020 at 15:57, Maxime Ripard <maxime@cerno.tech> wrote: > > drm_atomic_helper_connector_reset uses kmalloc which, from an API > standpoint, can fail, and thus setting connector->state to NULL. > However, our reset hook then calls drm_atomic_helper_connector_tv_reset > that will access connector->state without checking if it's a valid > pointer or not. > > Make sure we don't end up accessing a NULL pointer. > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > Suggested-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index a88aa20beeb6..61039cc89d9d 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -171,7 +171,9 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector) > static void vc4_hdmi_connector_reset(struct drm_connector *connector) > { > drm_atomic_helper_connector_reset(connector); > - drm_atomic_helper_connector_tv_reset(connector); > + > + if (connector->state) > + drm_atomic_helper_connector_tv_reset(connector); > } > > static const struct drm_connector_funcs vc4_hdmi_connector_funcs = { > -- > 2.28.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-09 15:22 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-07 15:57 [PATCH v5 0/9] drm/vc4: hdmi: Support the 10/12 bit output Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-07 15:57 ` [PATCH v5 1/9] drm/vc4: hvs: Align the HVS atomic hooks to the new API Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-07 15:57 ` [PATCH v5 2/9] drm/vc4: Pass the atomic state to encoder hooks Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-08 7:53 ` Thomas Zimmermann 2020-12-08 7:53 ` Thomas Zimmermann 2020-12-07 15:57 ` [PATCH v5 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-08 7:54 ` Thomas Zimmermann 2020-12-08 7:54 ` Thomas Zimmermann 2020-12-09 15:29 ` Dave Stevenson 2020-12-09 15:29 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 4/9] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-09 15:20 ` Dave Stevenson [this message] 2020-12-09 15:20 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 5/9] drm/vc4: hdmi: Create a custom connector state Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-09 15:22 ` Dave Stevenson 2020-12-09 15:22 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 6/9] drm/vc4: hdmi: Store pixel frequency in the " Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-08 7:55 ` Thomas Zimmermann 2020-12-08 7:55 ` Thomas Zimmermann 2020-12-09 15:32 ` Dave Stevenson 2020-12-09 15:32 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 7/9] drm/vc4: hdmi: Use the connector state pixel rate for the PHY Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-09 15:23 ` Dave Stevenson 2020-12-09 15:23 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 8/9] drm/vc4: hdmi: Limit the BCM2711 to the max without scrambling Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-09 15:23 ` Dave Stevenson 2020-12-09 15:23 ` Dave Stevenson 2020-12-07 15:57 ` [PATCH v5 9/9] drm/vc4: hdmi: Enable 10/12 bpc output Maxime Ripard 2020-12-07 15:57 ` Maxime Ripard 2020-12-09 15:27 ` Dave Stevenson 2020-12-09 15:27 ` Dave Stevenson 2020-12-10 14:21 ` Maxime Ripard 2020-12-10 14:21 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPY8ntC5VPc8Ctcxdp9vyrt1de2Y3dAO9fpqKJCMNe2gjTAc2A@mail.gmail.com \ --to=dave.stevenson@raspberrypi.com \ --cc=airlied@linux.ie \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=maxime@cerno.tech \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.