[PATCH] mfd: omap-ush-host: Fix build breakage

[PATCH] mfd: omap-ush-host: Fix build breakage

[Anatolij Gustschin]

Commit 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 (ARM: OMAP3: USB: Fix
the EHCI ULPI PHY reset issue) removed #include <linux/gpio.h> which
indirectly includes 'plat/cpu.h'. This caused build breakage:

drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'omap_rev'
drivers/mfd/omap-usb-host.c:525:43: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)

Include <plat/cpu.h> to fix it.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Keshava Munegowda <Keshava_mgowda@ti.com>
---
 drivers/mfd/omap-usb-host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c8aae66..7e96bb2 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -25,6 +25,7 @@
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
+#include <plat/cpu.h>
 #include <plat/usb.h>
 #include <linux/pm_runtime.h>
 
-- 
1.7.1

Re: [PATCH] mfd: omap-ush-host: Fix build breakage

[Munegowda, Keshava]

On Sun, Apr 22, 2012 at 10:38 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Commit 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 (ARM: OMAP3: USB: Fix
> the EHCI ULPI PHY reset issue) removed #include <linux/gpio.h> which
> indirectly includes 'plat/cpu.h'. This caused build breakage:
>
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'omap_rev'
> drivers/mfd/omap-usb-host.c:525:43: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)
>
> Include <plat/cpu.h> to fix it.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Keshava Munegowda <Keshava_mgowda@ti.com>
> ---
>  drivers/mfd/omap-usb-host.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index c8aae66..7e96bb2 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -25,6 +25,7 @@
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/spinlock.h>
> +#include <plat/cpu.h>
>  #include <plat/usb.h>
>  #include <linux/pm_runtime.h>
>
> --
> 1.7.1
>

Yes, this seems correct!
But, on which config you are seeing this error?

regards
keshava

Re: [PATCH] mfd: omap-ush-host: Fix build breakage

[Anatolij Gustschin]

On Mon, 23 Apr 2012 11:47:25 +0530
"Munegowda, Keshava" <keshava_mgowda@ti.com> wrote:
...
> Yes, this seems correct!
> But, on which config you are seeing this error?

I was working on some drivers for am3517 based board and I'm seeing
this error since I rebased by patches on v3.4-rc4.

Thanks,
Anatolij

Re: [PATCH] mfd: omap-ush-host: Fix build breakage

[Munegowda, Keshava]

On Tue, Apr 24, 2012 at 12:15 AM, Anatolij Gustschin <agust@denx.de> wrote:
> On Mon, 23 Apr 2012 11:47:25 +0530
> "Munegowda, Keshava" <keshava_mgowda@ti.com> wrote:
> ...
>> Yes, this seems correct!
>> But, on which config you are seeing this error?
>
> I was working on some drivers for am3517 based board and I'm seeing
> this error since I rebased by patches on v3.4-rc4.
>
> Thanks,
> Anatolij

Thanks Anatoliji
        yes, I dont have am3517 setup; I have validated this patch on
omap3 sdp and omap4 sdp

regards
keshava

Re: [PATCH] mfd: omap-ush-host: Fix build breakage

[Arend van Spriel]

On 04/22/2012 07:08 PM, Anatolij Gustschin wrote:
> Commit 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 (ARM: OMAP3: USB: Fix
> the EHCI ULPI PHY reset issue) removed #include<linux/gpio.h>  which
> indirectly includes 'plat/cpu.h'. This caused build breakage:
>
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'omap_rev'
> drivers/mfd/omap-usb-host.c:525:43: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)
>
> Include<plat/cpu.h>  to fix it.
>
> Signed-off-by: Anatolij Gustschin<agust@denx.de>
> Cc: Keshava Munegowda<Keshava_mgowda@ti.com>

Build failed on OMAP4 Pandaboard as well. Applied the patch and 
successfully built.

Tested-by: Arend van Spriel <arend@broadcom.com>

Gr. AvS