Re: [PATCH v2 3/5] can: flexcan: Add ls1021a flexcan device entry - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Bhupesh Sharma <bhupesh.sharma@freescale.com>,
	arnd@arndb.de, linux-can@vger.kernel.org
Cc: bhupesh.linux@gmail.com, Sakar.Arora@freescale.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/5] can: flexcan: Add ls1021a flexcan device entry
Date: Thu, 14 May 2015 17:38:02 +0200	[thread overview]
Message-ID: <5554C15A.6050501@pengutronix.de> (raw)
In-Reply-To: <1431603215-25546-4-git-send-email-bhupesh.sharma@freescale.com>

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On 05/14/2015 01:33 PM, Bhupesh Sharma wrote:
> This patch adds ls1021a flexcan device entry to the flexcan driver code.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> ---
>  drivers/net/can/flexcan.c |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index ad0a7e8..deaa24e 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -267,10 +267,26 @@ static struct flexcan_devtype_data fsl_imx28_devtype_data;
>  static struct flexcan_devtype_data fsl_imx6q_devtype_data = {
>  	.features = FLEXCAN_HAS_V10_FEATURES,
>  };
> +
>  static struct flexcan_devtype_data fsl_vf610_devtype_data = {
>  	.features = FLEXCAN_HAS_V10_FEATURES | FLEXCAN_HAS_MECR_FEATURES,
>  };
>  
> +/* LS1021A-Rev1 has a broken RX-FIFO support. So only legacy RX message-buffers
> + * work here.
> + */
> +static struct flexcan_devtype_data fsl_ls1021a_devtype_data = {
> +	.features = FLEXCAN_HAS_V10_FEATURES | FLEXCAN_HAS_MECR_FEATURES |
> +		    FLEXCAN_HAS_ONLY_LEGACY_RX_SUPPORT,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This will probably not compile.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]